2015-09-16 16:21:47

by Aparna Karuthodi

Subject: [PATCH] staging: wilc1000: Removed unwanted curly braces

Removed unwanted curly braces of a single statement if-else block to
remove a coding style warning detected by checkpatch. The warning is
given below:

58: WARNING: braces {} are not necessary for any arm of this statement

Signed-off-by: Aparna Karuthodi <[email protected]>
---
drivers/staging/wilc1000/fifo_buffer.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wilc1000/fifo_buffer.c b/drivers/staging/wilc1000/fifo_buffer.c
index b6c07cf..4fbac3d 100644
--- a/drivers/staging/wilc1000/fifo_buffer.c
+++ b/drivers/staging/wilc1000/fifo_buffer.c
@@ -52,11 +52,10 @@ u32 FIFO_ReadBytes(tHANDLE hFifo, u8 *pu8Buffer, u32 u32BytesToRead, u32 *pu32By
if (pstrFifoHandler->u32TotalBytes) {
down(&pstrFifoHandler->SemBuffer);

- if (u32BytesToRead > pstrFifoHandler->u32TotalBytes) {
+ if (u32BytesToRead > pstrFifoHandler->u32TotalBytes)
*pu32BytesRead = pstrFifoHandler->u32TotalBytes;
- } else {
+ else
*pu32BytesRead = u32BytesToRead;
- }
if ((pstrFifoHandler->u32ReadOffset + u32BytesToRead) <= pstrFifoHandler->u32BufferLength) {
WILC_memcpy(pu8Buffer, pstrFifoHandler->pu8Buffer + pstrFifoHandler->u32ReadOffset,
*pu32BytesRead);
--
1.7.9.5

2015-09-16 20:18:55

by Dan Carpenter

Subject: Re: [PATCH] staging: wilc1000: Removed unwanted curly braces

On Wed, Sep 16, 2015 at 09:50:50PM +0530, Aparna Karuthodi wrote:
> Removed unwanted curly braces of a single statement if-else block to
> remove a coding style warning detected by checkpatch. The warning is
> given below:
>
> 58: WARNING: braces {} are not necessary for any arm of this statement
>
> Signed-off-by: Aparna Karuthodi <[email protected]>
> ---
> drivers/staging/wilc1000/fifo_buffer.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/fifo_buffer.c b/drivers/staging/wilc1000/fifo_buffer.c
> index b6c07cf..4fbac3d 100644
> --- a/drivers/staging/wilc1000/fifo_buffer.c
> +++ b/drivers/staging/wilc1000/fifo_buffer.c
> @@ -52,11 +52,10 @@ u32 FIFO_ReadBytes(tHANDLE hFifo, u8 *pu8Buffer, u32 u32BytesToRead, u32 *pu32By
> if (pstrFifoHandler->u32TotalBytes) {
> down(&pstrFifoHandler->SemBuffer);
>
> - if (u32BytesToRead > pstrFifoHandler->u32TotalBytes) {
> + if (u32BytesToRead > pstrFifoHandler->u32TotalBytes)
> *pu32BytesRead = pstrFifoHandler->u32TotalBytes;
> - } else {
> + else

The indenting is wrong here. There is an extra space char.

regards,
dan carpenter