2017-11-28 15:55:09

by Ashish Kalra

Subject: [PATCH v3] bcma:Adjust block comments

use * for block comments in multiple lines according to kernel coding
style

Reported by: checkpatch.pl

Signed-off-by: Ashish Kalra <[email protected]>
---
Change log:
-v3: Improvement on commit message as per review from Morgan Freeman <[email protected]>
-v2: Improvement on commit message as per review from Morgan Freeman <[email protected]>(https://lkml.org/lkml/2017/11/27/1259)
-v1: https://lkml.org/lkml/2017/11/26/85

drivers/bcma/driver_pcie2.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/bcma/driver_pcie2.c b/drivers/bcma/driver_pcie2.c
index b1a6e327cb23..cf889fc62ac7 100644
--- a/drivers/bcma/driver_pcie2.c
+++ b/drivers/bcma/driver_pcie2.c
@@ -83,7 +83,8 @@ static void bcma_core_pcie2_hw_ltr_war(struct bcma_drv_pcie2 *pcie2)
bcma_core_pcie2_set_ltr_vals(pcie2);

/* TODO:
- si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0); */
+ *si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0);
+ */

/* enable the LTR */
devstsctr2 |= PCIE2_CAP_DEVSTSCTRL2_LTRENAB;
--
2.14.1

2017-11-28 16:06:03

by Himanshu Jha

Subject: Re: [PATCH v3] bcma:Adjust block comments

Hi Ashish,

On Tue, Nov 28, 2017 at 09:24:58PM +0530, Ashish Kalra wrote:
> use * for block comments in multiple lines according to kernel coding
> style
>
> Reported by: checkpatch.pl
>
> Signed-off-by: Ashish Kalra <[email protected]>
> ---

Looks good now!
FWIW,

Reviewed-by: Himanshu Jha <[email protected]>


> Change log:
> -v3: Improvement on commit message as per review from Morgan Freeman <[email protected]>

BTW, this <[email protected]> is my secondary email subscibed
to linux-wirless as I don't want my primary email to be flooded with
frequent emails, and my upstream mail is [email protected] !



Thanks
Himanshu Jha

2017-12-07 13:35:09

by Kalle Valo

Subject: Re: [v3] bcma: Adjust block comment

Ashish Kalra <[email protected]> wrote:

> use * for block comments in multiple lines according to kernel coding
> style
>
> Reported by: checkpatch.pl
>
> Signed-off-by: Ashish Kalra <[email protected]>
> Reviewed-by: Himanshu Jha <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

a765c8fdc869 bcma: Adjust block comment

--
https://patchwork.kernel.org/patch/10080747/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches