2018-10-27 07:31:33

by Martin Willi

[permalink] [raw]
Subject: [PATCH] nl80211: announce radios/interfaces when switching namespaces

When a wiphy changes its namespace, all interfaces are moved to the
new namespace as well. The network interfaces are properly announced
as leaving on the old and as appearing on the new namespace through
RTM_NEWLINK/RTM_DELLINK. On nl80211, however, these events are missing
for radios and their interfaces.

Add netlink announcements through nl80211 when switching namespaces,
so userspace can rely on these events to discover radios properly.

Signed-off-by: Martin Willi <[email protected]>
---
net/wireless/core.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/net/wireless/core.c b/net/wireless/core.c
index 5bd01058b9e6..286617396d14 100644
--- a/net/wireless/core.c
+++ b/net/wireless/core.c
@@ -190,11 +190,25 @@ int cfg80211_switch_netns(struct cfg80211_registered_device *rdev,
return err;
}

+ list_for_each_entry(wdev, &rdev->wiphy.wdev_list, list) {
+ if (!wdev->netdev)
+ continue;
+ nl80211_notify_iface(rdev, wdev, NL80211_CMD_DEL_INTERFACE);
+ }
+ nl80211_notify_wiphy(rdev, NL80211_CMD_DEL_WIPHY);
+
wiphy_net_set(&rdev->wiphy, net);

err = device_rename(&rdev->wiphy.dev, dev_name(&rdev->wiphy.dev));
WARN_ON(err);

+ nl80211_notify_wiphy(rdev, NL80211_CMD_NEW_WIPHY);
+ list_for_each_entry(wdev, &rdev->wiphy.wdev_list, list) {
+ if (!wdev->netdev)
+ continue;
+ nl80211_notify_iface(rdev, wdev, NL80211_CMD_NEW_INTERFACE);
+ }
+
return 0;
}

--
2.17.1