2019-09-07 06:59:37

by Colin King

[permalink] [raw]
Subject: [PATCH] ssb: make array pwr_info_offset static const, makes object smaller

From: Colin Ian King <[email protected]>

Don't populate the array pwr_info_offset on the stack but instead make it
static const. Makes the object code smaller by 207 bytes.

Before:
text data bss dec hex filename
26066 3000 64 29130 71ca drivers/ssb/pci.o

After:
text data bss dec hex filename
25763 3096 64 28923 70fb drivers/ssb/pci.o

(gcc version 9.2.1, amd64)

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/ssb/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c
index da2d2ab8104d..7c3ae52f2b15 100644
--- a/drivers/ssb/pci.c
+++ b/drivers/ssb/pci.c
@@ -595,7 +595,7 @@ static void sprom_extract_r8(struct ssb_sprom *out, const u16 *in)
{
int i;
u16 o;
- u16 pwr_info_offset[] = {
+ static const u16 pwr_info_offset[] = {
SSB_SROM8_PWR_INFO_CORE0, SSB_SROM8_PWR_INFO_CORE1,
SSB_SROM8_PWR_INFO_CORE2, SSB_SROM8_PWR_INFO_CORE3
};
--
2.20.1


2019-09-10 09:20:18

by Michael Büsch

[permalink] [raw]
Subject: Re: [PATCH] ssb: make array pwr_info_offset static const, makes object smaller

On Fri, 6 Sep 2019 16:40:53 +0100
Colin King <[email protected]> wrote:

> diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c
> index da2d2ab8104d..7c3ae52f2b15 100644
> --- a/drivers/ssb/pci.c
> +++ b/drivers/ssb/pci.c
> @@ -595,7 +595,7 @@ static void sprom_extract_r8(struct ssb_sprom *out, const u16 *in)
> {
> int i;
> u16 o;
> - u16 pwr_info_offset[] = {
> + static const u16 pwr_info_offset[] = {
> SSB_SROM8_PWR_INFO_CORE0, SSB_SROM8_PWR_INFO_CORE1,
> SSB_SROM8_PWR_INFO_CORE2, SSB_SROM8_PWR_INFO_CORE3
> };

Thanks for your contribution. This change makes sense.

Kalle, can you please take it?

Acked-by: Michael Büsch <[email protected]>

--
Michael

Attachments:
(No filename) (849.00 B)
OpenPGP digital signature

2019-09-13 15:33:40

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] ssb: make array pwr_info_offset static const, makes object smaller

Colin King <[email protected]> wrote:

> From: Colin Ian King <[email protected]>
>
> Don't populate the array pwr_info_offset on the stack but instead make it
> static const. Makes the object code smaller by 207 bytes.
>
> Before:
> text data bss dec hex filename
> 26066 3000 64 29130 71ca drivers/ssb/pci.o
>
> After:
> text data bss dec hex filename
> 25763 3096 64 28923 70fb drivers/ssb/pci.o
>
> (gcc version 9.2.1, amd64)
>
> Signed-off-by: Colin Ian King <[email protected]>
> Acked-by: Michael Büsch <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

d3bb26868105 ssb: make array pwr_info_offset static const, makes object smaller

--
https://patchwork.kernel.org/patch/11135599/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches