2019-12-09 10:29:35

by Nicolas Cavallari

[permalink] [raw]
Subject: [RFC PATCH v1 3/4] mwifiex: Do not allow deleting station in IBSS mode.

In preparation of allowing userspace to explicitly reset station state
in IBSS mode, reject attempts to delete stations in IBSS mode with error
ENOTSUPP.

Signed-off-by: Nicolas Cavallari <[email protected]>
--
I do not know if the driver could possibly support this, so take the
safe route and reject it.
---
drivers/net/wireless/marvell/mwifiex/cfg80211.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
index d89684168500..9135fc6d5a70 100644
--- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
+++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
@@ -1828,6 +1828,10 @@ mwifiex_cfg80211_del_station(struct wiphy *wiphy, struct net_device *dev,
struct mwifiex_sta_node *sta_node;
u8 deauth_mac[ETH_ALEN];

+ if (priv->bss_mode != NL80211_IFTYPE_AP &&
+ priv->bss_mode != NL80211_IFTYPE_P2P_GO)
+ return -ENOTSUPP;
+
if (!priv->bss_started && priv->wdev.cac_started) {
mwifiex_dbg(priv->adapter, INFO, "%s: abort CAC!\n", __func__);
mwifiex_abort_cac(priv);
--
2.24.0