2020-03-25 16:43:47

by Ajay Singh

[permalink] [raw]
Subject: [PATCH] staging: wilc1000: remove label from examples in DT binding documentation

From: Ajay Singh <[email protected]>

Remove labels and not relevant property from DT binding documentation
examples as suggested in [1].

1. https://patchwork.ozlabs.org/patch/1252837

Signed-off-by: Ajay Singh <[email protected]>
---
drivers/staging/wilc1000/microchip,wilc1000.yaml | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wilc1000/microchip,wilc1000.yaml b/drivers/staging/wilc1000/microchip,wilc1000.yaml
index bc6cc5d3f347..2c320eb2a8c4 100644
--- a/drivers/staging/wilc1000/microchip,wilc1000.yaml
+++ b/drivers/staging/wilc1000/microchip,wilc1000.yaml
@@ -36,10 +36,9 @@ required:

examples:
- |
- spi1: spi@fc018000 {
+ spi {
#address-cells = <1>;
#size-cells = <0>;
- cs-gpios = <&pioB 21 0>;
wifi@0 {
compatible = "microchip,wilc1000";
spi-max-frequency = <48000000>;
@@ -52,7 +51,7 @@ examples:
};

- |
- mmc1: mmc@fc000000 {
+ mmc {
#address-cells = <1>;
#size-cells = <0>;
pinctrl-names = "default";
--
2.24.0


2020-03-26 07:45:58

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] staging: wilc1000: remove label from examples in DT binding documentation

<[email protected]> writes:

> From: Ajay Singh <[email protected]>
>
> Remove labels and not relevant property from DT binding documentation
> examples as suggested in [1].
>
> 1. https://patchwork.ozlabs.org/patch/1252837

Just a nitpick but patchwork links are not that reliable in the long
run. Instead using a lore link is better as the message id is visible
directly from the URL.

--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2020-03-26 08:15:22

by Ajay Singh

[permalink] [raw]
Subject: Re: [PATCH] staging: wilc1000: remove label from examples in DT binding documentation

Hi Kalle,

On 26/03/20 1:15 pm, Kalle Valo wrote:
>
> <[email protected]> writes:
>
>> From: Ajay Singh <[email protected]>
>>
>> Remove labels and not relevant property from DT binding documentation
>> examples as suggested in [1].
>>
>> 1. https://patchwork.ozlabs.org/patch/1252837
>
> Just a nitpick but patchwork links are not that reliable in the long
> run. Instead using a lore link is better as the message id is visible
> directly from the URL.
>

Sure. I will make use of lore link for future patches as this patch is
already applied.


Regards,
Ajay