2020-04-18 06:38:51

by Jason Yan

Subject: [PATCH 0/5] rtlwifi: use true,false for bool variables

Fix some coccicheck warnings.

Jason Yan (5):
rtlwifi: rtl8188ee: use true,false for bool variables
rtlwifi: rtl8723ae: use true,false for bool variables
rtlwifi: rtl8192ee: use true,false for bool variables
rtlwifi: rtl8723be: use true,false for bool variables
rtlwifi: rtl8821ae: use true,false for bool variables

drivers/net/wireless/realtek/rtlwifi/rtl8188ee/sw.c | 4 ++--
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/sw.c | 4 ++--
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c | 4 ++--
drivers/net/wireless/realtek/rtlwifi/rtl8723be/sw.c | 4 ++--
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/sw.c | 4 ++--
5 files changed, 10 insertions(+), 10 deletions(-)

--
2.21.1

2020-04-18 06:40:32

by Jason Yan

Subject: [PATCH 1/5] rtlwifi: rtl8188ee: use true,false for bool variables

Fix the following coccicheck warning:

drivers/net/wireless/realtek/rtlwifi/rtl8188ee/sw.c:70:1-34: WARNING:
Assignment of 0/1 to bool variable
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/sw.c:72:1-34: WARNING:
Assignment of 0/1 to bool variable

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Jason Yan <[email protected]>
---
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/sw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/sw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/sw.c
index 4865639ac9ea..02b77521b5cd 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/sw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/sw.c
@@ -67,9 +67,9 @@ static int rtl88e_init_sw_vars(struct ieee80211_hw *hw)
char *fw_name;

rtl8188ee_bt_reg_init(hw);
- rtlpriv->dm.dm_initialgain_enable = 1;
+ rtlpriv->dm.dm_initialgain_enable = true;
rtlpriv->dm.dm_flag = 0;
- rtlpriv->dm.disable_framebursting = 0;
+ rtlpriv->dm.disable_framebursting = false;
rtlpriv->dm.thermalvalue = 0;
rtlpci->transmit_config = CFENDFORM | BIT(15);

--
2.21.1

2020-04-21 12:59:43

by Kalle Valo

Subject: Re: [PATCH 1/5] rtlwifi: rtl8188ee: use true,false for bool variables

Jason Yan <[email protected]> wrote:

> Fix the following coccicheck warning:
>
> drivers/net/wireless/realtek/rtlwifi/rtl8188ee/sw.c:70:1-34: WARNING:
> Assignment of 0/1 to bool variable
> drivers/net/wireless/realtek/rtlwifi/rtl8188ee/sw.c:72:1-34: WARNING:
> Assignment of 0/1 to bool variable
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Jason Yan <[email protected]>

5 patches applied to wireless-drivers-next.git, thanks.

bec095ab477d rtlwifi: rtl8188ee: use true,false for bool variables
23c2ddb574c6 rtlwifi: rtl8723ae: use true,false for bool variables
c13a83b01010 rtlwifi: rtl8192ee: use true,false for bool variables
47361089d987 rtlwifi: rtl8723be: use true,false for bool variables
e8277abd453d rtlwifi: rtl8821ae: use true,false for bool variables

--
https://patchwork.kernel.org/patch/11496299/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches