2020-04-20 12:11:33

by Jason Yan

Subject: [PATCH] ath11k: remove conversion to bool in ath11k_dp_rxdesc_mpdu_valid()

The '==' expression itself is bool, no need to convert it to bool again.
This fixes the following coccicheck warning:

drivers/net/wireless/ath/ath11k/dp_rx.c:255:46-51: WARNING: conversion
to bool not needed here

Signed-off-by: Jason Yan <[email protected]>
---
drivers/net/wireless/ath/ath11k/dp_rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
index 203fd44ff352..bbd7da48518f 100644
--- a/drivers/net/wireless/ath/ath11k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
@@ -252,7 +252,7 @@ static bool ath11k_dp_rxdesc_mpdu_valid(struct hal_rx_desc *rx_desc)
tlv_tag = FIELD_GET(HAL_TLV_HDR_TAG,
__le32_to_cpu(rx_desc->mpdu_start_tag));

- return tlv_tag == HAL_RX_MPDU_START ? true : false;
+ return tlv_tag == HAL_RX_MPDU_START;
}

static u32 ath11k_dp_rxdesc_get_ppduid(struct hal_rx_desc *rx_desc)
--
2.21.1

2020-04-22 06:43:01

by Kalle Valo

Subject: Re: [PATCH] ath11k: remove conversion to bool in ath11k_dp_rxdesc_mpdu_valid()

Jason Yan <[email protected]> wrote:

> The '==' expression itself is bool, no need to convert it to bool again.
> This fixes the following coccicheck warning:
>
> drivers/net/wireless/ath/ath11k/dp_rx.c:255:46-51: WARNING: conversion
> to bool not needed here
>
> Signed-off-by: Jason Yan <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

8af40902f839 ath11k: remove conversion to bool in ath11k_dp_rxdesc_mpdu_valid()

--
https://patchwork.kernel.org/patch/11498781/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches