2020-04-24 15:47:17

by Christophe JAILLET

Subject: [PATCH v2] ipw2x00: Remove a memory allocation failure log message

Axe a memory allocation failure log message. This message is useless and
incorrect (vmalloc is not used here for the memory allocation)

This has been like that since the very beginning of this driver in
commit 43f66a6ce8da ("Add ipw2200 wireless driver.")

Signed-off-by: Christophe JAILLET <[email protected]>
---
v2: remove a useless empty line
---
drivers/net/wireless/intel/ipw2x00/ipw2200.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2200.c b/drivers/net/wireless/intel/ipw2x00/ipw2200.c
index 60b5e08dd6df..30c4f041f565 100644
--- a/drivers/net/wireless/intel/ipw2x00/ipw2200.c
+++ b/drivers/net/wireless/intel/ipw2x00/ipw2200.c
@@ -3770,10 +3770,8 @@ static int ipw_queue_tx_init(struct ipw_priv *priv,
struct pci_dev *dev = priv->pci_dev;

q->txb = kmalloc_array(count, sizeof(q->txb[0]), GFP_KERNEL);
- if (!q->txb) {
- IPW_ERROR("vmalloc for auxiliary BD structures failed\n");
+ if (!q->txb)
return -ENOMEM;
- }

q->bd =
pci_alloc_consistent(dev, sizeof(q->bd[0]) * count, &q->q.dma_addr);
--
2.20.1

2020-05-06 08:33:30

by Kalle Valo

Subject: Re: [PATCH v2] ipw2x00: Remove a memory allocation failure log message

Christophe JAILLET <[email protected]> wrote:

> Axe a memory allocation failure log message. This message is useless and
> incorrect (vmalloc is not used here for the memory allocation)
>
> This has been like that since the very beginning of this driver in
> commit 43f66a6ce8da ("Add ipw2200 wireless driver.")
>
> Signed-off-by: Christophe JAILLET <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

c03e3fe91c19 ipw2x00: Remove a memory allocation failure log message

--
https://patchwork.kernel.org/patch/11508307/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches