2020-04-27 10:45:29

by Wei Yongjun

Subject: [PATCH net-next] ath11k: remove redundant dev_err call in ath11k_ahb_probe()

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/net/wireless/ath/ath11k/ahb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c
index e7e3e64c07aa..7d3d1cc6f39f 100644
--- a/drivers/net/wireless/ath/ath11k/ahb.c
+++ b/drivers/net/wireless/ath/ath11k/ahb.c
@@ -897,10 +897,8 @@ static int ath11k_ahb_probe(struct platform_device *pdev)
}

mem = devm_ioremap_resource(&pdev->dev, mem_res);
- if (IS_ERR(mem)) {
- dev_err(&pdev->dev, "ioremap error\n");
+ if (IS_ERR(mem))
return PTR_ERR(mem);
- }

ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
if (ret) {

2020-04-28 09:29:21

by Kalle Valo

Subject: Re: [PATCH net-next] ath11k: remove redundant dev_err call in ath11k_ahb_probe()

Wei Yongjun <[email protected]> wrote:

> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <[email protected]>

I don't see harm having two error messages and having an error message
within ath11k makes it easier to find the exact location, so I'm
dropping this.

--
https://patchwork.kernel.org/patch/11511845/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches