2020-04-29 14:11:12

by Jason Yan

Subject: [PATCH] rtlwifi: remove comparison of 0/1 to bool variable

The variable 'rtlpriv->rfkill.rfkill_state' is bool and can directly
assigned to bool values.

Fix the following coccicheck warning:

drivers/net/wireless/realtek/rtlwifi/core.c:1725:14-42: WARNING:
Comparison of 0/1 to bool variable

Signed-off-by: Jason Yan <[email protected]>
---
drivers/net/wireless/realtek/rtlwifi/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c b/drivers/net/wireless/realtek/rtlwifi/core.c
index f73e690bbe8e..4dd82c6052f0 100644
--- a/drivers/net/wireless/realtek/rtlwifi/core.c
+++ b/drivers/net/wireless/realtek/rtlwifi/core.c
@@ -1722,7 +1722,7 @@ static void rtl_op_rfkill_poll(struct ieee80211_hw *hw)
"wireless radio switch turned %s\n",
radio_state ? "on" : "off");

- blocked = (rtlpriv->rfkill.rfkill_state == 1) ? 0 : 1;
+ blocked = !rtlpriv->rfkill.rfkill_state;
wiphy_rfkill_set_hw_state(hw->wiphy, blocked);
}
}
--
2.21.1

2020-05-06 08:45:12

by Kalle Valo

Subject: Re: [PATCH] rtlwifi: remove comparison of 0/1 to bool variable

Jason Yan <[email protected]> wrote:

> The variable 'rtlpriv->rfkill.rfkill_state' is bool and can directly
> assigned to bool values.
>
> Fix the following coccicheck warning:
>
> drivers/net/wireless/realtek/rtlwifi/core.c:1725:14-42: WARNING:
> Comparison of 0/1 to bool variable
>
> Signed-off-by: Jason Yan <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

1b56bed20212 rtlwifi: remove comparison of 0/1 to bool variable

--
https://patchwork.kernel.org/patch/11517573/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches