2020-04-26 09:42:46

by Jason Yan

Subject: [PATCH] brcmfmac: remove comparison to bool in brcmf_fws_attach()

Fix the following coccicheck warning:

drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c:2359:6-40:
WARNING: Comparison to bool

Signed-off-by: Jason Yan <[email protected]>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c
index 8cc52935fd41..2b7837887c0b 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c
@@ -2356,7 +2356,7 @@ struct brcmf_fws_info *brcmf_fws_attach(struct brcmf_pub *drvr)
fws->drvr = drvr;
fws->fcmode = drvr->settings->fcmode;

- if ((drvr->bus_if->always_use_fws_queue == false) &&
+ if (!drvr->bus_if->always_use_fws_queue &&
(fws->fcmode == BRCMF_FWS_FCMODE_NONE)) {
fws->avoid_queueing = true;
brcmf_dbg(INFO, "FWS queueing will be avoided\n");
--
2.21.1

2020-04-27 07:48:55

by Chi-Hsien Lin

Subject: Re: [PATCH] brcmfmac: remove comparison to bool in brcmf_fws_attach()

On 04/26/2020 5:40, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c:2359:6-40:
> WARNING: Comparison to bool
>
> Signed-off-by: Jason Yan <[email protected]>
Reviewed-by: Chi-hsien Lin <[email protected]>

> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c
> index 8cc52935fd41..2b7837887c0b 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c
> @@ -2356,7 +2356,7 @@ struct brcmf_fws_info *brcmf_fws_attach(struct brcmf_pub *drvr)
> fws->drvr = drvr;
> fws->fcmode = drvr->settings->fcmode;
>
> - if ((drvr->bus_if->always_use_fws_queue == false) &&
> + if (!drvr->bus_if->always_use_fws_queue &&
> (fws->fcmode == BRCMF_FWS_FCMODE_NONE)) {
> fws->avoid_queueing = true;
> brcmf_dbg(INFO, "FWS queueing will be avoided\n");
>

2020-05-04 09:51:18

by Kalle Valo

Subject: Re: [PATCH] brcmfmac: remove comparison to bool in brcmf_fws_attach()

Jason Yan <[email protected]> wrote:

> Fix the following coccicheck warning:
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c:2359:6-40:
> WARNING: Comparison to bool
>
> Signed-off-by: Jason Yan <[email protected]>
> Reviewed-by: Chi-hsien Lin <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

ff2af09f4515 brcmfmac: remove comparison to bool in brcmf_fws_attach()

--
https://patchwork.kernel.org/patch/11510329/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches