2021-01-05 10:32:31

by Arend van Spriel

Subject: [PATCH] cfg80211: add VHT rate entries for MCS-10 and MCS-11

Observed the warning in cfg80211_calculate_bitrate_vht() using an
11ac chip reporting MCS-11. Since devices reporting non-standard
MCS-9 is already supported add similar entries for MCS-10 and MCS-11.

Signed-off-by: Arend van Spriel <[email protected]>
---
net/wireless/util.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/net/wireless/util.c b/net/wireless/util.c
index b4acc805114b..19fd4db6d32f 100644
--- a/net/wireless/util.c
+++ b/net/wireless/util.c
@@ -1236,6 +1236,8 @@ static u32 cfg80211_calculate_bitrate_vht(struct rate_info *rate)
78000000,
/* not in the spec, but some devices use this: */
86500000,
+ 97500000,
+ 108300000,
},
{ 13500000,
27000000,
@@ -1247,6 +1249,8 @@ static u32 cfg80211_calculate_bitrate_vht(struct rate_info *rate)
135000000,
162000000,
180000000,
+ 202500000,
+ 225000000,
},
{ 29300000,
58500000,
@@ -1258,6 +1262,8 @@ static u32 cfg80211_calculate_bitrate_vht(struct rate_info *rate)
292500000,
351000000,
390000000,
+ 438800000,
+ 487500000,
},
{ 58500000,
117000000,
@@ -1269,12 +1275,14 @@ static u32 cfg80211_calculate_bitrate_vht(struct rate_info *rate)
585000000,
702000000,
780000000,
+ 877500000,
+ 975000000,
},
};
u32 bitrate;
int idx;

- if (rate->mcs > 9)
+ if (rate->mcs > 11)
goto warn;

switch (rate->bw) {
--
2.17.1

2021-01-05 10:43:29

by Arend van Spriel

Subject: Re: [PATCH] cfg80211: add VHT rate entries for MCS-10 and MCS-11

+ Johannes (corrected email address)

On 1/5/2021 11:22 AM, Arend van Spriel wrote:
> Observed the warning in cfg80211_calculate_bitrate_vht() using an
> 11ac chip reporting MCS-11. Since devices reporting non-standard
> MCS-9 is already supported add similar entries for MCS-10 and MCS-11.
>
> Signed-off-by: Arend van Spriel <[email protected]>
> ---
> net/wireless/util.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/net/wireless/util.c b/net/wireless/util.c
> index b4acc805114b..19fd4db6d32f 100644
> --- a/net/wireless/util.c
> +++ b/net/wireless/util.c
> @@ -1236,6 +1236,8 @@ static u32 cfg80211_calculate_bitrate_vht(struct rate_info *rate)
> 78000000,
> /* not in the spec, but some devices use this: */
> 86500000,
> + 97500000,
> + 108300000,
> },
> { 13500000,
> 27000000,
> @@ -1247,6 +1249,8 @@ static u32 cfg80211_calculate_bitrate_vht(struct rate_info *rate)
> 135000000,
> 162000000,
> 180000000,
> + 202500000,
> + 225000000,
> },
> { 29300000,
> 58500000,
> @@ -1258,6 +1262,8 @@ static u32 cfg80211_calculate_bitrate_vht(struct rate_info *rate)
> 292500000,
> 351000000,
> 390000000,
> + 438800000,
> + 487500000,
> },
> { 58500000,
> 117000000,
> @@ -1269,12 +1275,14 @@ static u32 cfg80211_calculate_bitrate_vht(struct rate_info *rate)
> 585000000,
> 702000000,
> 780000000,
> + 877500000,
> + 975000000,
> },
> };
> u32 bitrate;
> int idx;
>
> - if (rate->mcs > 9)
> + if (rate->mcs > 11)
> goto warn;
>
> switch (rate->bw) {
>

2021-01-05 13:22:19

by Arend van Spriel

Subject: Re: [PATCH] cfg80211: add VHT rate entries for MCS-10 and MCS-11

On 05-01-2021 11:22, Arend van Spriel wrote:
> Observed the warning in cfg80211_calculate_bitrate_vht() using an
> 11ac chip reporting MCS-11. Since devices reporting non-standard
> MCS-9 is already supported add similar entries for MCS-10 and MCS-11.
>
> Signed-off-by: Arend van Spriel <[email protected]>
> ---
> net/wireless/util.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)

Submitted a V2 so please discard this one.

Regards,
Arend
---
V1:https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/
V2:
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/