2021-03-26 08:15:38

by Zhang Jianhua

[permalink] [raw]
Subject: [PATCH -next] drivers: net: CONFIG_ATH9K select LEDS_CLASS

If CONFIG_ATH9K=y, the following errors will be seen while compiling
gpio.c

drivers/net/wireless/ath/ath9k/gpio.o: In function `ath_deinit_leds':
gpio.c:(.text+0x604): undefined reference to `led_classdev_unregister'
gpio.c:(.text+0x604): relocation truncated to fit: R_AARCH64_CALL26
against undefined symbol `led_classdev_unregister'
drivers/net/wireless/ath/ath9k/gpio.o: In function `ath_init_leds':
gpio.c:(.text+0x708): undefined reference to `led_classdev_register_ext'
gpio.c:(.text+0x708): relocation truncated to fit: R_AARCH64_CALL26
against undefined symbol `led_classdev_register_ext'

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zhang Jianhua <[email protected]>
---
drivers/net/wireless/ath/ath9k/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/ath/ath9k/Kconfig b/drivers/net/wireless/ath/ath9k/Kconfig
index e150d82eddb6..cba91e948c43 100644
--- a/drivers/net/wireless/ath/ath9k/Kconfig
+++ b/drivers/net/wireless/ath/ath9k/Kconfig
@@ -24,6 +24,7 @@ config ATH9K
select MAC80211_LEDS if LEDS_CLASS=y || LEDS_CLASS=MAC80211
select ATH9K_HW
select ATH9K_COMMON
+ select LEDS_CLASS
help
This module adds support for wireless adapters based on
Atheros IEEE 802.11n AR5008, AR9001 and AR9002 family
--
2.17.1


2021-03-27 22:39:53

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH -next] drivers: net: CONFIG_ATH9K select LEDS_CLASS

On Fri 2021-03-26 16:13:51, Zhang Jianhua wrote:
> If CONFIG_ATH9K=y, the following errors will be seen while compiling
> gpio.c
>
> drivers/net/wireless/ath/ath9k/gpio.o: In function `ath_deinit_leds':
> gpio.c:(.text+0x604): undefined reference to `led_classdev_unregister'
> gpio.c:(.text+0x604): relocation truncated to fit: R_AARCH64_CALL26
> against undefined symbol `led_classdev_unregister'
> drivers/net/wireless/ath/ath9k/gpio.o: In function `ath_init_leds':
> gpio.c:(.text+0x708): undefined reference to `led_classdev_register_ext'
> gpio.c:(.text+0x708): relocation truncated to fit: R_AARCH64_CALL26
> against undefined symbol `led_classdev_register_ext'
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zhang Jianhua <[email protected]>

a) please cc led lists with led issue.

b) probably does not work as LED_CLASS depends on NEW_LEDS...?

Best regards,
Pavel

--
http://www.livejournal.com/~pavelmachek


Attachments:
(No filename) (991.00 B)
signature.asc (201.00 B)
Download all attachments

2021-04-25 21:51:16

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH -next] drivers: net: CONFIG_ATH9K select LEDS_CLASS

Hi!

> hello Pavel,thanks for your reply.
>
> for  the a point, I don't know the led lists and cannot find it.
>
> for the b point, I look other configs who select LEDS_CLASS, almost all of
> them select NEW_LEDS,maybe you are right, CONFIG_ATH9K also need select
> NEW_LEDS too.

See MAINTAINERS file.
Pavel

--
http://www.livejournal.com/~pavelmachek


Attachments:
(No filename) (394.00 B)
signature.asc (188.00 B)
Digital signature
Download all attachments