2021-03-30 12:07:26

by Zhang Jianhua

Subject: [PATCH -next v2] drivers: net: CONFIG_ATH9K select LEDS_CLASS and NEW_LEDS

If CONFIG_ATH9K=y, the following errors will be seen while compiling
gpio.c

drivers/net/wireless/ath/ath9k/gpio.o: In function `ath_deinit_leds':
gpio.c:(.text+0x604): undefined reference to `led_classdev_unregister'
gpio.c:(.text+0x604): relocation truncated to fit: R_AARCH64_CALL26
against undefined symbol `led_classdev_unregister'
drivers/net/wireless/ath/ath9k/gpio.o: In function `ath_init_leds':
gpio.c:(.text+0x708): undefined reference to `led_classdev_register_ext'
gpio.c:(.text+0x708): relocation truncated to fit: R_AARCH64_CALL26
against undefined symbol `led_classdev_register_ext'

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zhang Jianhua <[email protected]>

---
v2:
add 'select NEW_LEDS'
---
drivers/net/wireless/ath/ath9k/Kconfig | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/ath/ath9k/Kconfig b/drivers/net/wireless/ath/ath9k/Kconfig
index e150d82eddb6..0a73ede3148a 100644
--- a/drivers/net/wireless/ath/ath9k/Kconfig
+++ b/drivers/net/wireless/ath/ath9k/Kconfig
@@ -24,6 +24,8 @@ config ATH9K
select MAC80211_LEDS if LEDS_CLASS=y || LEDS_CLASS=MAC80211
select ATH9K_HW
select ATH9K_COMMON
+ select NEW_LEDS
+ select LEDS_CLASS
help
This module adds support for wireless adapters based on
Atheros IEEE 802.11n AR5008, AR9001 and AR9002 family
--
2.17.1

2021-04-22 13:43:59

by Kalle Valo

Subject: Re: [PATCH -next v2] drivers: net: CONFIG_ATH9K select LEDS_CLASS and NEW_LEDS

Zhang Jianhua <[email protected]> wrote:

> If CONFIG_ATH9K=y, the following errors will be seen while compiling
> gpio.c
>
> drivers/net/wireless/ath/ath9k/gpio.o: In function `ath_deinit_leds':
> gpio.c:(.text+0x604): undefined reference to `led_classdev_unregister'
> gpio.c:(.text+0x604): relocation truncated to fit: R_AARCH64_CALL26
> against undefined symbol `led_classdev_unregister'
> drivers/net/wireless/ath/ath9k/gpio.o: In function `ath_init_leds':
> gpio.c:(.text+0x708): undefined reference to `led_classdev_register_ext'
> gpio.c:(.text+0x708): relocation truncated to fit: R_AARCH64_CALL26
> against undefined symbol `led_classdev_register_ext'
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zhang Jianhua <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Recently there was a related fix, I need more information about this problem.
What is exactly causing this? Is this a recent regression or an old problem?

Can someone review this?

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches