2021-04-15 10:48:36

by Shawn Guo

Subject: [PATCH v2 1/2] dt-bindings: bcm4329-fmac: add optional brcm,ccode-map

Add optional brcm,ccode-map property to support translation from ISO3166
country code to brcmfmac firmware country code and revision.

The country revision is needed because the RF parameters that provide
regulatory compliance are tweaked per platform/customer. So depending
on the RF path tight to the chip, certain country revision needs to be
specified. As such they could be seen as device specific calibration
data which is a good fit into device tree.

Signed-off-by: Shawn Guo <[email protected]>
Reviewed-by: Arend van Spriel <[email protected]>
---
.../bindings/net/wireless/brcm,bcm4329-fmac.yaml | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
index b5fcc73ce6be..c11f23b20c4c 100644
--- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
@@ -68,6 +68,13 @@ properties:
description: A GPIO line connected to the WL_RST line, if present
this shall be flagged as active low.

+ brcm,ccode-map:
+ $ref: /schemas/types.yaml#/definitions/string-array
+ description: Multiple strings for translating ISO3166 country code to
+ brcmfmac firmware country code and revision.
+ items:
+ pattern: '^[A-Z][A-Z]-[A-Z][0-9A-Z]-[0-9]+$'
+
required:
- compatible
- reg
@@ -97,5 +104,6 @@ examples:
interrupts = <24 IRQ_TYPE_EDGE_FALLING>;
interrupt-names = "host-wake";
reset-gpios = <&gpio 23 GPIO_ACTIVE_LOW>;
+ brcm,ccode-map = "JP-JP-78", "US-Q2-86";
};
};
--
2.17.1

2021-04-15 21:35:21

by Rob Herring

Subject: Re: [PATCH v2 1/2] dt-bindings: bcm4329-fmac: add optional brcm,ccode-map

On Thu, 15 Apr 2021 18:47:27 +0800, Shawn Guo wrote:
> Add optional brcm,ccode-map property to support translation from ISO3166
> country code to brcmfmac firmware country code and revision.
>
> The country revision is needed because the RF parameters that provide
> regulatory compliance are tweaked per platform/customer. So depending
> on the RF path tight to the chip, certain country revision needs to be
> specified. As such they could be seen as device specific calibration
> data which is a good fit into device tree.
>
> Signed-off-by: Shawn Guo <[email protected]>
> Reviewed-by: Arend van Spriel <[email protected]>
> ---
> .../bindings/net/wireless/brcm,bcm4329-fmac.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>

Applied, thanks!