2021-05-07 21:33:34

by Marek Vasut

Subject: [PATCH] rsi: Assign beacon rate settings to the correct rate_info descriptor field

The RSI_RATE_x bits must be assigned to struct rsi_data_desc rate_info
field. The rest of the driver does it correctly, except this one place,
so fix it. This is also aligned with the RSI downstream vendor driver.
Without this patch, an AP operating at 5 GHz does not transmit any
beacons at all, this patch fixes that.

Fixes: d26a9559403c ("rsi: add beacon changes for AP mode")
Signed-off-by: Marek Vasut <[email protected]>
Cc: Amitkumar Karwar <[email protected]>
Cc: Angus Ainslie <[email protected]>
Cc: David S. Miller <[email protected]>
Cc: Jakub Kicinski <[email protected]>
Cc: Kalle Valo <[email protected]>
Cc: Karun Eagalapati <[email protected]>
Cc: Martin Kepplinger <[email protected]>
Cc: Prameela Rani Garnepudi <[email protected]>
Cc: Sebastian Krzyszkowiak <[email protected]>
Cc: Siva Rebbagondla <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
drivers/net/wireless/rsi/rsi_91x_hal.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/rsi/rsi_91x_hal.c b/drivers/net/wireless/rsi/rsi_91x_hal.c
index ce9892152f4d..ab837921d9a4 100644
--- a/drivers/net/wireless/rsi/rsi_91x_hal.c
+++ b/drivers/net/wireless/rsi/rsi_91x_hal.c
@@ -470,9 +470,9 @@ int rsi_prepare_beacon(struct rsi_common *common, struct sk_buff *skb)
}

if (common->band == NL80211_BAND_2GHZ)
- bcn_frm->bbp_info |= cpu_to_le16(RSI_RATE_1);
+ bcn_frm->rate_info |= cpu_to_le16(RSI_RATE_1);
else
- bcn_frm->bbp_info |= cpu_to_le16(RSI_RATE_6);
+ bcn_frm->rate_info |= cpu_to_le16(RSI_RATE_6);

if (mac_bcn->data[tim_offset + 2] == 0)
bcn_frm->frame_info |= cpu_to_le16(RSI_DATA_DESC_DTIM_BEACON);
--
2.30.2

2021-06-15 13:39:28

by Kalle Valo

Subject: Re: [PATCH] rsi: Assign beacon rate settings to the correct rate_info descriptor field

Marek Vasut <[email protected]> wrote:

> The RSI_RATE_x bits must be assigned to struct rsi_data_desc rate_info
> field. The rest of the driver does it correctly, except this one place,
> so fix it. This is also aligned with the RSI downstream vendor driver.
> Without this patch, an AP operating at 5 GHz does not transmit any
> beacons at all, this patch fixes that.
>
> Fixes: d26a9559403c ("rsi: add beacon changes for AP mode")
> Signed-off-by: Marek Vasut <[email protected]>
> Cc: Amitkumar Karwar <[email protected]>
> Cc: Angus Ainslie <[email protected]>
> Cc: David S. Miller <[email protected]>
> Cc: Jakub Kicinski <[email protected]>
> Cc: Kalle Valo <[email protected]>
> Cc: Karun Eagalapati <[email protected]>
> Cc: Martin Kepplinger <[email protected]>
> Cc: Prameela Rani Garnepudi <[email protected]>
> Cc: Sebastian Krzyszkowiak <[email protected]>
> Cc: Siva Rebbagondla <[email protected]>
> Cc: [email protected]
> Cc: [email protected]

Patch applied to wireless-drivers-next.git, thanks.

b1c3a24897bd rsi: Assign beacon rate settings to the correct rate_info descriptor field

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches