2021-07-19 12:22:41

by Yajun Deng

[permalink] [raw]
Subject: [PATCH 0/4] Remove rtnetlink_send() in rtnetlink

rtnetlink_send() is similar to rtnl_notify(), there is no need for two
functions to do the same thing. we can remove rtnetlink_send() and
modify rtnl_notify() to adapt more case.

Patch1: remove rtnetlink_send() modify rtnl_notify() to adapt
more case in rtnetlink.
Path2,Patch3: Adjustment parameters in rtnl_notify().
Path4: rtnetlink_send() already removed, use rtnl_notify() instead
of rtnetlink_send().

Yajun Deng (4):
rtnetlink: remove rtnetlink_send() in rtnetlink
net: Adjustment parameters in rtnl_notify()
vxlan: Adjustment parameters in rtnl_notify()
net/sched: use rtnl_notify() instead of rtnetlink_send()

drivers/net/vxlan.c | 2 +-
include/linux/rtnetlink.h | 7 +++----
include/net/netlink.h | 5 ++---
net/bridge/br_fdb.c | 2 +-
net/bridge/br_mdb.c | 4 ++--
net/bridge/br_netlink.c | 2 +-
net/bridge/br_vlan.c | 2 +-
net/core/fib_rules.c | 2 +-
net/core/neighbour.c | 2 +-
net/core/net_namespace.c | 2 +-
net/core/rtnetlink.c | 27 ++++++++-------------------
net/dcb/dcbnl.c | 2 +-
net/decnet/dn_dev.c | 2 +-
net/decnet/dn_table.c | 2 +-
net/ipv4/devinet.c | 4 ++--
net/ipv4/fib_semantics.c | 2 +-
net/ipv4/fib_trie.c | 2 +-
net/ipv4/ipmr.c | 4 ++--
net/ipv4/nexthop.c | 4 ++--
net/ipv6/addrconf.c | 8 ++++----
net/ipv6/ip6mr.c | 4 ++--
net/ipv6/ndisc.c | 2 +-
net/ipv6/route.c | 9 +++++----
net/mpls/af_mpls.c | 4 ++--
net/phonet/pn_netlink.c | 4 ++--
net/sched/act_api.c | 13 ++++++-------
net/sched/cls_api.c | 14 +++++++-------
net/sched/sch_api.c | 13 ++++++-------
net/wireless/wext-core.c | 2 +-
29 files changed, 69 insertions(+), 83 deletions(-)

--
2.32.0


2021-07-20 10:47:19

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH 0/4] Remove rtnetlink_send() in rtnetlink

On Mon, 19 Jul 2021 20:21:54 +0800, Yajun Deng wrote:
> rtnetlink_send() is similar to rtnl_notify(), there is no need for two
> functions to do the same thing. we can remove rtnetlink_send() and
> modify rtnl_notify() to adapt more case.
>
> Patch1: remove rtnetlink_send() modify rtnl_notify() to adapt
> more case in rtnetlink.
> Path2,Patch3: Adjustment parameters in rtnl_notify().
> Path4: rtnetlink_send() already removed, use rtnl_notify() instead
> of rtnetlink_send().

You can't break compilation in between patches. Each step of the series
(each patch) must be self-contained, build, and work correctly.
Otherwise bisection becomes a nightmare.

Please also post series as a thread (patches in reply to the cover
letter), it seems that patchwork did not group the patches correctly
here.