2022-01-09 23:09:57

by Colin Ian King

Subject: [PATCH] cw1200: wsm: make array queue_id_to_wmm_aci static const

Don't populate the read-only array queue_id_to_wmm_aci on the stack
but instead make it static. Also makes the object code a little smaller.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/wireless/st/cw1200/wsm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/st/cw1200/wsm.c b/drivers/net/wireless/st/cw1200/wsm.c
index 99624dd34886..5a3e7a626702 100644
--- a/drivers/net/wireless/st/cw1200/wsm.c
+++ b/drivers/net/wireless/st/cw1200/wsm.c
@@ -537,7 +537,7 @@ int wsm_set_tx_queue_params(struct cw1200_common *priv,
{
int ret;
struct wsm_buf *buf = &priv->wsm_cmd_buf;
- u8 queue_id_to_wmm_aci[] = {3, 2, 0, 1};
+ static const u8 queue_id_to_wmm_aci[] = { 3, 2, 0, 1 };

wsm_cmd_lock(priv);

--
2.32.0

2022-02-01 20:42:50

by Kalle Valo

Subject: Re: [PATCH] cw1200: wsm: make array queue_id_to_wmm_aci static const

Colin Ian King <[email protected]> wrote:

> Don't populate the read-only array queue_id_to_wmm_aci on the stack
> but instead make it static. Also makes the object code a little smaller.
>
> Signed-off-by: Colin Ian King <[email protected]>

Patch applied to wireless-next.git, thanks.

fe683faecc7a cw1200: wsm: make array queue_id_to_wmm_aci static const

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches