These paches try to enhance the support of the various delays by adding
into the core the necessary logic to derive the actual symbol duration
(and then the lifs/sifs durations) depending on the protocol used.
Miquel Raynal (5):
net: ieee802154: Improve the way supported channels are declared
net: ieee802154: Give more details to the core about the channel
configurations
net: mac802154: Convert the symbol duration into nanoseconds
net: mac802154: Set the symbol duration automatically
net: ieee802154: Drop duration settings when the core does it already
drivers/net/ieee802154/adf7242.c | 3 +-
drivers/net/ieee802154/at86rf230.c | 66 ++++++-------
drivers/net/ieee802154/atusb.c | 66 ++++++-------
drivers/net/ieee802154/ca8210.c | 7 +-
drivers/net/ieee802154/cc2520.c | 3 +-
drivers/net/ieee802154/fakelb.c | 43 ++++++---
drivers/net/ieee802154/mac802154_hwsim.c | 76 ++++++++++++---
drivers/net/ieee802154/mcr20a.c | 11 +--
drivers/net/ieee802154/mrf24j40.c | 3 +-
include/net/cfg802154.h | 60 +++++++++++-
net/ieee802154/core.h | 2 +
net/ieee802154/nl-phy.c | 8 +-
net/ieee802154/nl802154.c | 30 ++++--
net/mac802154/cfg.c | 1 +
net/mac802154/main.c | 113 ++++++++++++++++++++++-
15 files changed, 361 insertions(+), 131 deletions(-)
--
2.27.0
In order to let the core derive eg. the symbol duration for a given
channel, it needs to know which protocol is being used, on which band,
and eventually more details such as the mean PRF in the case of UWB.
Create the necessary enumerations to declare all of that. Include them
in the currently-almost-empty phy_channels structure which until now
only declared the supported channels as bitfields.
The PRF is declared in a union as this clearly is a parameter that does
not apply to most of the protocols. It is very likely that other
parameters will get added in the future to further define specific
protocols and the union will likely be a good location for them.
Signed-off-by: Miquel Raynal <[email protected]>
---
drivers/net/ieee802154/at86rf230.c | 29 ++++++++++++++---
drivers/net/ieee802154/atusb.c | 29 ++++++++++++++---
drivers/net/ieee802154/ca8210.c | 3 ++
drivers/net/ieee802154/mac802154_hwsim.c | 33 +++++++++++++++++++
drivers/net/ieee802154/mcr20a.c | 3 ++
include/net/cfg802154.h | 41 ++++++++++++++++++++++++
6 files changed, 130 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c
index 144553f156dd..84e5dcd9df09 100644
--- a/drivers/net/ieee802154/at86rf230.c
+++ b/drivers/net/ieee802154/at86rf230.c
@@ -1561,6 +1561,8 @@ at86rf230_detect_device(struct at86rf230_local *lp)
lp->data = &at86rf231_data;
lp->hw->phy->supported.page[0].nchunks = 1;
lp->hw->phy->supported.page[0].chunk[0].channels = 0x7FFF800;
+ lp->hw->phy->supported.page[0].chunk[0].protocol = IEEE802154_OQPSK_PHY;
+ lp->hw->phy->supported.page[0].chunk[0].band = IEEE802154_2400_MHZ_BAND;
lp->hw->phy->current_channel = 11;
lp->hw->phy->symbol_duration = 16;
lp->hw->phy->supported.tx_powers = at86rf231_powers;
@@ -1572,10 +1574,27 @@ at86rf230_detect_device(struct at86rf230_local *lp)
chip = "at86rf212";
lp->data = &at86rf212_data;
lp->hw->flags |= IEEE802154_HW_LBT;
- lp->hw->phy->supported.page[0].nchunks = 1;
- lp->hw->phy->supported.page[0].chunk[0].channels = 0x00007FF;
- lp->hw->phy->supported.page[2].nchunks = 1;
- lp->hw->phy->supported.page[2].chunk[0].channels = 0x00007FF;
+
+ lp->hw->phy->supported.page[0].nchunks = 2;
+ /* SUB:0 and BPSK:0 -> BPSK-20 */
+ lp->hw->phy->supported.page[0].chunk[0].channels = 1;
+ lp->hw->phy->supported.page[0].chunk[0].protocol = IEEE802154_BPSK_PHY;
+ lp->hw->phy->supported.page[0].chunk[0].band = IEEE802154_868_MHZ_BAND;
+ /* SUB:0 and BPSK:1 -> OQPSK-100/200/400 */
+ lp->hw->phy->supported.page[0].chunk[1].channels = 0x00007FE;
+ lp->hw->phy->supported.page[0].chunk[1].protocol = IEEE802154_OQPSK_PHY;
+ lp->hw->phy->supported.page[0].chunk[1].band = IEEE802154_868_MHZ_BAND;
+
+ lp->hw->phy->supported.page[2].nchunks = 2;
+ /* SUB:1 and BPSK:0 -> BPSK-40 */
+ lp->hw->phy->supported.page[2].chunk[0].channels = 1;
+ lp->hw->phy->supported.page[2].chunk[0].protocol = IEEE802154_BPSK_PHY;
+ lp->hw->phy->supported.page[2].chunk[0].band = IEEE802154_915_MHZ_BAND;
+ /* SUB:1 and BPSK:1 -> OQPSK-250/500/1000 */
+ lp->hw->phy->supported.page[2].chunk[1].channels = 0x00007FE;
+ lp->hw->phy->supported.page[2].chunk[1].protocol = IEEE802154_OQPSK_PHY;
+ lp->hw->phy->supported.page[2].chunk[1].band = IEEE802154_915_MHZ_BAND;
+
lp->hw->phy->current_channel = 5;
lp->hw->phy->symbol_duration = 25;
lp->hw->phy->supported.lbt = NL802154_SUPPORTED_BOOL_BOTH;
@@ -1589,6 +1608,8 @@ at86rf230_detect_device(struct at86rf230_local *lp)
lp->data = &at86rf233_data;
lp->hw->phy->supported.page[0].nchunks = 1;
lp->hw->phy->supported.page[0].chunk[0].channels = 0x7FFF800;
+ lp->hw->phy->supported.page[0].chunk[0].protocol = IEEE802154_OQPSK_PHY;
+ lp->hw->phy->supported.page[0].chunk[0].band = IEEE802154_2400_MHZ_BAND;
lp->hw->phy->current_channel = 13;
lp->hw->phy->symbol_duration = 16;
lp->hw->phy->supported.tx_powers = at86rf233_powers;
diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c
index 38ebfacf2698..7e8c9d6db7d7 100644
--- a/drivers/net/ieee802154/atusb.c
+++ b/drivers/net/ieee802154/atusb.c
@@ -916,6 +916,8 @@ static int atusb_get_and_conf_chip(struct atusb *atusb)
chip = "AT86RF230";
atusb->hw->phy->supported.page[0].nchunks = 1;
atusb->hw->phy->supported.page[0].chunk[0].channels = 0x7FFF800;
+ atusb->hw->phy->supported.page[0].chunk[0].protocol = IEEE802154_OQPSK_PHY;
+ atusb->hw->phy->supported.page[0].chunk[0].band = IEEE802154_2400_MHZ_BAND;
atusb->hw->phy->current_channel = 11; /* reset default */
atusb->hw->phy->symbol_duration = 16;
atusb->hw->phy->supported.tx_powers = atusb_powers;
@@ -927,6 +929,8 @@ static int atusb_get_and_conf_chip(struct atusb *atusb)
chip = "AT86RF231";
atusb->hw->phy->supported.page[0].nchunks = 1;
atusb->hw->phy->supported.page[0].chunk[0].channels = 0x7FFF800;
+ atusb->hw->phy->supported.page[0].chunk[0].protocol = IEEE802154_OQPSK_PHY;
+ atusb->hw->phy->supported.page[0].chunk[0].band = IEEE802154_2400_MHZ_BAND;
atusb->hw->phy->current_channel = 11; /* reset default */
atusb->hw->phy->symbol_duration = 16;
atusb->hw->phy->supported.tx_powers = atusb_powers;
@@ -937,10 +941,27 @@ static int atusb_get_and_conf_chip(struct atusb *atusb)
case 7:
chip = "AT86RF212";
atusb->hw->flags |= IEEE802154_HW_LBT;
- atusb->hw->phy->supported.page[0].nchunks = 1;
- atusb->hw->phy->supported.page[0].chunk[0].channels = 0x00007FF;
- atusb->hw->phy->supported.page[2].nchunks = 1;
- atusb->hw->phy->supported.page[2].chunk[0].channels = 0x00007FF;
+
+ atusb->hw->phy->supported.page[0].nchunks = 2;
+ /* SUB:0 and BPSK:0 -> BPSK-20 */
+ atusb->hw->phy->supported.page[0].chunk[0].channels = 1;
+ atusb->hw->phy->supported.page[0].chunk[0].protocol = IEEE802154_BPSK_PHY;
+ atusb->hw->phy->supported.page[0].chunk[0].band = IEEE802154_868_MHZ_BAND;
+ /* SUB:0 and BPSK:1 -> OQPSK-100/200/400 */
+ atusb->hw->phy->supported.page[0].chunk[1].channels = 0x00007FE;
+ atusb->hw->phy->supported.page[0].chunk[1].protocol = IEEE802154_OQPSK_PHY;
+ atusb->hw->phy->supported.page[0].chunk[1].band = IEEE802154_868_MHZ_BAND;
+
+ atusb->hw->phy->supported.page[2].nchunks = 2;
+ /* SUB:1 and BPSK:0 -> BPSK-40 */
+ atusb->hw->phy->supported.page[2].chunk[0].channels = 1;
+ atusb->hw->phy->supported.page[2].chunk[0].protocol = IEEE802154_BPSK_PHY;
+ atusb->hw->phy->supported.page[2].chunk[0].band = IEEE802154_915_MHZ_BAND;
+ /* SUB:1 and BPSK:1 -> OQPSK-250/500/1000 */
+ atusb->hw->phy->supported.page[2].chunk[1].channels = 0x00007FE;
+ atusb->hw->phy->supported.page[2].chunk[1].protocol = IEEE802154_OQPSK_PHY;
+ atusb->hw->phy->supported.page[2].chunk[1].band = IEEE802154_915_MHZ_BAND;
+
atusb->hw->phy->current_channel = 5;
atusb->hw->phy->symbol_duration = 25;
atusb->hw->phy->supported.lbt = NL802154_SUPPORTED_BOOL_BOTH;
diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
index cf31655fe714..6854ec7747c0 100644
--- a/drivers/net/ieee802154/ca8210.c
+++ b/drivers/net/ieee802154/ca8210.c
@@ -2964,7 +2964,10 @@ static void ca8210_hw_setup(struct ieee802154_hw *ca8210_hw)
{
/* Support channels 11-26 */
ca8210_hw->phy->supported.page[0].nchunks = 1;
+ /* 2.4 GHz O-QPSK */
ca8210_hw->phy->supported.page[0].chunk[0].channels = CA8210_VALID_CHANNELS;
+ ca8210_hw->phy->supported.page[0].chunk[0].protocol = IEEE802154_OQPSK_PHY;
+ ca8210_hw->phy->supported.page[0].chunk[0].band = IEEE802154_2400_MHZ_BAND;
ca8210_hw->phy->supported.tx_powers_size = CA8210_MAX_TX_POWERS;
ca8210_hw->phy->supported.tx_powers = ca8210_tx_powers;
ca8210_hw->phy->supported.cca_ed_levels_size = CA8210_MAX_ED_LEVELS;
diff --git a/drivers/net/ieee802154/mac802154_hwsim.c b/drivers/net/ieee802154/mac802154_hwsim.c
index 76fa532d8891..583fcdf7d267 100644
--- a/drivers/net/ieee802154/mac802154_hwsim.c
+++ b/drivers/net/ieee802154/mac802154_hwsim.c
@@ -747,46 +747,79 @@ static int hwsim_add_one(struct genl_info *info, struct device *dev,
hw->phy->supported.page[0].nchunks = 3;
/* 868 MHz BPSK 802.15.4-2003 */
hw->phy->supported.page[0].chunk[0].channels |= 1;
+ hw->phy->supported.page[0].chunk[0].protocol = IEEE802154_BPSK_PHY;
+ hw->phy->supported.page[0].chunk[0].band = IEEE802154_868_MHZ_BAND;
/* 915 MHz BPSK 802.15.4-2003 */
hw->phy->supported.page[0].chunk[1].channels |= 0x7fe;
+ hw->phy->supported.page[0].chunk[1].protocol = IEEE802154_BPSK_PHY;
+ hw->phy->supported.page[0].chunk[1].band = IEEE802154_915_MHZ_BAND;
/* 2.4 GHz O-QPSK 802.15.4-2003 */
hw->phy->supported.page[0].chunk[2].channels |= 0x7FFF800;
+ hw->phy->supported.page[0].chunk[2].protocol = IEEE802154_OQPSK_PHY;
+ hw->phy->supported.page[0].chunk[2].band = IEEE802154_2400_MHZ_BAND;
hw->phy->supported.page[1].nchunks = 2;
/* 868 MHz ASK 802.15.4-2006 */
hw->phy->supported.page[1].chunk[0].channels |= 1;
+ hw->phy->supported.page[1].chunk[0].protocol = IEEE802154_ASK_PHY;
+ hw->phy->supported.page[1].chunk[0].band = IEEE802154_868_MHZ_BAND;
/* 915 MHz ASK 802.15.4-2006 */
hw->phy->supported.page[1].chunk[1].channels |= 0x7fe;
+ hw->phy->supported.page[1].chunk[1].protocol = IEEE802154_ASK_PHY;
+ hw->phy->supported.page[1].chunk[1].band = IEEE802154_915_MHZ_BAND;
hw->phy->supported.page[2].nchunks = 2;
/* 868 MHz O-QPSK 802.15.4-2006 */
hw->phy->supported.page[2].chunk[0].channels |= 1;
+ hw->phy->supported.page[2].chunk[0].protocol = IEEE802154_OQPSK_PHY;
+ hw->phy->supported.page[2].chunk[0].band = IEEE802154_868_MHZ_BAND;
/* 915 MHz O-QPSK 802.15.4-2006 */
hw->phy->supported.page[2].chunk[1].channels |= 0x7fe;
+ hw->phy->supported.page[2].chunk[1].protocol = IEEE802154_OQPSK_PHY;
+ hw->phy->supported.page[2].chunk[1].band = IEEE802154_915_MHZ_BAND;
hw->phy->supported.page[3].nchunks = 1;
/* 2.4 GHz CSS 802.15.4a-2007 */
hw->phy->supported.page[3].chunk[0].channels |= 0x3fff;
+ hw->phy->supported.page[3].chunk[0].protocol = IEEE802154_CSS_PHY;
+ hw->phy->supported.page[3].chunk[0].band = IEEE802154_2400_MHZ_BAND;
hw->phy->supported.page[4].nchunks = 3;
/* UWB Sub-gigahertz 802.15.4a-2007 */
hw->phy->supported.page[4].chunk[0].channels |= 1;
+ hw->phy->supported.page[4].chunk[0].protocol = IEEE802154_HRP_UWB_PHY;
+ hw->phy->supported.page[4].chunk[0].band = IEEE802154_250_750_MHZ_BAND;
+ hw->phy->supported.page[4].chunk[0].prf = IEEE802154_62890KHZ_MEAN_PRF;
/* UWB Low band 802.15.4a-2007 */
hw->phy->supported.page[4].chunk[1].channels |= 0x1e;
+ hw->phy->supported.page[4].chunk[1].protocol = IEEE802154_HRP_UWB_PHY;
+ hw->phy->supported.page[4].chunk[1].band = IEEE802154_3100_4800_MHZ_BAND;
+ hw->phy->supported.page[4].chunk[1].prf = IEEE802154_62890KHZ_MEAN_PRF;
/* UWB High band 802.15.4a-2007 */
hw->phy->supported.page[4].chunk[2].channels |= 0xffe0;
+ hw->phy->supported.page[4].chunk[2].protocol = IEEE802154_HRP_UWB_PHY;
+ hw->phy->supported.page[4].chunk[2].band = IEEE802154_6000_10600_MHZ_BAND;
+ hw->phy->supported.page[4].chunk[2].prf = IEEE802154_62890KHZ_MEAN_PRF;
hw->phy->supported.page[5].nchunks = 2;
/* 750 MHz O-QPSK 802.15.4c-2009 */
hw->phy->supported.page[5].chunk[0].channels |= 0xf;
+ hw->phy->supported.page[5].chunk[0].protocol = IEEE802154_OQPSK_PHY;
+ hw->phy->supported.page[5].chunk[0].band = IEEE802154_750_MHZ_BAND;
/* 750 MHz MPSK 802.15.4c-2009 */
hw->phy->supported.page[5].chunk[1].channels |= 0xf0;
+ hw->phy->supported.page[5].chunk[1].protocol = IEEE802154_MQPSK_PHY;
+ hw->phy->supported.page[5].chunk[1].band = IEEE802154_750_MHZ_BAND;
hw->phy->supported.page[6].nchunks = 2;
/* 950 MHz BPSK 802.15.4d-2009 */
hw->phy->supported.page[6].chunk[0].channels |= 0x3ff;
+ hw->phy->supported.page[6].chunk[0].protocol = IEEE802154_BPSK_PHY;
+ hw->phy->supported.page[6].chunk[0].band = IEEE802154_950_MHZ_BAND;
/* 950 MHz GFSK 802.15.4d-2009 */
hw->phy->supported.page[6].chunk[1].channels |= 0x3ffc00;
+ hw->phy->supported.page[6].chunk[1].protocol = IEEE802154_GFSK_PHY;
+ hw->phy->supported.page[6].chunk[1].band = IEEE802154_950_MHZ_BAND;
ieee802154_random_extended_addr(&hw->phy->perm_extended_addr);
diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c
index 80bed905acf9..e2c249aef430 100644
--- a/drivers/net/ieee802154/mcr20a.c
+++ b/drivers/net/ieee802154/mcr20a.c
@@ -1003,7 +1003,10 @@ static void mcr20a_hw_setup(struct mcr20a_local *lp)
phy->cca.mode = NL802154_CCA_ENERGY;
phy->supported.page[0].nchunks = 1;
+ /* 2.4 GHz O-QPSK */
phy->supported.page[0].chunk[0].channels = MCR20A_VALID_CHANNELS;
+ phy->supported.page[0].chunk[0].protocol = IEEE802154_OQPSK_PHY;
+ phy->supported.page[0].chunk[0].band = IEEE802154_2400_MHZ_BAND;
phy->current_page = 0;
/* MCR20A default reset value */
phy->current_channel = 20;
diff --git a/include/net/cfg802154.h b/include/net/cfg802154.h
index ef49a23801c6..03c8008217fb 100644
--- a/include/net/cfg802154.h
+++ b/include/net/cfg802154.h
@@ -131,8 +131,49 @@ wpan_phy_supported_bool(bool b, enum nl802154_supported_bool_states st)
return false;
}
+enum ieee802154_phy_protocols {
+ IEEE802154_UNKNOWN_PHY,
+ IEEE802154_BPSK_PHY,
+ IEEE802154_OQPSK_PHY,
+ IEEE802154_MQPSK_PHY,
+ IEEE802154_GFSK_PHY,
+ IEEE802154_ASK_PHY,
+ IEEE802154_CSS_PHY,
+ IEEE802154_HRP_UWB_PHY,
+
+ IEEE802154_MAX_PHY,
+};
+
+enum ieee802154_phy_bands {
+ IEEE802154_UNKNOWN_BAND,
+ IEEE802154_750_MHZ_BAND,
+ IEEE802154_868_MHZ_BAND,
+ IEEE802154_915_MHZ_BAND,
+ IEEE802154_950_MHZ_BAND,
+ IEEE802154_2400_MHZ_BAND,
+ IEEE802154_250_750_MHZ_BAND,
+ IEEE802154_3100_4800_MHZ_BAND,
+ IEEE802154_6000_10600_MHZ_BAND,
+
+ IEEE802154_MAX_BAND,
+};
+
+enum ieee802154_phy_mean_prfs {
+ IEEE802154_UNKNOWN_MEAN_PRF,
+ IEEE802154_16100KHZ_MEAN_PRF,
+ IEEE802154_4030KHZ_MEAN_PRF,
+ IEEE802154_62890KHZ_MEAN_PRF,
+
+ IEEE802154_MAX_PRF,
+};
+
struct phy_channels {
u32 channels;
+ enum ieee802154_phy_protocols protocol;
+ enum ieee802154_phy_bands band;
+ union {
+ enum ieee802154_phy_mean_prfs prf;
+ };
};
struct phy_page {
--
2.27.0
Tdsym is often given in the spec as pretty small numbers in microseconds
and hence was reflected in the code as symbol_duration and was stored as
a u8. Actually, for UWB PHYs, the symbol duration is given in
nanoseconds and are as precise as picoseconds. In order to handle better
these PHYs, change the type of symbol_duration to u32 and store this
value in nanoseconds.
All the users of this variable are updated in a mechanical change.
Signed-off-by: Miquel Raynal <[email protected]>
---
drivers/net/ieee802154/at86rf230.c | 22 +++++++++++-----------
drivers/net/ieee802154/atusb.c | 22 +++++++++++-----------
drivers/net/ieee802154/ca8210.c | 2 +-
drivers/net/ieee802154/mcr20a.c | 8 ++++----
include/net/cfg802154.h | 4 ++--
net/mac802154/main.c | 8 ++++----
6 files changed, 33 insertions(+), 33 deletions(-)
diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c
index 84e5dcd9df09..653931b20ab4 100644
--- a/drivers/net/ieee802154/at86rf230.c
+++ b/drivers/net/ieee802154/at86rf230.c
@@ -1067,24 +1067,24 @@ at86rf212_set_channel(struct at86rf230_local *lp, u8 page, u8 channel)
if (channel == 0) {
if (page == 0) {
/* SUB:0 and BPSK:0 -> BPSK-20 */
- lp->hw->phy->symbol_duration = 50;
+ lp->hw->phy->symbol_duration = 50 * NSEC_PER_USEC;
} else {
/* SUB:1 and BPSK:0 -> BPSK-40 */
- lp->hw->phy->symbol_duration = 25;
+ lp->hw->phy->symbol_duration = 25 * NSEC_PER_USEC;
}
} else {
if (page == 0)
/* SUB:0 and BPSK:1 -> OQPSK-100/200/400 */
- lp->hw->phy->symbol_duration = 40;
+ lp->hw->phy->symbol_duration = 40 * NSEC_PER_USEC;
else
/* SUB:1 and BPSK:1 -> OQPSK-250/500/1000 */
- lp->hw->phy->symbol_duration = 16;
+ lp->hw->phy->symbol_duration = 16 * NSEC_PER_USEC;
}
- lp->hw->phy->lifs_period = IEEE802154_LIFS_PERIOD *
- lp->hw->phy->symbol_duration;
- lp->hw->phy->sifs_period = IEEE802154_SIFS_PERIOD *
- lp->hw->phy->symbol_duration;
+ lp->hw->phy->lifs_period =
+ (IEEE802154_LIFS_PERIOD * lp->hw->phy->symbol_duration) / 1000;
+ lp->hw->phy->sifs_period =
+ (IEEE802154_SIFS_PERIOD * lp->hw->phy->symbol_duration) / 1000;
return at86rf230_write_subreg(lp, SR_CHANNEL, channel);
}
@@ -1564,7 +1564,7 @@ at86rf230_detect_device(struct at86rf230_local *lp)
lp->hw->phy->supported.page[0].chunk[0].protocol = IEEE802154_OQPSK_PHY;
lp->hw->phy->supported.page[0].chunk[0].band = IEEE802154_2400_MHZ_BAND;
lp->hw->phy->current_channel = 11;
- lp->hw->phy->symbol_duration = 16;
+ lp->hw->phy->symbol_duration = 16 * NSEC_PER_USEC;
lp->hw->phy->supported.tx_powers = at86rf231_powers;
lp->hw->phy->supported.tx_powers_size = ARRAY_SIZE(at86rf231_powers);
lp->hw->phy->supported.cca_ed_levels = at86rf231_ed_levels;
@@ -1596,7 +1596,7 @@ at86rf230_detect_device(struct at86rf230_local *lp)
lp->hw->phy->supported.page[2].chunk[1].band = IEEE802154_915_MHZ_BAND;
lp->hw->phy->current_channel = 5;
- lp->hw->phy->symbol_duration = 25;
+ lp->hw->phy->symbol_duration = 25 * NSEC_PER_USEC;
lp->hw->phy->supported.lbt = NL802154_SUPPORTED_BOOL_BOTH;
lp->hw->phy->supported.tx_powers = at86rf212_powers;
lp->hw->phy->supported.tx_powers_size = ARRAY_SIZE(at86rf212_powers);
@@ -1611,7 +1611,7 @@ at86rf230_detect_device(struct at86rf230_local *lp)
lp->hw->phy->supported.page[0].chunk[0].protocol = IEEE802154_OQPSK_PHY;
lp->hw->phy->supported.page[0].chunk[0].band = IEEE802154_2400_MHZ_BAND;
lp->hw->phy->current_channel = 13;
- lp->hw->phy->symbol_duration = 16;
+ lp->hw->phy->symbol_duration = 16 * NSEC_PER_USEC;
lp->hw->phy->supported.tx_powers = at86rf233_powers;
lp->hw->phy->supported.tx_powers_size = ARRAY_SIZE(at86rf233_powers);
lp->hw->phy->supported.cca_ed_levels = at86rf233_ed_levels;
diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c
index 7e8c9d6db7d7..80382919520e 100644
--- a/drivers/net/ieee802154/atusb.c
+++ b/drivers/net/ieee802154/atusb.c
@@ -678,24 +678,24 @@ static int hulusb_set_channel(struct ieee802154_hw *hw, u8 page, u8 channel)
if (channel == 0) {
if (page == 0) {
/* SUB:0 and BPSK:0 -> BPSK-20 */
- lp->hw->phy->symbol_duration = 50;
+ lp->hw->phy->symbol_duration = 50 * NSEC_PER_USEC;
} else {
/* SUB:1 and BPSK:0 -> BPSK-40 */
- lp->hw->phy->symbol_duration = 25;
+ lp->hw->phy->symbol_duration = 25 * NSEC_PER_USEC;
}
} else {
if (page == 0)
/* SUB:0 and BPSK:1 -> OQPSK-100/200/400 */
- lp->hw->phy->symbol_duration = 40;
+ lp->hw->phy->symbol_duration = 40 * NSEC_PER_USEC;
else
/* SUB:1 and BPSK:1 -> OQPSK-250/500/1000 */
- lp->hw->phy->symbol_duration = 16;
+ lp->hw->phy->symbol_duration = 16 * NSEC_PER_USEC;
}
- lp->hw->phy->lifs_period = IEEE802154_LIFS_PERIOD *
- lp->hw->phy->symbol_duration;
- lp->hw->phy->sifs_period = IEEE802154_SIFS_PERIOD *
- lp->hw->phy->symbol_duration;
+ lp->hw->phy->lifs_period =
+ (IEEE802154_LIFS_PERIOD * lp->hw->phy->symbol_duration) / 1000;
+ lp->hw->phy->sifs_period =
+ (IEEE802154_SIFS_PERIOD * lp->hw->phy->symbol_duration) / 1000;
return atusb_write_subreg(lp, SR_CHANNEL, channel);
}
@@ -919,7 +919,7 @@ static int atusb_get_and_conf_chip(struct atusb *atusb)
atusb->hw->phy->supported.page[0].chunk[0].protocol = IEEE802154_OQPSK_PHY;
atusb->hw->phy->supported.page[0].chunk[0].band = IEEE802154_2400_MHZ_BAND;
atusb->hw->phy->current_channel = 11; /* reset default */
- atusb->hw->phy->symbol_duration = 16;
+ atusb->hw->phy->symbol_duration = 16 * NSEC_PER_USEC;
atusb->hw->phy->supported.tx_powers = atusb_powers;
atusb->hw->phy->supported.tx_powers_size = ARRAY_SIZE(atusb_powers);
hw->phy->supported.cca_ed_levels = atusb_ed_levels;
@@ -932,7 +932,7 @@ static int atusb_get_and_conf_chip(struct atusb *atusb)
atusb->hw->phy->supported.page[0].chunk[0].protocol = IEEE802154_OQPSK_PHY;
atusb->hw->phy->supported.page[0].chunk[0].band = IEEE802154_2400_MHZ_BAND;
atusb->hw->phy->current_channel = 11; /* reset default */
- atusb->hw->phy->symbol_duration = 16;
+ atusb->hw->phy->symbol_duration = 16 * NSEC_PER_USEC;
atusb->hw->phy->supported.tx_powers = atusb_powers;
atusb->hw->phy->supported.tx_powers_size = ARRAY_SIZE(atusb_powers);
hw->phy->supported.cca_ed_levels = atusb_ed_levels;
@@ -963,7 +963,7 @@ static int atusb_get_and_conf_chip(struct atusb *atusb)
atusb->hw->phy->supported.page[2].chunk[1].band = IEEE802154_915_MHZ_BAND;
atusb->hw->phy->current_channel = 5;
- atusb->hw->phy->symbol_duration = 25;
+ atusb->hw->phy->symbol_duration = 25 * NSEC_PER_USEC;
atusb->hw->phy->supported.lbt = NL802154_SUPPORTED_BOOL_BOTH;
atusb->hw->phy->supported.tx_powers = at86rf212_powers;
atusb->hw->phy->supported.tx_powers_size = ARRAY_SIZE(at86rf212_powers);
diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
index 6854ec7747c0..809514611712 100644
--- a/drivers/net/ieee802154/ca8210.c
+++ b/drivers/net/ieee802154/ca8210.c
@@ -2978,7 +2978,7 @@ static void ca8210_hw_setup(struct ieee802154_hw *ca8210_hw)
ca8210_hw->phy->cca.mode = NL802154_CCA_ENERGY_CARRIER;
ca8210_hw->phy->cca.opt = NL802154_CCA_OPT_ENERGY_CARRIER_AND;
ca8210_hw->phy->cca_ed_level = -9800;
- ca8210_hw->phy->symbol_duration = 16;
+ ca8210_hw->phy->symbol_duration = 16 * NSEC_PER_USEC;
ca8210_hw->phy->lifs_period = 40;
ca8210_hw->phy->sifs_period = 12;
ca8210_hw->flags =
diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c
index e2c249aef430..34063b7e663e 100644
--- a/drivers/net/ieee802154/mcr20a.c
+++ b/drivers/net/ieee802154/mcr20a.c
@@ -975,9 +975,9 @@ static void mcr20a_hw_setup(struct mcr20a_local *lp)
dev_dbg(printdev(lp), "%s\n", __func__);
- phy->symbol_duration = 16;
- phy->lifs_period = 40 * phy->symbol_duration;
- phy->sifs_period = 12 * phy->symbol_duration;
+ phy->symbol_duration = 16 * NSEC_PER_USEC;
+ phy->lifs_period = (40 * phy->symbol_duration) / NSEC_PER_USEC;
+ phy->sifs_period = (12 * phy->symbol_duration) / NSEC_PER_USEC;
hw->flags = IEEE802154_HW_TX_OMIT_CKSUM |
IEEE802154_HW_AFILT |
@@ -1010,7 +1010,7 @@ static void mcr20a_hw_setup(struct mcr20a_local *lp)
phy->current_page = 0;
/* MCR20A default reset value */
phy->current_channel = 20;
- phy->symbol_duration = 16;
+ phy->symbol_duration = 16 * NSEC_PER_USEC;
phy->supported.tx_powers = mcr20a_powers;
phy->supported.tx_powers_size = ARRAY_SIZE(mcr20a_powers);
phy->cca_ed_level = phy->supported.cca_ed_levels[75];
diff --git a/include/net/cfg802154.h b/include/net/cfg802154.h
index 03c8008217fb..286709a9dd0b 100644
--- a/include/net/cfg802154.h
+++ b/include/net/cfg802154.h
@@ -253,8 +253,8 @@ struct wpan_phy {
/* PHY depended MAC PIB values */
- /* 802.15.4 acronym: Tdsym in usec */
- u8 symbol_duration;
+ /* 802.15.4 acronym: Tdsym in nsec */
+ u32 symbol_duration;
/* lifs and sifs periods timing */
u16 lifs_period;
u16 sifs_period;
diff --git a/net/mac802154/main.c b/net/mac802154/main.c
index 520cedc594e1..53153367f9d0 100644
--- a/net/mac802154/main.c
+++ b/net/mac802154/main.c
@@ -131,10 +131,10 @@ static void ieee802154_setup_wpan_phy_pib(struct wpan_phy *wpan_phy)
* Should be done when all drivers sets this value.
*/
- wpan_phy->lifs_period = IEEE802154_LIFS_PERIOD *
- wpan_phy->symbol_duration;
- wpan_phy->sifs_period = IEEE802154_SIFS_PERIOD *
- wpan_phy->symbol_duration;
+ wpan_phy->lifs_period =
+ (IEEE802154_LIFS_PERIOD * wpan_phy->symbol_duration) / 1000;
+ wpan_phy->sifs_period =
+ (IEEE802154_SIFS_PERIOD * wpan_phy->symbol_duration) / 1000;
}
int ieee802154_register_hw(struct ieee802154_hw *hw)
--
2.27.0
Now that we have access to all the basic information to know which
symbol duration should be applied, let's set the symbol duration
automatically. The two locations that must call for the symbol duration
to be set are:
- when manually requesting a channel change though the netlink interface
- at PHY creation, ieee802154_alloc_hw() already calls
ieee802154_change_channel() which will now update the symbol duration
accordingly.
If an information is missing, the symbol duration is not touched, a
debug message is eventually printed. This keeps the compatibility with
the unconverted drivers for which it was too complicated for me to find
their precise information. If they initially provided a symbol duration,
it would be kept. If they don't, the symbol duration value is left
untouched.
Signed-off-by: Miquel Raynal <[email protected]>
---
include/net/cfg802154.h | 2 +
net/mac802154/cfg.c | 1 +
net/mac802154/main.c | 105 ++++++++++++++++++++++++++++++++++++++++
3 files changed, 108 insertions(+)
diff --git a/include/net/cfg802154.h b/include/net/cfg802154.h
index 286709a9dd0b..4491e2724ff2 100644
--- a/include/net/cfg802154.h
+++ b/include/net/cfg802154.h
@@ -455,4 +455,6 @@ static inline const char *wpan_phy_name(struct wpan_phy *phy)
return dev_name(&phy->dev);
}
+void ieee802154_configure_durations(struct wpan_phy *phy);
+
#endif /* __NET_CFG802154_H */
diff --git a/net/mac802154/cfg.c b/net/mac802154/cfg.c
index fbeebe3bc31d..1e4a9f74ed43 100644
--- a/net/mac802154/cfg.c
+++ b/net/mac802154/cfg.c
@@ -118,6 +118,7 @@ ieee802154_set_channel(struct wpan_phy *wpan_phy, u8 page, u8 channel)
if (!ret) {
wpan_phy->current_page = page;
wpan_phy->current_channel = channel;
+ ieee802154_configure_durations(wpan_phy);
}
return ret;
diff --git a/net/mac802154/main.c b/net/mac802154/main.c
index 53153367f9d0..f08c34c27ea9 100644
--- a/net/mac802154/main.c
+++ b/net/mac802154/main.c
@@ -113,6 +113,109 @@ ieee802154_alloc_hw(size_t priv_data_len, const struct ieee802154_ops *ops)
}
EXPORT_SYMBOL(ieee802154_alloc_hw);
+void ieee802154_configure_durations(struct wpan_phy *phy)
+{
+ struct phy_page *page = &phy->supported.page[phy->current_page];
+ struct phy_channels *chan;
+ bool valid_band = false;
+ unsigned int chunk;
+ u32 duration = 0;
+
+ for (chunk = 0; chunk < page->nchunks; chunk++) {
+ if (page->chunk[chunk].channels & BIT(phy->current_channel))
+ break;
+ }
+
+ if (chunk == page->nchunks) {
+ pr_debug("Wrong channels description\n");
+ return;
+ }
+
+ chan = &page->chunk[chunk];
+ switch (chan->protocol) {
+ case IEEE802154_BPSK_PHY:
+ switch (chan->band) {
+ case IEEE802154_868_MHZ_BAND:
+ /* 868 MHz BPSK 802.15.4-2003: 20 ksym/s */
+ duration = 50 * NSEC_PER_USEC;
+ break;
+ case IEEE802154_915_MHZ_BAND:
+ /* 915 MHz BPSK 802.15.4-2003: 40 ksym/s */
+ duration = 25 * NSEC_PER_USEC;
+ break;
+ default:
+ break;
+ }
+ break;
+ case IEEE802154_OQPSK_PHY:
+ switch (chan->band) {
+ case IEEE802154_868_MHZ_BAND:
+ /* 868 MHz O-QPSK 802.15.4-2006: 25 ksym/s */
+ duration = 40 * NSEC_PER_USEC;
+ break;
+ case IEEE802154_915_MHZ_BAND:
+ case IEEE802154_2400_MHZ_BAND:
+ /* 915/2400 MHz O-QPSK 802.15.4-2006: 62.5 ksym/s */
+ duration = 16 * NSEC_PER_USEC;
+ break;
+ default:
+ break;
+ }
+ break;
+ case IEEE802154_CSS_PHY:
+ switch (chan->band) {
+ case IEEE802154_2400_MHZ_BAND:
+ /* 2.4 GHz CSS 802.15.4a-2007: 1/6 Msym/s */
+ duration = 6 * NSEC_PER_USEC;
+ break;
+ default:
+ break;
+ }
+ break;
+ case IEEE802154_HRP_UWB_PHY:
+ switch (chan->band) {
+ case IEEE802154_250_750_MHZ_BAND:
+ case IEEE802154_3100_4800_MHZ_BAND:
+ case IEEE802154_6000_10600_MHZ_BAND:
+ valid_band = true;
+ break;
+ default:
+ break;
+ }
+
+ if (!valid_band)
+ break;
+
+ /* UWB 802.15.4a-2007: 993.6 or 1017.6 or 3974.4 ns */
+ switch (chan->prf) {
+ case IEEE802154_16100KHZ_MEAN_PRF:
+ duration = 994;
+ break;
+ case IEEE802154_4030KHZ_MEAN_PRF:
+ duration = 3974;
+ break;
+ case IEEE802154_62890KHZ_MEAN_PRF:
+ duration = 1018;
+ break;
+ default:
+ break;
+ }
+ break;
+ default:
+ break;
+ }
+
+ if (!duration) {
+ pr_debug("Unknown PHY symbol duration\n");
+ return;
+ }
+
+ phy->symbol_duration = duration;
+ phy->lifs_period = (IEEE802154_LIFS_PERIOD * phy->symbol_duration) / NSEC_PER_SEC;
+ phy->sifs_period = (IEEE802154_SIFS_PERIOD * phy->symbol_duration) / NSEC_PER_SEC;
+}
+EXPORT_SYMBOL(ieee802154_configure_durations);
+
void ieee802154_free_hw(struct ieee802154_hw *hw)
{
struct ieee802154_local *local = hw_to_local(hw);
@@ -157,6 +260,8 @@ int ieee802154_register_hw(struct ieee802154_hw *hw)
ieee802154_setup_wpan_phy_pib(local->phy);
+ ieee802154_configure_durations(local->phy);
+
if (!(hw->flags & IEEE802154_HW_CSMA_PARAMS)) {
local->phy->supported.min_csma_backoffs = 4;
local->phy->supported.max_csma_backoffs = 4;
--
2.27.0
The core now knows how to set the symbol duration in a few cases, when
drivers correctly advertise the protocols used on each channel. For
these drivers, there is no more need to bother with symbol duration,
lifs and sifs periods so just drop the duplicated code.
Signed-off-by: Miquel Raynal <[email protected]>
---
drivers/net/ieee802154/at86rf230.c | 33 ------------------------------
drivers/net/ieee802154/atusb.c | 33 ------------------------------
drivers/net/ieee802154/ca8210.c | 1 -
drivers/net/ieee802154/mcr20a.c | 5 -----
4 files changed, 72 deletions(-)
diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c
index 653931b20ab4..ee75505477e8 100644
--- a/drivers/net/ieee802154/at86rf230.c
+++ b/drivers/net/ieee802154/at86rf230.c
@@ -1056,36 +1056,6 @@ at86rf212_set_channel(struct at86rf230_local *lp, u8 page, u8 channel)
if (rc < 0)
return rc;
- /* This sets the symbol_duration according frequency on the 212.
- * TODO move this handling while set channel and page in cfg802154.
- * We can do that, this timings are according 802.15.4 standard.
- * If we do that in cfg802154, this is a more generic calculation.
- *
- * This should also protected from ifs_timer. Means cancel timer and
- * init with a new value. For now, this is okay.
- */
- if (channel == 0) {
- if (page == 0) {
- /* SUB:0 and BPSK:0 -> BPSK-20 */
- lp->hw->phy->symbol_duration = 50 * NSEC_PER_USEC;
- } else {
- /* SUB:1 and BPSK:0 -> BPSK-40 */
- lp->hw->phy->symbol_duration = 25 * NSEC_PER_USEC;
- }
- } else {
- if (page == 0)
- /* SUB:0 and BPSK:1 -> OQPSK-100/200/400 */
- lp->hw->phy->symbol_duration = 40 * NSEC_PER_USEC;
- else
- /* SUB:1 and BPSK:1 -> OQPSK-250/500/1000 */
- lp->hw->phy->symbol_duration = 16 * NSEC_PER_USEC;
- }
-
- lp->hw->phy->lifs_period =
- (IEEE802154_LIFS_PERIOD * lp->hw->phy->symbol_duration) / 1000;
- lp->hw->phy->sifs_period =
- (IEEE802154_SIFS_PERIOD * lp->hw->phy->symbol_duration) / 1000;
-
return at86rf230_write_subreg(lp, SR_CHANNEL, channel);
}
@@ -1564,7 +1534,6 @@ at86rf230_detect_device(struct at86rf230_local *lp)
lp->hw->phy->supported.page[0].chunk[0].protocol = IEEE802154_OQPSK_PHY;
lp->hw->phy->supported.page[0].chunk[0].band = IEEE802154_2400_MHZ_BAND;
lp->hw->phy->current_channel = 11;
- lp->hw->phy->symbol_duration = 16 * NSEC_PER_USEC;
lp->hw->phy->supported.tx_powers = at86rf231_powers;
lp->hw->phy->supported.tx_powers_size = ARRAY_SIZE(at86rf231_powers);
lp->hw->phy->supported.cca_ed_levels = at86rf231_ed_levels;
@@ -1596,7 +1565,6 @@ at86rf230_detect_device(struct at86rf230_local *lp)
lp->hw->phy->supported.page[2].chunk[1].band = IEEE802154_915_MHZ_BAND;
lp->hw->phy->current_channel = 5;
- lp->hw->phy->symbol_duration = 25 * NSEC_PER_USEC;
lp->hw->phy->supported.lbt = NL802154_SUPPORTED_BOOL_BOTH;
lp->hw->phy->supported.tx_powers = at86rf212_powers;
lp->hw->phy->supported.tx_powers_size = ARRAY_SIZE(at86rf212_powers);
@@ -1611,7 +1579,6 @@ at86rf230_detect_device(struct at86rf230_local *lp)
lp->hw->phy->supported.page[0].chunk[0].protocol = IEEE802154_OQPSK_PHY;
lp->hw->phy->supported.page[0].chunk[0].band = IEEE802154_2400_MHZ_BAND;
lp->hw->phy->current_channel = 13;
- lp->hw->phy->symbol_duration = 16 * NSEC_PER_USEC;
lp->hw->phy->supported.tx_powers = at86rf233_powers;
lp->hw->phy->supported.tx_powers_size = ARRAY_SIZE(at86rf233_powers);
lp->hw->phy->supported.cca_ed_levels = at86rf233_ed_levels;
diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c
index 80382919520e..1a56073c1c52 100644
--- a/drivers/net/ieee802154/atusb.c
+++ b/drivers/net/ieee802154/atusb.c
@@ -667,36 +667,6 @@ static int hulusb_set_channel(struct ieee802154_hw *hw, u8 page, u8 channel)
if (rc < 0)
return rc;
- /* This sets the symbol_duration according frequency on the 212.
- * TODO move this handling while set channel and page in cfg802154.
- * We can do that, this timings are according 802.15.4 standard.
- * If we do that in cfg802154, this is a more generic calculation.
- *
- * This should also protected from ifs_timer. Means cancel timer and
- * init with a new value. For now, this is okay.
- */
- if (channel == 0) {
- if (page == 0) {
- /* SUB:0 and BPSK:0 -> BPSK-20 */
- lp->hw->phy->symbol_duration = 50 * NSEC_PER_USEC;
- } else {
- /* SUB:1 and BPSK:0 -> BPSK-40 */
- lp->hw->phy->symbol_duration = 25 * NSEC_PER_USEC;
- }
- } else {
- if (page == 0)
- /* SUB:0 and BPSK:1 -> OQPSK-100/200/400 */
- lp->hw->phy->symbol_duration = 40 * NSEC_PER_USEC;
- else
- /* SUB:1 and BPSK:1 -> OQPSK-250/500/1000 */
- lp->hw->phy->symbol_duration = 16 * NSEC_PER_USEC;
- }
-
- lp->hw->phy->lifs_period =
- (IEEE802154_LIFS_PERIOD * lp->hw->phy->symbol_duration) / 1000;
- lp->hw->phy->sifs_period =
- (IEEE802154_SIFS_PERIOD * lp->hw->phy->symbol_duration) / 1000;
-
return atusb_write_subreg(lp, SR_CHANNEL, channel);
}
@@ -919,7 +889,6 @@ static int atusb_get_and_conf_chip(struct atusb *atusb)
atusb->hw->phy->supported.page[0].chunk[0].protocol = IEEE802154_OQPSK_PHY;
atusb->hw->phy->supported.page[0].chunk[0].band = IEEE802154_2400_MHZ_BAND;
atusb->hw->phy->current_channel = 11; /* reset default */
- atusb->hw->phy->symbol_duration = 16 * NSEC_PER_USEC;
atusb->hw->phy->supported.tx_powers = atusb_powers;
atusb->hw->phy->supported.tx_powers_size = ARRAY_SIZE(atusb_powers);
hw->phy->supported.cca_ed_levels = atusb_ed_levels;
@@ -932,7 +901,6 @@ static int atusb_get_and_conf_chip(struct atusb *atusb)
atusb->hw->phy->supported.page[0].chunk[0].protocol = IEEE802154_OQPSK_PHY;
atusb->hw->phy->supported.page[0].chunk[0].band = IEEE802154_2400_MHZ_BAND;
atusb->hw->phy->current_channel = 11; /* reset default */
- atusb->hw->phy->symbol_duration = 16 * NSEC_PER_USEC;
atusb->hw->phy->supported.tx_powers = atusb_powers;
atusb->hw->phy->supported.tx_powers_size = ARRAY_SIZE(atusb_powers);
hw->phy->supported.cca_ed_levels = atusb_ed_levels;
@@ -963,7 +931,6 @@ static int atusb_get_and_conf_chip(struct atusb *atusb)
atusb->hw->phy->supported.page[2].chunk[1].band = IEEE802154_915_MHZ_BAND;
atusb->hw->phy->current_channel = 5;
- atusb->hw->phy->symbol_duration = 25 * NSEC_PER_USEC;
atusb->hw->phy->supported.lbt = NL802154_SUPPORTED_BOOL_BOTH;
atusb->hw->phy->supported.tx_powers = at86rf212_powers;
atusb->hw->phy->supported.tx_powers_size = ARRAY_SIZE(at86rf212_powers);
diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
index 809514611712..91456c5e5691 100644
--- a/drivers/net/ieee802154/ca8210.c
+++ b/drivers/net/ieee802154/ca8210.c
@@ -2978,7 +2978,6 @@ static void ca8210_hw_setup(struct ieee802154_hw *ca8210_hw)
ca8210_hw->phy->cca.mode = NL802154_CCA_ENERGY_CARRIER;
ca8210_hw->phy->cca.opt = NL802154_CCA_OPT_ENERGY_CARRIER_AND;
ca8210_hw->phy->cca_ed_level = -9800;
- ca8210_hw->phy->symbol_duration = 16 * NSEC_PER_USEC;
ca8210_hw->phy->lifs_period = 40;
ca8210_hw->phy->sifs_period = 12;
ca8210_hw->flags =
diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c
index 34063b7e663e..8d12c2968302 100644
--- a/drivers/net/ieee802154/mcr20a.c
+++ b/drivers/net/ieee802154/mcr20a.c
@@ -975,10 +975,6 @@ static void mcr20a_hw_setup(struct mcr20a_local *lp)
dev_dbg(printdev(lp), "%s\n", __func__);
- phy->symbol_duration = 16 * NSEC_PER_USEC;
- phy->lifs_period = (40 * phy->symbol_duration) / NSEC_PER_USEC;
- phy->sifs_period = (12 * phy->symbol_duration) / NSEC_PER_USEC;
-
hw->flags = IEEE802154_HW_TX_OMIT_CKSUM |
IEEE802154_HW_AFILT |
IEEE802154_HW_PROMISCUOUS;
@@ -1010,7 +1006,6 @@ static void mcr20a_hw_setup(struct mcr20a_local *lp)
phy->current_page = 0;
/* MCR20A default reset value */
phy->current_channel = 20;
- phy->symbol_duration = 16 * NSEC_PER_USEC;
phy->supported.tx_powers = mcr20a_powers;
phy->supported.tx_powers_size = ARRAY_SIZE(mcr20a_powers);
phy->cca_ed_level = phy->supported.cca_ed_levels[75];
--
2.27.0
The idea here is to create a structure per set of channels so that we
can define much more than basic bitfields for these.
The structure is currently almost empty on purpose because this change
is supposed to be a mechanical update without additional information but
more details will be added in the following commits.
For each page, the core now has access to how many "chunks" of channels
are defined. Overall up to only 3 chunks have been defined so let's
hardcode this value to simplify a lot the handling. Then, for each
chunk, we define an independent bitfield of channels. As there are
several users of these bitfields, we also create the
cfg802154_get_supported_chans() helper to reconstruct the bitfield as it
was before when the only information that matters is identifying the
supported/unsupported channels.
Signed-off-by: Miquel Raynal <[email protected]>
---
drivers/net/ieee802154/adf7242.c | 3 +-
drivers/net/ieee802154/at86rf230.c | 12 ++++---
drivers/net/ieee802154/atusb.c | 12 ++++---
drivers/net/ieee802154/ca8210.c | 3 +-
drivers/net/ieee802154/cc2520.c | 3 +-
drivers/net/ieee802154/fakelb.c | 43 +++++++++++++++---------
drivers/net/ieee802154/mac802154_hwsim.c | 43 +++++++++++++++---------
drivers/net/ieee802154/mcr20a.c | 3 +-
drivers/net/ieee802154/mrf24j40.c | 3 +-
include/net/cfg802154.h | 13 +++++--
net/ieee802154/core.h | 2 ++
net/ieee802154/nl-phy.c | 8 +++--
net/ieee802154/nl802154.c | 30 +++++++++++++----
13 files changed, 125 insertions(+), 53 deletions(-)
diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c
index 7db9cbd0f5de..40c77a643b78 100644
--- a/drivers/net/ieee802154/adf7242.c
+++ b/drivers/net/ieee802154/adf7242.c
@@ -1211,7 +1211,8 @@ static int adf7242_probe(struct spi_device *spi)
hw->extra_tx_headroom = 0;
/* We support only 2.4 Ghz */
- hw->phy->supported.channels[0] = 0x7FFF800;
+ hw->phy->supported.page[0].nchunks = 1;
+ hw->phy->supported.page[0].chunk[0].channels = 0x7FFF800;
hw->flags = IEEE802154_HW_OMIT_CKSUM |
IEEE802154_HW_CSMA_PARAMS |
diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c
index 0746150f78cf..144553f156dd 100644
--- a/drivers/net/ieee802154/at86rf230.c
+++ b/drivers/net/ieee802154/at86rf230.c
@@ -1559,7 +1559,8 @@ at86rf230_detect_device(struct at86rf230_local *lp)
case 3:
chip = "at86rf231";
lp->data = &at86rf231_data;
- lp->hw->phy->supported.channels[0] = 0x7FFF800;
+ lp->hw->phy->supported.page[0].nchunks = 1;
+ lp->hw->phy->supported.page[0].chunk[0].channels = 0x7FFF800;
lp->hw->phy->current_channel = 11;
lp->hw->phy->symbol_duration = 16;
lp->hw->phy->supported.tx_powers = at86rf231_powers;
@@ -1571,8 +1572,10 @@ at86rf230_detect_device(struct at86rf230_local *lp)
chip = "at86rf212";
lp->data = &at86rf212_data;
lp->hw->flags |= IEEE802154_HW_LBT;
- lp->hw->phy->supported.channels[0] = 0x00007FF;
- lp->hw->phy->supported.channels[2] = 0x00007FF;
+ lp->hw->phy->supported.page[0].nchunks = 1;
+ lp->hw->phy->supported.page[0].chunk[0].channels = 0x00007FF;
+ lp->hw->phy->supported.page[2].nchunks = 1;
+ lp->hw->phy->supported.page[2].chunk[0].channels = 0x00007FF;
lp->hw->phy->current_channel = 5;
lp->hw->phy->symbol_duration = 25;
lp->hw->phy->supported.lbt = NL802154_SUPPORTED_BOOL_BOTH;
@@ -1584,7 +1587,8 @@ at86rf230_detect_device(struct at86rf230_local *lp)
case 11:
chip = "at86rf233";
lp->data = &at86rf233_data;
- lp->hw->phy->supported.channels[0] = 0x7FFF800;
+ lp->hw->phy->supported.page[0].nchunks = 1;
+ lp->hw->phy->supported.page[0].chunk[0].channels = 0x7FFF800;
lp->hw->phy->current_channel = 13;
lp->hw->phy->symbol_duration = 16;
lp->hw->phy->supported.tx_powers = at86rf233_powers;
diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c
index 23ee0b14cbfa..38ebfacf2698 100644
--- a/drivers/net/ieee802154/atusb.c
+++ b/drivers/net/ieee802154/atusb.c
@@ -914,7 +914,8 @@ static int atusb_get_and_conf_chip(struct atusb *atusb)
switch (part_num) {
case 2:
chip = "AT86RF230";
- atusb->hw->phy->supported.channels[0] = 0x7FFF800;
+ atusb->hw->phy->supported.page[0].nchunks = 1;
+ atusb->hw->phy->supported.page[0].chunk[0].channels = 0x7FFF800;
atusb->hw->phy->current_channel = 11; /* reset default */
atusb->hw->phy->symbol_duration = 16;
atusb->hw->phy->supported.tx_powers = atusb_powers;
@@ -924,7 +925,8 @@ static int atusb_get_and_conf_chip(struct atusb *atusb)
break;
case 3:
chip = "AT86RF231";
- atusb->hw->phy->supported.channels[0] = 0x7FFF800;
+ atusb->hw->phy->supported.page[0].nchunks = 1;
+ atusb->hw->phy->supported.page[0].chunk[0].channels = 0x7FFF800;
atusb->hw->phy->current_channel = 11; /* reset default */
atusb->hw->phy->symbol_duration = 16;
atusb->hw->phy->supported.tx_powers = atusb_powers;
@@ -935,8 +937,10 @@ static int atusb_get_and_conf_chip(struct atusb *atusb)
case 7:
chip = "AT86RF212";
atusb->hw->flags |= IEEE802154_HW_LBT;
- atusb->hw->phy->supported.channels[0] = 0x00007FF;
- atusb->hw->phy->supported.channels[2] = 0x00007FF;
+ atusb->hw->phy->supported.page[0].nchunks = 1;
+ atusb->hw->phy->supported.page[0].chunk[0].channels = 0x00007FF;
+ atusb->hw->phy->supported.page[2].nchunks = 1;
+ atusb->hw->phy->supported.page[2].chunk[0].channels = 0x00007FF;
atusb->hw->phy->current_channel = 5;
atusb->hw->phy->symbol_duration = 25;
atusb->hw->phy->supported.lbt = NL802154_SUPPORTED_BOOL_BOTH;
diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
index 5d1b356cb9d3..cf31655fe714 100644
--- a/drivers/net/ieee802154/ca8210.c
+++ b/drivers/net/ieee802154/ca8210.c
@@ -2963,7 +2963,8 @@ static const s32 ca8210_ed_levels[CA8210_MAX_ED_LEVELS] = {
static void ca8210_hw_setup(struct ieee802154_hw *ca8210_hw)
{
/* Support channels 11-26 */
- ca8210_hw->phy->supported.channels[0] = CA8210_VALID_CHANNELS;
+ ca8210_hw->phy->supported.page[0].nchunks = 1;
+ ca8210_hw->phy->supported.page[0].chunk[0].channels = CA8210_VALID_CHANNELS;
ca8210_hw->phy->supported.tx_powers_size = CA8210_MAX_TX_POWERS;
ca8210_hw->phy->supported.tx_powers = ca8210_tx_powers;
ca8210_hw->phy->supported.cca_ed_levels_size = CA8210_MAX_ED_LEVELS;
diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
index 89c046b204e0..587f050ef4e8 100644
--- a/drivers/net/ieee802154/cc2520.c
+++ b/drivers/net/ieee802154/cc2520.c
@@ -836,7 +836,8 @@ static int cc2520_register(struct cc2520_private *priv)
ieee802154_random_extended_addr(&priv->hw->phy->perm_extended_addr);
/* We do support only 2.4 Ghz */
- priv->hw->phy->supported.channels[0] = 0x7FFF800;
+ priv->hw->phy->supported.page[0].nchunks = 1;
+ priv->hw->phy->supported.page[0].chunk[0].channels = 0x7FFF800;
priv->hw->flags = IEEE802154_HW_TX_OMIT_CKSUM | IEEE802154_HW_AFILT |
IEEE802154_HW_PROMISCUOUS;
diff --git a/drivers/net/ieee802154/fakelb.c b/drivers/net/ieee802154/fakelb.c
index 523d13ee02bf..bc44d1f7551c 100644
--- a/drivers/net/ieee802154/fakelb.c
+++ b/drivers/net/ieee802154/fakelb.c
@@ -137,36 +137,49 @@ static int fakelb_add_one(struct device *dev)
phy = hw->priv;
phy->hw = hw;
+ hw->phy->supported.page[0].nchunks = 3;
/* 868 MHz BPSK 802.15.4-2003 */
- hw->phy->supported.channels[0] |= 1;
+ hw->phy->supported.page[0].chunk[0].channels |= 1;
/* 915 MHz BPSK 802.15.4-2003 */
- hw->phy->supported.channels[0] |= 0x7fe;
+ hw->phy->supported.page[0].chunk[1].channels |= 0x7fe;
/* 2.4 GHz O-QPSK 802.15.4-2003 */
- hw->phy->supported.channels[0] |= 0x7FFF800;
+ hw->phy->supported.page[0].chunk[2].channels |= 0x7FFF800;
+
+ hw->phy->supported.page[1].nchunks = 2;
/* 868 MHz ASK 802.15.4-2006 */
- hw->phy->supported.channels[1] |= 1;
+ hw->phy->supported.page[1].chunk[0].channels |= 1;
/* 915 MHz ASK 802.15.4-2006 */
- hw->phy->supported.channels[1] |= 0x7fe;
+ hw->phy->supported.page[1].chunk[1].channels |= 0x7fe;
+
+ hw->phy->supported.page[2].nchunks = 2;
/* 868 MHz O-QPSK 802.15.4-2006 */
- hw->phy->supported.channels[2] |= 1;
+ hw->phy->supported.page[2].chunk[0].channels |= 1;
/* 915 MHz O-QPSK 802.15.4-2006 */
- hw->phy->supported.channels[2] |= 0x7fe;
+ hw->phy->supported.page[2].chunk[1].channels |= 0x7fe;
+
+ hw->phy->supported.page[3].nchunks = 1;
/* 2.4 GHz CSS 802.15.4a-2007 */
- hw->phy->supported.channels[3] |= 0x3fff;
+ hw->phy->supported.page[3].chunk[0].channels |= 0x3fff;
+
+ hw->phy->supported.page[4].nchunks = 3;
/* UWB Sub-gigahertz 802.15.4a-2007 */
- hw->phy->supported.channels[4] |= 1;
+ hw->phy->supported.page[4].chunk[0].channels |= 1;
/* UWB Low band 802.15.4a-2007 */
- hw->phy->supported.channels[4] |= 0x1e;
+ hw->phy->supported.page[4].chunk[1].channels |= 0x1e;
/* UWB High band 802.15.4a-2007 */
- hw->phy->supported.channels[4] |= 0xffe0;
+ hw->phy->supported.page[4].chunk[2].channels |= 0xffe0;
+
+ hw->phy->supported.page[5].nchunks = 2;
/* 750 MHz O-QPSK 802.15.4c-2009 */
- hw->phy->supported.channels[5] |= 0xf;
+ hw->phy->supported.page[5].chunk[0].channels |= 0xf;
/* 750 MHz MPSK 802.15.4c-2009 */
- hw->phy->supported.channels[5] |= 0xf0;
+ hw->phy->supported.page[5].chunk[1].channels |= 0xf0;
+
+ hw->phy->supported.page[6].nchunks = 2;
/* 950 MHz BPSK 802.15.4d-2009 */
- hw->phy->supported.channels[6] |= 0x3ff;
+ hw->phy->supported.page[6].chunk[0].channels |= 0x3ff;
/* 950 MHz GFSK 802.15.4d-2009 */
- hw->phy->supported.channels[6] |= 0x3ffc00;
+ hw->phy->supported.page[6].chunk[1].channels |= 0x3ffc00;
ieee802154_random_extended_addr(&hw->phy->perm_extended_addr);
/* fake phy channel 13 as default */
diff --git a/drivers/net/ieee802154/mac802154_hwsim.c b/drivers/net/ieee802154/mac802154_hwsim.c
index 5324d0eda223..76fa532d8891 100644
--- a/drivers/net/ieee802154/mac802154_hwsim.c
+++ b/drivers/net/ieee802154/mac802154_hwsim.c
@@ -744,36 +744,49 @@ static int hwsim_add_one(struct genl_info *info, struct device *dev,
phy = hw->priv;
phy->hw = hw;
+ hw->phy->supported.page[0].nchunks = 3;
/* 868 MHz BPSK 802.15.4-2003 */
- hw->phy->supported.channels[0] |= 1;
+ hw->phy->supported.page[0].chunk[0].channels |= 1;
/* 915 MHz BPSK 802.15.4-2003 */
- hw->phy->supported.channels[0] |= 0x7fe;
+ hw->phy->supported.page[0].chunk[1].channels |= 0x7fe;
/* 2.4 GHz O-QPSK 802.15.4-2003 */
- hw->phy->supported.channels[0] |= 0x7FFF800;
+ hw->phy->supported.page[0].chunk[2].channels |= 0x7FFF800;
+
+ hw->phy->supported.page[1].nchunks = 2;
/* 868 MHz ASK 802.15.4-2006 */
- hw->phy->supported.channels[1] |= 1;
+ hw->phy->supported.page[1].chunk[0].channels |= 1;
/* 915 MHz ASK 802.15.4-2006 */
- hw->phy->supported.channels[1] |= 0x7fe;
+ hw->phy->supported.page[1].chunk[1].channels |= 0x7fe;
+
+ hw->phy->supported.page[2].nchunks = 2;
/* 868 MHz O-QPSK 802.15.4-2006 */
- hw->phy->supported.channels[2] |= 1;
+ hw->phy->supported.page[2].chunk[0].channels |= 1;
/* 915 MHz O-QPSK 802.15.4-2006 */
- hw->phy->supported.channels[2] |= 0x7fe;
+ hw->phy->supported.page[2].chunk[1].channels |= 0x7fe;
+
+ hw->phy->supported.page[3].nchunks = 1;
/* 2.4 GHz CSS 802.15.4a-2007 */
- hw->phy->supported.channels[3] |= 0x3fff;
+ hw->phy->supported.page[3].chunk[0].channels |= 0x3fff;
+
+ hw->phy->supported.page[4].nchunks = 3;
/* UWB Sub-gigahertz 802.15.4a-2007 */
- hw->phy->supported.channels[4] |= 1;
+ hw->phy->supported.page[4].chunk[0].channels |= 1;
/* UWB Low band 802.15.4a-2007 */
- hw->phy->supported.channels[4] |= 0x1e;
+ hw->phy->supported.page[4].chunk[1].channels |= 0x1e;
/* UWB High band 802.15.4a-2007 */
- hw->phy->supported.channels[4] |= 0xffe0;
+ hw->phy->supported.page[4].chunk[2].channels |= 0xffe0;
+
+ hw->phy->supported.page[5].nchunks = 2;
/* 750 MHz O-QPSK 802.15.4c-2009 */
- hw->phy->supported.channels[5] |= 0xf;
+ hw->phy->supported.page[5].chunk[0].channels |= 0xf;
/* 750 MHz MPSK 802.15.4c-2009 */
- hw->phy->supported.channels[5] |= 0xf0;
+ hw->phy->supported.page[5].chunk[1].channels |= 0xf0;
+
+ hw->phy->supported.page[6].nchunks = 2;
/* 950 MHz BPSK 802.15.4d-2009 */
- hw->phy->supported.channels[6] |= 0x3ff;
+ hw->phy->supported.page[6].chunk[0].channels |= 0x3ff;
/* 950 MHz GFSK 802.15.4d-2009 */
- hw->phy->supported.channels[6] |= 0x3ffc00;
+ hw->phy->supported.page[6].chunk[1].channels |= 0x3ffc00;
ieee802154_random_extended_addr(&hw->phy->perm_extended_addr);
diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c
index 383231b85464..80bed905acf9 100644
--- a/drivers/net/ieee802154/mcr20a.c
+++ b/drivers/net/ieee802154/mcr20a.c
@@ -1002,7 +1002,8 @@ static void mcr20a_hw_setup(struct mcr20a_local *lp)
phy->cca.mode = NL802154_CCA_ENERGY;
- phy->supported.channels[0] = MCR20A_VALID_CHANNELS;
+ phy->supported.page[0].nchunks = 1;
+ phy->supported.page[0].chunk[0].channels = MCR20A_VALID_CHANNELS;
phy->current_page = 0;
/* MCR20A default reset value */
phy->current_channel = 20;
diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
index ff83e00b77af..5a38f3077771 100644
--- a/drivers/net/ieee802154/mrf24j40.c
+++ b/drivers/net/ieee802154/mrf24j40.c
@@ -1287,7 +1287,8 @@ static int mrf24j40_probe(struct spi_device *spi)
spi_set_drvdata(spi, devrec);
devrec->hw = hw;
devrec->hw->parent = &spi->dev;
- devrec->hw->phy->supported.channels[0] = CHANNEL_MASK;
+ devrec->hw->phy->supported.page[0].nchunks = 1;
+ devrec->hw->phy->supported.page[0].chunk[0].channels = CHANNEL_MASK;
devrec->hw->flags = IEEE802154_HW_TX_OMIT_CKSUM | IEEE802154_HW_AFILT |
IEEE802154_HW_CSMA_PARAMS |
IEEE802154_HW_PROMISCUOUS;
diff --git a/include/net/cfg802154.h b/include/net/cfg802154.h
index 6ed07844eb24..ef49a23801c6 100644
--- a/include/net/cfg802154.h
+++ b/include/net/cfg802154.h
@@ -131,9 +131,18 @@ wpan_phy_supported_bool(bool b, enum nl802154_supported_bool_states st)
return false;
}
+struct phy_channels {
+ u32 channels;
+};
+
+struct phy_page {
+ unsigned int nchunks;
+ struct phy_channels chunk[3];
+};
+
struct wpan_phy_supported {
- u32 channels[IEEE802154_MAX_PAGE + 1],
- cca_modes, cca_opts, iftypes;
+ struct phy_page page[IEEE802154_MAX_PAGE + 1];
+ u32 cca_modes, cca_opts, iftypes;
enum nl802154_supported_bool_states lbt;
u8 min_minbe, max_minbe, min_maxbe, max_maxbe,
min_csma_backoffs, max_csma_backoffs;
diff --git a/net/ieee802154/core.h b/net/ieee802154/core.h
index 1c19f575d574..a0cf6feffc6a 100644
--- a/net/ieee802154/core.h
+++ b/net/ieee802154/core.h
@@ -47,4 +47,6 @@ struct cfg802154_registered_device *
cfg802154_rdev_by_wpan_phy_idx(int wpan_phy_idx);
struct wpan_phy *wpan_phy_idx_to_wpan_phy(int wpan_phy_idx);
+u32 cfg802154_get_supported_chans(struct wpan_phy *phy, unsigned int page);
+
#endif /* __IEEE802154_CORE_H */
diff --git a/net/ieee802154/nl-phy.c b/net/ieee802154/nl-phy.c
index 02f6a53d0faa..304d6951cdf7 100644
--- a/net/ieee802154/nl-phy.c
+++ b/net/ieee802154/nl-phy.c
@@ -32,6 +32,7 @@ static int ieee802154_nl_fill_phy(struct sk_buff *msg, u32 portid,
int i, pages = 0;
uint32_t *buf = kcalloc(IEEE802154_MAX_PAGE + 1, sizeof(uint32_t),
GFP_KERNEL);
+ u32 chans;
pr_debug("%s\n", __func__);
@@ -49,8 +50,11 @@ static int ieee802154_nl_fill_phy(struct sk_buff *msg, u32 portid,
nla_put_u8(msg, IEEE802154_ATTR_CHANNEL, phy->current_channel))
goto nla_put_failure;
for (i = 0; i <= IEEE802154_MAX_PAGE; i++) {
- if (phy->supported.channels[i])
- buf[pages++] = phy->supported.channels[i] | (i << 27);
+ chans = cfg802154_get_supported_chans(phy, i);
+ if (!chans)
+ continue;
+
+ buf[pages++] = chans | (i << 27);
}
if (pages &&
nla_put(msg, IEEE802154_ATTR_CHANNEL_PAGE_LIST,
diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c
index e0b072aecf0f..bd1015611a7e 100644
--- a/net/ieee802154/nl802154.c
+++ b/net/ieee802154/nl802154.c
@@ -320,6 +320,21 @@ nl802154_put_flags(struct sk_buff *msg, int attr, u32 mask)
return 0;
}
+u32 cfg802154_get_supported_chans(struct wpan_phy *phy, unsigned int page)
+{
+ struct phy_page *ppage;
+ unsigned int chunk;
+ u32 supported = 0;
+
+ ppage = &phy->supported.page[page];
+
+ for (chunk = 0; chunk <= ppage->nchunks; chunk++)
+ supported |= ppage->chunk[chunk].channels;
+
+ return supported;
+}
+EXPORT_SYMBOL(cfg802154_get_supported_chans);
+
static int
nl802154_send_wpan_phy_channels(struct cfg802154_registered_device *rdev,
struct sk_buff *msg)
@@ -333,7 +348,7 @@ nl802154_send_wpan_phy_channels(struct cfg802154_registered_device *rdev,
for (page = 0; page <= IEEE802154_MAX_PAGE; page++) {
if (nla_put_u32(msg, NL802154_ATTR_SUPPORTED_CHANNEL,
- rdev->wpan_phy.supported.channels[page]))
+ cfg802154_get_supported_chans(&rdev->wpan_phy, page)))
return -ENOBUFS;
}
nla_nest_end(msg, nl_page);
@@ -347,6 +362,7 @@ nl802154_put_capabilities(struct sk_buff *msg,
{
const struct wpan_phy_supported *caps = &rdev->wpan_phy.supported;
struct nlattr *nl_caps, *nl_channels;
+ u32 chans;
int i;
nl_caps = nla_nest_start_noflag(msg, NL802154_ATTR_WPAN_PHY_CAPS);
@@ -358,10 +374,12 @@ nl802154_put_capabilities(struct sk_buff *msg,
return -ENOBUFS;
for (i = 0; i <= IEEE802154_MAX_PAGE; i++) {
- if (caps->channels[i]) {
- if (nl802154_put_flags(msg, i, caps->channels[i]))
- return -ENOBUFS;
- }
+ chans = cfg802154_get_supported_chans(&rdev->wpan_phy, i);
+ if (!chans)
+ continue;
+
+ if (nl802154_put_flags(msg, i, chans))
+ return -ENOBUFS;
}
nla_nest_end(msg, nl_channels);
@@ -965,7 +983,7 @@ static int nl802154_set_channel(struct sk_buff *skb, struct genl_info *info)
/* check 802.15.4 constraints */
if (page > IEEE802154_MAX_PAGE || channel > IEEE802154_MAX_CHANNEL ||
- !(rdev->wpan_phy.supported.channels[page] & BIT(channel)))
+ !(cfg802154_get_supported_chans(&rdev->wpan_phy, page) & BIT(channel)))
return -EINVAL;
return rdev_set_channel(rdev, page, channel);
--
2.27.0