2022-07-22 12:34:49

by Alvin Šipraga

[permalink] [raw]
Subject: [PATCH -next 0/2] brcmfmac: AP STA concurrency patches from Cypress/Infineon

From: Alvin Šipraga <[email protected]>

We are using these two patches from Infineon (formerly Cypress) to
enable AP+STA mode on our CYW89359-based platform. They come from the
FMAC driver release package distributed by Infineon.

The key thing here is that apsta needs to be set to 1 in order for AP
mode to work concurrently with STA mode. I cannot speak for other
chipsets so a review from the Broadcom side would be welcome here.

For the ARP/ND offload being disabled in AP mode, I am of the view that
this is correct, but while Arend has given his Reviewed-by on it
previously, it was part of a different series [1], so I am sending
without in order to jog some memories.

[1] https://lore.kernel.org/linux-wireless/[email protected]/#t

Soontak Lee (1):
brcmfmac: Support multiple AP interfaces and fix STA disconnection
issue

Ting-Ying Li (1):
brcmfmac: don't allow arp/nd offload to be enabled if ap mode exists

.../broadcom/brcm80211/brcmfmac/cfg80211.c | 65 +++++++++++++++----
.../broadcom/brcm80211/brcmfmac/cfg80211.h | 2 +
.../broadcom/brcm80211/brcmfmac/common.c | 5 ++
.../broadcom/brcm80211/brcmfmac/core.c | 5 ++
4 files changed, 66 insertions(+), 11 deletions(-)

--
2.37.0


2022-08-10 05:58:50

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH -next 0/2] brcmfmac: AP STA concurrency patches from Cypress/Infineon

Alvin Šipraga <[email protected]> writes:

> From: Alvin Šipraga <[email protected]>
>
> We are using these two patches from Infineon (formerly Cypress) to
> enable AP+STA mode on our CYW89359-based platform. They come from the
> FMAC driver release package distributed by Infineon.
>
> The key thing here is that apsta needs to be set to 1 in order for AP
> mode to work concurrently with STA mode. I cannot speak for other
> chipsets so a review from the Broadcom side would be welcome here.
>
> For the ARP/ND offload being disabled in AP mode, I am of the view that
> this is correct, but while Arend has given his Reviewed-by on it
> previously, it was part of a different series [1], so I am sending
> without in order to jog some memories.
>
> [1] https://lore.kernel.org/linux-wireless/[email protected]/#t
>
> Soontak Lee (1):
> brcmfmac: Support multiple AP interfaces and fix STA disconnection
> issue
>
> Ting-Ying Li (1):
> brcmfmac: don't allow arp/nd offload to be enabled if ap mode exists

Arend, Franky & Hante: could you please take a look at this patchset?
Also I hope that people from Infineon could comment.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches