2022-11-29 14:02:23

by Arend van Spriel

[permalink] [raw]
Subject: Re: [PATCH V2 0/7] brcmfmac: support devices from multiple vendors

On 11/29/2022 2:54 PM, Arend van Spriel wrote:
> Took my sweet time coming with this follow-up series, but here
> it is. Hopefully, sending patches is working for me now.
>
> The bcm43xx family of wifi chipsets found its way to different
> groups inside and outside Broadcom. For the fullmac devices this
> means that in those difference groups firmware is being developed
> and the firmware api is bound to diverge. This series introduces
> a design change to accomodate supporting multiple firmware api's.
> The vender-specific support can be compiled in brcmfmac or
> built as a separate module. Currently the vendor-specific support
> does not have any real effect. At the momemt looking into SAE support
> which appear to be different for Cypress devices so that might be a
> first use-case.
>
> The patches apply to the main branch of the wireless-next repository.

Just realized I forgot the 'wifi:' prefix. Hopefully you can forgive me
this time? If not, I can resend.

Regards,
Arend


Attachments:
smime.p7s (4.12 kB)
S/MIME Cryptographic Signature

2022-12-01 11:22:29

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH V2 0/7] brcmfmac: support devices from multiple vendors

Arend van Spriel <[email protected]> writes:

> On 11/29/2022 2:54 PM, Arend van Spriel wrote:
>> Took my sweet time coming with this follow-up series, but here
>> it is. Hopefully, sending patches is working for me now.
>>
>> The bcm43xx family of wifi chipsets found its way to different
>> groups inside and outside Broadcom. For the fullmac devices this
>> means that in those difference groups firmware is being developed
>> and the firmware api is bound to diverge. This series introduces
>> a design change to accomodate supporting multiple firmware api's.
>> The vender-specific support can be compiled in brcmfmac or
>> built as a separate module. Currently the vendor-specific support
>> does not have any real effect. At the momemt looking into SAE support
>> which appear to be different for Cypress devices so that might be a
>> first use-case.
>>
>> The patches apply to the main branch of the wireless-next repository.
>
> Just realized I forgot the 'wifi:' prefix. Hopefully you can forgive
> me this time? If not, I can resend.

Yeah, I can add that. When we switched to using "wifi:" I was mentally
(and in my tools) prepared to adding those the next couple of years :)

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2022-12-01 11:26:48

by Arend van Spriel

[permalink] [raw]
Subject: Re: [PATCH V2 0/7] brcmfmac: support devices from multiple vendors

On 12/1/2022 12:12 PM, Kalle Valo wrote:
> Arend van Spriel <[email protected]> writes:
>
>> On 11/29/2022 2:54 PM, Arend van Spriel wrote:
>>> Took my sweet time coming with this follow-up series, but here
>>> it is. Hopefully, sending patches is working for me now.
>>>
>>> The bcm43xx family of wifi chipsets found its way to different
>>> groups inside and outside Broadcom. For the fullmac devices this
>>> means that in those difference groups firmware is being developed
>>> and the firmware api is bound to diverge. This series introduces
>>> a design change to accomodate supporting multiple firmware api's.
>>> The vender-specific support can be compiled in brcmfmac or
>>> built as a separate module. Currently the vendor-specific support
>>> does not have any real effect. At the momemt looking into SAE support
>>> which appear to be different for Cypress devices so that might be a
>>> first use-case.
>>>
>>> The patches apply to the main branch of the wireless-next repository.
>>
>> Just realized I forgot the 'wifi:' prefix. Hopefully you can forgive
>> me this time? If not, I can resend.
>
> Yeah, I can add that. When we switched to using "wifi:" I was mentally
> (and in my tools) prepared to adding those the next couple of years :)

From my side I will try to shorten that period ;-D

Gr. AvS


Attachments:
smime.p7s (4.12 kB)
S/MIME Cryptographic Signature

2022-12-08 14:48:24

by Kalle Valo

[permalink] [raw]
Subject: Re: [V2,1/7] wifi: brcmfmac: add function to unbind device to bus layer api

Arend van Spriel <[email protected]> wrote:

> Introduce a new bus callback .remove() which will unbind the device
> from the driver. This allows the common driver layer to stop handling
> a device.
>
> Reviewed-by: Hante Meuleman <[email protected]>
> Reviewed-by: Pieter-Paul Giesberts <[email protected]>
> Reviewed-by: Franky Lin <[email protected]>
> Signed-off-by: Arend van Spriel <[email protected]>

7 patches applied to wireless-next.git, thanks.

76821aad49ce wifi: brcmfmac: add function to unbind device to bus layer api
da6d9c8ecd00 wifi: brcmfmac: add firmware vendor info in driver info
d6a5c562214f wifi: brcmfmac: add support for vendor-specific firmware api
f74f1ec22dc2 wifi: brcmfmac: add support for Cypress firmware api
b1d94be570c2 wifi: brcmfmac: add support Broadcom BCA firmware api
7205f9f2fc55 wifi: brcmfmac: add vendor name in revinfo debugfs file
8041f2bffbf1 wifi: brcmfmac: introduce BRCMFMAC exported symbols namespace

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches