With the current implementation when radar is detected, the whole
configured DFS channels are moved to "unavailable" state(NOL).
However to move only the radar affected channels alone to NOL,
introducing two unsigned 16bit variables "cf1_radar_bitmap" and
"cf2_radar_bitmap" which denotes the radar(with a granularity of
20 MHz) in the first and the second part of the channel respectively.
The "cf2_radar_bitmap" value will be valid only when the
"center_freq2" is available.
The LSB of the radar bitmap corresponds to the lowest 20 MHz channel
of the configured channel bandwidth. Each bit set to "1" in this radar
bitmap indicates that radar is detected in that sub-channel. Based
on this radar bitmap the radar affected channels alone will be moved
to NOL. Advertise these radar bitmaps using new NL attributes
"NL80211_ATTR_CF1_RADAR_BITMAP" and "NL80211_ATTR_CF2_RADAR_BITMAP"
with the existing "NL80211_CMD_RADAR_DETECT". Once these are
advertised and the needed dfs state propagation is done, reset these
radar bitmap values as they are not valid until there is another
radar detection.
With these radar bitmaps, we can support bandwidth reduction and
RX puncturing in the DFS Channels.
Nagarajan Maran (2):
wifi: cfg80211: DFS radar detection support with radar bitmap
wifi: mac80211: radar bitmap support during radar detection.
drivers/net/wireless/ath/ath10k/debug.c | 2 +-
drivers/net/wireless/ath/ath10k/mac.c | 2 +-
drivers/net/wireless/ath/ath10k/wmi.c | 2 +-
drivers/net/wireless/ath/ath11k/wmi.c | 2 +-
drivers/net/wireless/ath/ath12k/wmi.c | 2 +-
drivers/net/wireless/ath/ath9k/dfs.c | 2 +-
drivers/net/wireless/ath/ath9k/dfs_debug.c | 2 +-
drivers/net/wireless/mac80211_hwsim.c | 2 +-
.../net/wireless/mediatek/mt76/mt7615/mcu.c | 2 +-
.../net/wireless/mediatek/mt76/mt76x02_dfs.c | 4 ++--
.../net/wireless/mediatek/mt76/mt7915/mcu.c | 2 +-
.../net/wireless/mediatek/mt76/mt7996/mcu.c | 2 +-
drivers/net/wireless/ti/wl18xx/event.c | 2 +-
include/net/cfg80211.h | 6 +++++
include/net/mac80211.h | 5 +++-
include/uapi/linux/nl80211.h | 11 +++++++++
net/mac80211/ieee80211_i.h | 2 ++
net/mac80211/util.c | 10 +++++++-
net/wireless/chan.c | 24 ++++++++++++-------
net/wireless/mlme.c | 4 ++++
net/wireless/nl80211.c | 11 +++++++++
net/wireless/reg.c | 3 +++
22 files changed, 80 insertions(+), 24 deletions(-)
base-commit: 58e4b9df840cad439a4c878f81bc105cac2197a7
--
2.17.1
With the current implementation when radar is detected, the whole
configured DFS channels are moved to "unavailable" state(NOL).
However to move only the radar affected channels alone to NOL,
introducing two unsigned 16bit variables "cf1_radar_bitmap" and
"cf2_radar_bitmap" which denotes the radar(with a granularity of
20 MHz) in the first and the second part of the channel respectively.
The "cf2_radar_bitmap" value will be valid only when the
"center_freq2" is available.
The LSB of the radar bitmap corresponds to the lowest 20 MHz channel
of the configured channel bandwidth. Each bit set to "1" in this radar
bitmap indicates that radar is detected in that sub-channel. Based
on this radar bitmap the radar affected channels alone will be moved
to NOL. Advertise these radar bitmaps using new NL attributes
"NL80211_ATTR_CF1_RADAR_BITMAP" and "NL80211_ATTR_CF2_RADAR_BITMAP"
with the existing "NL80211_CMD_RADAR_DETECT". Once these are
advertised and the needed dfs state propagation is done, reset these
radar bitmap values as they are not valid until there is another
radar detection.With these radar bitmaps, we can support bandwidth
reduction and RX puncturing in the DFS Channels.
Signed-off-by: Nagarajan Maran <[email protected]>
---
include/net/cfg80211.h | 6 ++++++
include/uapi/linux/nl80211.h | 11 +++++++++++
net/wireless/chan.c | 24 ++++++++++++++++--------
net/wireless/mlme.c | 4 ++++
net/wireless/nl80211.c | 11 +++++++++++
net/wireless/reg.c | 3 +++
6 files changed, 51 insertions(+), 8 deletions(-)
diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
index 03d4f4deadae..d6d4edb945db 100644
--- a/include/net/cfg80211.h
+++ b/include/net/cfg80211.h
@@ -744,6 +744,10 @@ struct key_params {
* chan will define the primary channel and all other
* parameters are ignored.
* @freq1_offset: offset from @center_freq1, in KHz
+ * @cf1_radar_bitmap: Radar bitmap in a granularity of 20 MHz in the
+ * first segment.
+ * @cf2_radar_bitmap: Radar bitmap in a granularity of 20 MHz in the
+ * second segment.
*/
struct cfg80211_chan_def {
struct ieee80211_channel *chan;
@@ -752,6 +756,8 @@ struct cfg80211_chan_def {
u32 center_freq2;
struct ieee80211_edmg edmg;
u16 freq1_offset;
+ u16 cf1_radar_bitmap;
+ u16 cf2_radar_bitmap;
};
/*
diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h
index c14a91bbca7c..4a1c875f5b6f 100644
--- a/include/uapi/linux/nl80211.h
+++ b/include/uapi/linux/nl80211.h
@@ -2751,6 +2751,15 @@ enum nl80211_commands {
* the incoming frame RX timestamp.
* @NL80211_ATTR_TD_BITMAP: Transition Disable bitmap, for subsequent
* (re)associations.
+ *
+ * @NL80211_ATTR_CF1_RADAR_BITMAP: (u16) RADAR bitmap where the LSB
+ * corresponds to the lowest 20 MHz of the first part of the channel.
+ * Each bit set to 1 indicates that radar is detected in that sub-channel.
+ * @NL80211_ATTR_CF2_RADAR_BITMAP: (u16) RADAR bitmap where the LSB
+ * corresponds to the lowest 20 MHz of the second part of the channel.
+ * Each bit set to 1 indicates that radar is detected in that sub-channel.
+ * This will be valid only when the %NL80211_ATTR_CENTER_FREQ2 is present.
+ *
* @NUM_NL80211_ATTR: total number of nl80211_attrs available
* @NL80211_ATTR_MAX: highest attribute number currently defined
* @__NL80211_ATTR_AFTER_LAST: internal use
@@ -3279,6 +3288,8 @@ enum nl80211_attrs {
NL80211_ATTR_TX_HW_TIMESTAMP,
NL80211_ATTR_RX_HW_TIMESTAMP,
NL80211_ATTR_TD_BITMAP,
+ NL80211_ATTR_CF1_RADAR_BITMAP,
+ NL80211_ATTR_CF2_RADAR_BITMAP,
/* add attributes here, update the policy in nl80211.c */
diff --git a/net/wireless/chan.c b/net/wireless/chan.c
index 0e5835cd8c61..38fffe1a613a 100644
--- a/net/wireless/chan.c
+++ b/net/wireless/chan.c
@@ -447,20 +447,26 @@ EXPORT_SYMBOL(cfg80211_chandef_compatible);
static void cfg80211_set_chans_dfs_state(struct wiphy *wiphy, u32 center_freq,
u32 bandwidth,
- enum nl80211_dfs_state dfs_state)
+ enum nl80211_dfs_state dfs_state,
+ u16 radar_bitmap)
{
struct ieee80211_channel *c;
u32 freq;
+ int i;
- for (freq = center_freq - bandwidth/2 + 10;
- freq <= center_freq + bandwidth/2 - 10;
- freq += 20) {
+ for (i = 0, freq = center_freq - bandwidth / 2 + 10;
+ freq <= center_freq + bandwidth / 2 - 10;
+ freq += 20, i++) {
c = ieee80211_get_channel(wiphy, freq);
if (!c || !(c->flags & IEEE80211_CHAN_RADAR))
continue;
- c->dfs_state = dfs_state;
- c->dfs_state_entered = jiffies;
+ if (!radar_bitmap ||
+ ((radar_bitmap & 1 << i) &&
+ dfs_state == NL80211_DFS_UNAVAILABLE)) {
+ c->dfs_state = dfs_state;
+ c->dfs_state_entered = jiffies;
+ }
}
}
@@ -478,12 +484,14 @@ void cfg80211_set_dfs_state(struct wiphy *wiphy,
return;
cfg80211_set_chans_dfs_state(wiphy, chandef->center_freq1,
- width, dfs_state);
+ width, dfs_state,
+ chandef->cf1_radar_bitmap);
if (!chandef->center_freq2)
return;
cfg80211_set_chans_dfs_state(wiphy, chandef->center_freq2,
- width, dfs_state);
+ width, dfs_state,
+ chandef->cf2_radar_bitmap);
}
static u32 cfg80211_get_start_freq(u32 center_freq,
diff --git a/net/wireless/mlme.c b/net/wireless/mlme.c
index 58e1fb18f85a..077db2b50728 100644
--- a/net/wireless/mlme.c
+++ b/net/wireless/mlme.c
@@ -963,6 +963,10 @@ void __cfg80211_radar_event(struct wiphy *wiphy,
memcpy(&rdev->radar_chandef, chandef, sizeof(struct cfg80211_chan_def));
queue_work(cfg80211_wq, &rdev->propagate_radar_detect_wk);
+
+ /* Reset radar bitmaps, as they are advertised with radar detection */
+ chandef->cf1_radar_bitmap = 0;
+ chandef->cf2_radar_bitmap = 0;
}
EXPORT_SYMBOL(__cfg80211_radar_event);
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 33a82ecab9d5..c7b6d1d3da1c 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -805,6 +805,8 @@ static const struct nla_policy nl80211_policy[NUM_NL80211_ATTR] = {
[NL80211_ATTR_MLD_ADDR] = NLA_POLICY_EXACT_LEN(ETH_ALEN),
[NL80211_ATTR_MLO_SUPPORT] = { .type = NLA_FLAG },
[NL80211_ATTR_MAX_NUM_AKM_SUITES] = { .type = NLA_REJECT },
+ [NL80211_ATTR_CF1_RADAR_BITMAP] = { .type = NLA_U16 },
+ [NL80211_ATTR_CF2_RADAR_BITMAP] = { .type = NLA_U16 },
};
/* policy for the key attributes */
@@ -3763,6 +3765,15 @@ static int nl80211_send_chandef(struct sk_buff *msg,
if (chandef->center_freq2 &&
nla_put_u32(msg, NL80211_ATTR_CENTER_FREQ2, chandef->center_freq2))
return -ENOBUFS;
+ if (chandef->cf1_radar_bitmap &&
+ nla_put_u16(msg, NL80211_ATTR_CF1_RADAR_BITMAP,
+ chandef->cf1_radar_bitmap))
+ return -ENOBUFS;
+ if (chandef->cf2_radar_bitmap &&
+ nla_put_u16(msg, NL80211_ATTR_CF2_RADAR_BITMAP,
+ chandef->cf2_radar_bitmap))
+ return -ENOBUFS;
+
return 0;
}
diff --git a/net/wireless/reg.c b/net/wireless/reg.c
index 4f3f31244e8b..cadfa2c1c0eb 100644
--- a/net/wireless/reg.c
+++ b/net/wireless/reg.c
@@ -4295,6 +4295,9 @@ void regulatory_propagate_dfs_state(struct wiphy *wiphy,
nl80211_radar_notify(rdev, chandef, event, NULL, GFP_KERNEL);
}
+ /* Reset radar bitmaps, since the propagation is done */
+ chandef->cf1_radar_bitmap = 0;
+ chandef->cf2_radar_bitmap = 0;
}
static int __init regulatory_init_db(void)
--
2.17.1
With the current implementation when radar is detected, the whole
configured DFS channels are moved to "unavailable" state(NOL).
However to move only the radar affected channels alone to NOL,
introducing two unsigned 16bit variables "cf1_radar_bitmap" and
"cf2_radar_bitmap" which denotes the radar(with a granularity of
20 MHz) in the first and the second part of the channel respectively.
The LSB of the radar bitmap corresponds to the lowest 20 MHz channel
of the configured channel bandwidth. Each bit set to "1" in this radar
bitmap indicates that radar is detected in that sub-channel. Pass
these radar bitmaps from driver to cfg80211 through the existing radar
detected workqueue, to move the affected channels alone to NOL. Change
the "ieee80211_radar_detected" API calls in drivers to address the new
parameters. With these radar bitmaps, we can support bandwidth
reduction and RX puncturing in the DFS Channels.
Signed-off-by: Nagarajan Maran <[email protected]>
---
drivers/net/wireless/ath/ath10k/debug.c | 2 +-
drivers/net/wireless/ath/ath10k/mac.c | 2 +-
drivers/net/wireless/ath/ath10k/wmi.c | 2 +-
drivers/net/wireless/ath/ath11k/wmi.c | 2 +-
drivers/net/wireless/ath/ath12k/wmi.c | 2 +-
drivers/net/wireless/ath/ath9k/dfs.c | 2 +-
drivers/net/wireless/ath/ath9k/dfs_debug.c | 2 +-
drivers/net/wireless/mac80211_hwsim.c | 2 +-
drivers/net/wireless/mediatek/mt76/mt7615/mcu.c | 2 +-
drivers/net/wireless/mediatek/mt76/mt76x02_dfs.c | 4 ++--
drivers/net/wireless/mediatek/mt76/mt7915/mcu.c | 2 +-
drivers/net/wireless/mediatek/mt76/mt7996/mcu.c | 2 +-
drivers/net/wireless/ti/wl18xx/event.c | 2 +-
include/net/mac80211.h | 5 ++++-
net/mac80211/ieee80211_i.h | 2 ++
net/mac80211/util.c | 10 +++++++++-
16 files changed, 29 insertions(+), 16 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c
index b9aea1510f7b..55bdd9daf451 100644
--- a/drivers/net/wireless/ath/ath10k/debug.c
+++ b/drivers/net/wireless/ath/ath10k/debug.c
@@ -1773,7 +1773,7 @@ static ssize_t ath10k_write_simulate_radar(struct file *file,
if (!arvif->is_started)
return -EINVAL;
- ieee80211_radar_detected(ar->hw);
+ ieee80211_radar_detected(ar->hw, 0, 0);
return count;
}
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index ec8d5b29bc72..12c284d578a0 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -1442,7 +1442,7 @@ static void ath10k_recalc_radar_detection(struct ath10k *ar)
* by indicating that radar was detected.
*/
ath10k_warn(ar, "failed to start CAC: %d\n", ret);
- ieee80211_radar_detected(ar->hw);
+ ieee80211_radar_detected(ar->hw, 0, 0);
}
}
diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
index 980d4124fa28..b99ece354584 100644
--- a/drivers/net/wireless/ath/ath10k/wmi.c
+++ b/drivers/net/wireless/ath/ath10k/wmi.c
@@ -3969,7 +3969,7 @@ static void ath10k_radar_detected(struct ath10k *ar)
if (ar->dfs_block_radar_events)
ath10k_info(ar, "DFS Radar detected, but ignored as requested\n");
else
- ieee80211_radar_detected(ar->hw);
+ ieee80211_radar_detected(ar->hw, 0, 0);
}
static void ath10k_radar_confirmation_work(struct work_struct *work)
diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c
index 2a8a3e3dcff6..7e1215d8988d 100644
--- a/drivers/net/wireless/ath/ath11k/wmi.c
+++ b/drivers/net/wireless/ath/ath11k/wmi.c
@@ -7738,7 +7738,7 @@ ath11k_wmi_pdev_dfs_radar_detected_event(struct ath11k_base *ab, struct sk_buff
if (ar->dfs_block_radar_events)
ath11k_info(ab, "DFS Radar detected, but ignored as requested\n");
else
- ieee80211_radar_detected(ar->hw);
+ ieee80211_radar_detected(ar->hw, 0, 0);
exit:
kfree(tb);
diff --git a/drivers/net/wireless/ath/ath12k/wmi.c b/drivers/net/wireless/ath/ath12k/wmi.c
index 338082719631..d6769d0adecc 100644
--- a/drivers/net/wireless/ath/ath12k/wmi.c
+++ b/drivers/net/wireless/ath/ath12k/wmi.c
@@ -6192,7 +6192,7 @@ ath12k_wmi_pdev_dfs_radar_detected_event(struct ath12k_base *ab, struct sk_buff
if (ar->dfs_block_radar_events)
ath12k_info(ab, "DFS Radar detected, but ignored as requested\n");
else
- ieee80211_radar_detected(ar->hw);
+ ieee80211_radar_detected(ar->hw, 0, 0);
exit:
kfree(tb);
diff --git a/drivers/net/wireless/ath/ath9k/dfs.c b/drivers/net/wireless/ath/ath9k/dfs.c
index 11349218bc21..f98f025cbb9c 100644
--- a/drivers/net/wireless/ath/ath9k/dfs.c
+++ b/drivers/net/wireless/ath/ath9k/dfs.c
@@ -280,7 +280,7 @@ ath9k_dfs_process_radar_pulse(struct ath_softc *sc, struct pulse_event *pe)
if (!pd->add_pulse(pd, pe, NULL))
return;
DFS_STAT_INC(sc, radar_detected);
- ieee80211_radar_detected(sc->hw);
+ ieee80211_radar_detected(sc->hw, 0, 0);
}
/*
diff --git a/drivers/net/wireless/ath/ath9k/dfs_debug.c b/drivers/net/wireless/ath/ath9k/dfs_debug.c
index 2a79c2fa8415..779844e8504c 100644
--- a/drivers/net/wireless/ath/ath9k/dfs_debug.c
+++ b/drivers/net/wireless/ath/ath9k/dfs_debug.c
@@ -122,7 +122,7 @@ static ssize_t write_file_simulate_radar(struct file *file,
{
struct ath_softc *sc = file->private_data;
- ieee80211_radar_detected(sc->hw);
+ ieee80211_radar_detected(sc->hw, 0, 0);
return count;
}
diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c
index c57c8903b7c0..872396a43bbc 100644
--- a/drivers/net/wireless/mac80211_hwsim.c
+++ b/drivers/net/wireless/mac80211_hwsim.c
@@ -1008,7 +1008,7 @@ static int hwsim_write_simulate_radar(void *dat, u64 val)
{
struct mac80211_hwsim_data *data = dat;
- ieee80211_radar_detected(data->hw);
+ ieee80211_radar_detected(data->hw, 0, 0);
return 0;
}
diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
index 83f30305414d..6979c4bbefa5 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
@@ -394,7 +394,7 @@ mt7615_mcu_rx_radar_detected(struct mt7615_dev *dev, struct sk_buff *skb)
if (mt76_phy_dfs_state(mphy) < MT_DFS_STATE_CAC)
return;
- ieee80211_radar_detected(mphy->hw);
+ ieee80211_radar_detected(mphy->hw, 0, 0);
dev->hw_pattern++;
}
diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_dfs.c b/drivers/net/wireless/mediatek/mt76/mt76x02_dfs.c
index 024a5c0a5a57..0c6d7b93c585 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76x02_dfs.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x02_dfs.c
@@ -630,7 +630,7 @@ static void mt76x02_dfs_tasklet(struct tasklet_struct *t)
radar_detected = mt76x02_dfs_check_detection(dev);
if (radar_detected) {
/* sw detector rx radar pattern */
- ieee80211_radar_detected(dev->mt76.hw);
+ ieee80211_radar_detected(dev->mt76.hw, 0, 0);
mt76x02_dfs_detector_reset(dev);
return;
@@ -658,7 +658,7 @@ static void mt76x02_dfs_tasklet(struct tasklet_struct *t)
/* hw detector rx radar pattern */
dfs_pd->stats[i].hw_pattern++;
- ieee80211_radar_detected(dev->mt76.hw);
+ ieee80211_radar_detected(dev->mt76.hw, 0, 0);
mt76x02_dfs_detector_reset(dev);
return;
diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
index b2652de082ba..d45550d8bdb6 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
@@ -277,7 +277,7 @@ mt7915_mcu_rx_radar_detected(struct mt7915_dev *dev, struct sk_buff *skb)
&dev->rdd2_chandef,
GFP_ATOMIC);
else
- ieee80211_radar_detected(mphy->hw);
+ ieee80211_radar_detected(mphy->hw, 0, 0);
dev->hw_pattern++;
}
diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c
index 04e1d10bbd21..05ca90ed06e7 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c
@@ -344,7 +344,7 @@ mt7996_mcu_rx_radar_detected(struct mt7996_dev *dev, struct sk_buff *skb)
&dev->rdd2_chandef,
GFP_ATOMIC);
else
- ieee80211_radar_detected(mphy->hw);
+ ieee80211_radar_detected(mphy->hw, 0, 0);
dev->hw_pattern++;
}
diff --git a/drivers/net/wireless/ti/wl18xx/event.c b/drivers/net/wireless/ti/wl18xx/event.c
index 34d95f458e1a..a382fb8a26ae 100644
--- a/drivers/net/wireless/ti/wl18xx/event.c
+++ b/drivers/net/wireless/ti/wl18xx/event.c
@@ -142,7 +142,7 @@ int wl18xx_process_mailbox_events(struct wl1271 *wl)
wl18xx_radar_type_decode(mbox->radar_type));
if (!wl->radar_debug_mode)
- ieee80211_radar_detected(wl->hw);
+ ieee80211_radar_detected(wl->hw, 0, 0);
}
if (vector & PERIODIC_SCAN_REPORT_EVENT_ID) {
diff --git a/include/net/mac80211.h b/include/net/mac80211.h
index 689da327ce2e..233905187132 100644
--- a/include/net/mac80211.h
+++ b/include/net/mac80211.h
@@ -6396,8 +6396,11 @@ void ieee80211_cqm_beacon_loss_notify(struct ieee80211_vif *vif, gfp_t gfp);
* ieee80211_radar_detected - inform that a radar was detected
*
* @hw: pointer as obtained from ieee80211_alloc_hw()
+ * @cf1_radar_bitmap: denotes the bitmap of radar in the first part of channel.
+ * @cf2_radar_bitmap: denotes the bitmap of radar in the second part of channel.
*/
-void ieee80211_radar_detected(struct ieee80211_hw *hw);
+void ieee80211_radar_detected(struct ieee80211_hw *hw, u16 cf1_radar_bitmap,
+ u16 cf2_radar_bitmap);
/**
* ieee80211_chswitch_done - Complete channel switch process
diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h
index 63ff0d2524b6..6eacc3325660 100644
--- a/net/mac80211/ieee80211_i.h
+++ b/net/mac80211/ieee80211_i.h
@@ -1552,6 +1552,8 @@ struct ieee80211_local {
/* virtual monitor interface */
struct ieee80211_sub_if_data __rcu *monitor_sdata;
struct cfg80211_chan_def monitor_chandef;
+ u16 cf1_radar_bitmap;
+ u16 cf2_radar_bitmap;
/* extended capabilities provided by mac80211 */
u8 ext_capa[8];
diff --git a/net/mac80211/util.c b/net/mac80211/util.c
index 6f5407038459..1c5109adff1b 100644
--- a/net/mac80211/util.c
+++ b/net/mac80211/util.c
@@ -4247,6 +4247,11 @@ void ieee80211_dfs_radar_detected_work(struct work_struct *work)
ieee80211_dfs_cac_cancel(local);
wiphy_unlock(local->hw.wiphy);
+ chandef.cf1_radar_bitmap = local->cf1_radar_bitmap;
+ chandef.cf2_radar_bitmap = local->cf2_radar_bitmap;
+ local->cf1_radar_bitmap = 0;
+ local->cf2_radar_bitmap = 0;
+
if (num_chanctx > 1)
/* XXX: multi-channel is not supported yet */
WARN_ON(1);
@@ -4254,9 +4259,12 @@ void ieee80211_dfs_radar_detected_work(struct work_struct *work)
cfg80211_radar_event(local->hw.wiphy, &chandef, GFP_KERNEL);
}
-void ieee80211_radar_detected(struct ieee80211_hw *hw)
+void ieee80211_radar_detected(struct ieee80211_hw *hw, u16 cf1_radar_bitmap,
+ u16 cf2_radar_bitmap)
{
struct ieee80211_local *local = hw_to_local(hw);
+ local->cf1_radar_bitmap = cf1_radar_bitmap;
+ local->cf2_radar_bitmap = cf2_radar_bitmap;
trace_api_radar_detected(local);
--
2.17.1
On Fri, 2022-12-16 at 12:39 +0530, Nagarajan Maran wrote:
> With the current implementation when radar is detected, the whole
> configured DFS channels are moved to "unavailable" state(NOL).
OK, sure.
> However to move only the radar affected channels alone to NOL,
> introducing two unsigned 16bit variables "cf1_radar_bitmap" and
> "cf2_radar_bitmap" which denotes the radar(with a granularity of
> 20 MHz) in the first and the second part of the channel respectively.
Where do they come from? It's not really clear to me, you just have them
in the chandef... passing them indirectly like that seems like a really
problematic idea to me? I really don't think they should be in a
chandef. They have no meaning on configuration ... similar (but worse in
a way) to the discussion we had for puncturing.
Also, as far as cfg80211 is concerned, this information originally comes
in via __cfg80211_radar_event(). Why not just call
__cfg80211_radar_event() for each sub-channel separately (yes that might
need some better handling of the work structs etc. there, possibly with
a queue of events rather than just "memcpy(&rdev->radar_chandef, ...)")?
I can't say I like the way you've handled this here. If we really need
to have a single "radar event" rather than multiple (but then explain
why) then these could be extra arguments to __cfg80211_radar_event() I
guess, but right now I'm not sure I see any reason for that vs. just
calling __cfg80211_radar_event() multiple times for each affected 20 MHz
channel?
johannes