2022-12-23 02:38:49

by Yang Yang

Subject: [PATCH net-next] brcm80211: use strscpy() to instead of strncpy()

From: Xu Panda <[email protected]>

The implementation of strscpy() is more robust and safer.
That's now the recommended way to copy NUL-terminated strings.

Signed-off-by: Xu Panda <[email protected]>
Signed-off-by: Yang Yang <[email protected]>
---
drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c
index b7df576bb84d..66336c87b0d9 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c
@@ -584,8 +584,7 @@ struct dma_pub *dma_attach(char *name, struct brcms_c_info *wlc,
rxextheadroom, nrxpost, rxoffset, txregbase, rxregbase);

/* make a private copy of our callers name */
- strncpy(di->name, name, MAXNAMEL);
- di->name[MAXNAMEL - 1] = '\0';
+ strscpy(di->name, name, MAXNAMEL);

di->dmadev = core->dma_dev;

--
2.15.2

2023-01-16 13:13:25

by Kalle Valo

Subject: Re: [PATCH net-next] brcm80211: use strscpy() to instead of strncpy()

<[email protected]> wrote:

> From: Xu Panda <[email protected]>
>
> The implementation of strscpy() is more robust and safer.
> That's now the recommended way to copy NUL-terminated strings.
>
> Signed-off-by: Xu Panda <[email protected]>
> Signed-off-by: Yang Yang <[email protected]>

Mismatch email in From and Signed-off-by lines:

From: <[email protected]>
Signed-off-by: Yang Yang <[email protected]>

Patch set to Changes Requested.

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2023-01-16 13:36:54

by Leon Romanovsky

Subject: Re: [PATCH net-next] brcm80211: use strscpy() to instead of strncpy()

On Mon, Jan 16, 2023 at 01:08:36PM +0000, Kalle Valo wrote:
> <[email protected]> wrote:
>
> > From: Xu Panda <[email protected]>
> >
> > The implementation of strscpy() is more robust and safer.
> > That's now the recommended way to copy NUL-terminated strings.
> >
> > Signed-off-by: Xu Panda <[email protected]>
> > Signed-off-by: Yang Yang <[email protected]>
>
> Mismatch email in From and Signed-off-by lines:
>
> From: <[email protected]>
> Signed-off-by: Yang Yang <[email protected]>
>
> Patch set to Changes Requested.

Kalle, please be aware of this response
https://lore.kernel.org/netdev/[email protected]/

"I don't trust that you know what you're doing. So please don't send
any more strncpy() -> strscpy() conversions for networking."

Thanks

>
> --
> https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
>

2023-01-16 15:25:20

by Kalle Valo

Subject: Re: [PATCH net-next] brcm80211: use strscpy() to instead of strncpy()

Leon Romanovsky <[email protected]> writes:

> On Mon, Jan 16, 2023 at 01:08:36PM +0000, Kalle Valo wrote:
>> <[email protected]> wrote:
>>
>> > From: Xu Panda <[email protected]>
>> >
>> > The implementation of strscpy() is more robust and safer.
>> > That's now the recommended way to copy NUL-terminated strings.
>> >
>> > Signed-off-by: Xu Panda <[email protected]>
>> > Signed-off-by: Yang Yang <[email protected]>
>>
>> Mismatch email in From and Signed-off-by lines:
>>
>> From: <[email protected]>
>> Signed-off-by: Yang Yang <[email protected]>
>>
>> Patch set to Changes Requested.
>
> Kalle, please be aware of this response
> https://lore.kernel.org/netdev/[email protected]/
>
> "I don't trust that you know what you're doing. So please don't send
> any more strncpy() -> strscpy() conversions for networking."

Good to know, thanks.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches