2023-02-17 07:29:03

by Yang Yingliang

Subject: [PATCH -next] wifi: ath12k: use kfree_skb() instead of kfree()

The sk_buff should be freed with kfree_skb(), replace
the kfree() with kfree_skb().

Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
Signed-off-by: Yang Yingliang <[email protected]>
---
drivers/net/wireless/ath/ath12k/dp_tx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath12k/dp_tx.c b/drivers/net/wireless/ath/ath12k/dp_tx.c
index 95294f35155c..fd8d850f9818 100644
--- a/drivers/net/wireless/ath/ath12k/dp_tx.c
+++ b/drivers/net/wireless/ath/ath12k/dp_tx.c
@@ -270,7 +270,7 @@ int ath12k_dp_tx(struct ath12k *ar, struct ath12k_vif *arvif,
skb_ext_desc->len, DMA_TO_DEVICE);
ret = dma_mapping_error(ab->dev, ti.paddr);
if (ret) {
- kfree(skb_ext_desc);
+ kfree_skb(skb_ext_desc);
goto fail_unmap_dma;
}

--
2.25.1

2023-02-20 08:45:30

by Kalle Valo

Subject: Re: [PATCH -next] wifi: ath12k: use kfree_skb() instead of kfree()

Yang Yingliang <[email protected]> wrote:

> The sk_buff should be freed with kfree_skb(), replace
> the kfree() with kfree_skb().
>
> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
> Signed-off-by: Yang Yingliang <[email protected]>

Dan already submitted an identical patch:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=ath-next&id=8c464d16809fa02982f6341ea598ec5d07457f19

Patch set to Superseded.

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches