2012-02-08 06:53:39

by Naveen Gangadharan

Subject: [PATCH] ath6kl: Fix firmware crash dump

Fixed a bug when we dump the firmware crash log.

Signed-off-by: Naveen Gangadharan <[email protected]>
---
drivers/net/wireless/ath/ath6kl/hif.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/ath6kl/hif.c b/drivers/net/wireless/ath/ath6kl/hif.c
index e911737..78d0018 100644
--- a/drivers/net/wireless/ath/ath6kl/hif.c
+++ b/drivers/net/wireless/ath/ath6kl/hif.c
@@ -106,7 +106,7 @@ static void ath6kl_hif_dump_fw_crash(struct ath6kl *ar)

BUILD_BUG_ON(REG_DUMP_COUNT_AR6003 % 4);

- for (i = 0; i < REG_DUMP_COUNT_AR6003 / 4; i++) {
+ for (i = 0; i < REG_DUMP_COUNT_AR6003; i += 4) {
ath6kl_info("%d: 0x%8.8x 0x%8.8x 0x%8.8x 0x%8.8x\n",
4 * i,
le32_to_cpu(regdump_val[i]),
--
1.7.0.4

2012-02-08 09:57:42

by Kalle Valo

Subject: Re: [PATCH] ath6kl: Fix firmware crash dump

On 02/08/2012 08:53 AM, Naveen Gangadharan wrote:
> Fixed a bug when we dump the firmware crash log.
>
> Signed-off-by: Naveen Gangadharan <[email protected]>

Thanks, applied with these changes:

commit 3b96d49a79021ce4c1ca26aecd784d16aeb91a7c
Author: Naveen Gangadharan <[email protected]>
Date: Tue Feb 7 22:53:32 2012 -0800

ath6kl: Fix firmware crash dump

The firmware crash dump printout was wrong as it was using incorrect
offsets.

kvalo: improve commit log, change the "%d:" to print word indexes,
not bytes

Signed-off-by: Naveen Gangadharan <[email protected]>
Signed-off-by: Kalle Valo <[email protected]>

Kalle