On Tue, 2019-12-17 at 10:30 -0800, [email protected] wrote:
>
> drivers/net/wireless/ath/ath10k/mac.c | 3 ++-
> drivers/net/wireless/ath/ath9k/main.c | 3 +++
> drivers/net/wireless/ath/ath9k/xmit.c | 7 +++++--
All these driver changes worry me a bit - wouldn't that affect other
drivers as well?
johannes
On 02/07/2020 04:03 AM, Johannes Berg wrote:
> On Tue, 2019-12-17 at 10:30 -0800, [email protected] wrote:
>>
>> drivers/net/wireless/ath/ath10k/mac.c | 3 ++-
>> drivers/net/wireless/ath/ath9k/main.c | 3 +++
>> drivers/net/wireless/ath/ath9k/xmit.c | 7 +++++--
>
> All these driver changes worry me a bit - wouldn't that affect other
> drivers as well?
>
> johannes
>
The goal was to NOT adversely affect the drivers when the default (not-set)
value changed.
I changed the name of the variable and then touched every driver that used it
as a way of making sure that I found everything in the tree.
Hopefully that found everything... I did not specifically test ath9k, only ath10k
driver with this change.
(I then changed the variable name back before submitting the patch).
Thanks,
Ben
--
Ben Greear <[email protected]>
Candela Technologies Inc http://www.candelatech.com
On Fri, 2020-02-07 at 09:55 -0800, Ben Greear wrote:
> On 02/07/2020 04:03 AM, Johannes Berg wrote:
> > On Tue, 2019-12-17 at 10:30 -0800, [email protected] wrote:
> > > drivers/net/wireless/ath/ath10k/mac.c | 3 ++-
> > > drivers/net/wireless/ath/ath9k/main.c | 3 +++
> > > drivers/net/wireless/ath/ath9k/xmit.c | 7 +++++--
> >
> > All these driver changes worry me a bit - wouldn't that affect other
> > drivers as well?
> The goal was to NOT adversely affect the drivers when the default (not-set)
> value changed.
Right.
> I changed the name of the variable and then touched every driver that used it
> as a way of making sure that I found everything in the tree.
>
> Hopefully that found everything... I did not specifically test ath9k, only ath10k
> driver with this change.
>
> (I then changed the variable name back before submitting the patch).
OK, great, thanks :)
johannes
On 02/07/2020 11:19 AM, Johannes Berg wrote:
> On Fri, 2020-02-07 at 09:55 -0800, Ben Greear wrote:
>> On 02/07/2020 04:03 AM, Johannes Berg wrote:
>>> On Tue, 2019-12-17 at 10:30 -0800, [email protected] wrote:
>>>> drivers/net/wireless/ath/ath10k/mac.c | 3 ++-
>>>> drivers/net/wireless/ath/ath9k/main.c | 3 +++
>>>> drivers/net/wireless/ath/ath9k/xmit.c | 7 +++++--
>>>
>>> All these driver changes worry me a bit - wouldn't that affect other
>>> drivers as well?
>
>> The goal was to NOT adversely affect the drivers when the default (not-set)
>> value changed.
>
> Right.
>
>> I changed the name of the variable and then touched every driver that used it
>> as a way of making sure that I found everything in the tree.
>>
>> Hopefully that found everything... I did not specifically test ath9k, only ath10k
>> driver with this change.
>>
>> (I then changed the variable name back before submitting the patch).
>
> OK, great, thanks :)
Come to think of it, I did not do an 'all mod config' build, so possibly I missed some
things. I think my kernel compiles most of the drivers though.
Thanks,
Ben
--
Ben Greear <[email protected]>
Candela Technologies Inc http://www.candelatech.com