2020-06-30 04:38:53

by Sean Wang

[permalink] [raw]
Subject: [PATCH 2/3] mt76: mt7663u: fix potential memory leak in mcu message handler

From: Sean Wang <[email protected]>

Fix potential memory leak in mcu message handler on error condition.

Fixes: eb99cc95c3b6 ("mt76: mt7615: introduce mt7663u support")
Signed-off-by: Sean Wang <[email protected]>
---
drivers/net/wireless/mediatek/mt76/mt7615/usb_mcu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/usb_mcu.c b/drivers/net/wireless/mediatek/mt76/mt7615/usb_mcu.c
index cd709fd617db..3e66ff98cab8 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7615/usb_mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/usb_mcu.c
@@ -34,7 +34,6 @@ mt7663u_mcu_send_message(struct mt76_dev *mdev, struct sk_buff *skb,

ret = mt76u_bulk_msg(&dev->mt76, skb->data, skb->len, NULL,
1000, ep);
- dev_kfree_skb(skb);
if (ret < 0)
goto out;

@@ -43,6 +42,7 @@ mt7663u_mcu_send_message(struct mt76_dev *mdev, struct sk_buff *skb,

out:
mutex_unlock(&mdev->mcu.mutex);
+ dev_kfree_skb(skb);

return ret;
}
--
2.25.1


2020-06-30 07:14:50

by Lorenzo Bianconi

[permalink] [raw]
Subject: Re: [PATCH 2/3] mt76: mt7663u: fix potential memory leak in mcu message handler

> From: Sean Wang <[email protected]>
>
> Fix potential memory leak in mcu message handler on error condition.
>
> Fixes: eb99cc95c3b6 ("mt76: mt7615: introduce mt7663u support")
> Signed-off-by: Sean Wang <[email protected]>

Acked-by: Lorenzo Bianconi <[email protected]>

> ---
> drivers/net/wireless/mediatek/mt76/mt7615/usb_mcu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/usb_mcu.c b/drivers/net/wireless/mediatek/mt76/mt7615/usb_mcu.c
> index cd709fd617db..3e66ff98cab8 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7615/usb_mcu.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7615/usb_mcu.c
> @@ -34,7 +34,6 @@ mt7663u_mcu_send_message(struct mt76_dev *mdev, struct sk_buff *skb,
>
> ret = mt76u_bulk_msg(&dev->mt76, skb->data, skb->len, NULL,
> 1000, ep);
> - dev_kfree_skb(skb);
> if (ret < 0)
> goto out;
>
> @@ -43,6 +42,7 @@ mt7663u_mcu_send_message(struct mt76_dev *mdev, struct sk_buff *skb,
>
> out:
> mutex_unlock(&mdev->mcu.mutex);
> + dev_kfree_skb(skb);
>
> return ret;
> }
> --
> 2.25.1

Attachments:
(No filename) (1.14 kB)
 signature.asc (235.00 B)
 Download all attachments