2020-06-22 14:49:09

by Chi-Hsien Lin

[permalink] [raw]
Subject: Re: drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:1710:40: sparse: sparse: incorrect type in initializer (different base types)



On 06/22/2020 10:09, Kalle Valo wrote:
> + linux-wireless
>
> kernel test robot <[email protected]> writes:
>
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head: 5e857ce6eae7ca21b2055cca4885545e29228fe2
>> commit: 9c29da3f4e7ef9810bdfaf3d8aa5e6d2e33136f8 brcmfmac: Fix P2P
>> Group Formation failure via Go-neg method
>> date: 6 weeks ago
>> config: riscv-randconfig-s032-20200618 (attached as .config)
>> compiler: riscv64-linux-gcc (GCC) 9.3.0
>> reproduce:
>> # apt-get install sparse
>> # sparse version: v0.6.2-rc1-10-gc17b1b06-dirty
>> git checkout 9c29da3f4e7ef9810bdfaf3d8aa5e6d2e33136f8
>> # save the attached .config to linux build tree
>> make W=1 C=1 ARCH=riscv CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <[email protected]>
>>
>>
>> sparse warnings: (new ones prefixed by >>)
>>
>>>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:1710:40:
>>>> sparse: sparse: incorrect type in initializer (different base
>>>> types) @@ expected signed int [usertype] requested_dwell @@ got
>>>> restricted __le32 [usertype] dwell_time @@
>>>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:1710:40:
>>>> sparse: expected signed int [usertype] requested_dwell
>>>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:1710:40:
>>>> sparse: got restricted __le32 [usertype] dwell_time
>
> Joseph, please send a followup patch to fix these.
Kalle,

The fix is this one
https://patchwork.kernel.org/patch/11598109/

Do I need to submit a V2 with "Reported-by: kernel test robot
<[email protected]>" tag?


>


2020-06-22 14:58:04

by Kalle Valo

[permalink] [raw]
Subject: Re: drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:1710:40: sparse: sparse: incorrect type in initializer (different base types)

Chi-Hsien Lin <[email protected]> writes:

> On 06/22/2020 10:09, Kalle Valo wrote:
>> + linux-wireless
>>
>> kernel test robot <[email protected]> writes:
>>
>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>>> head: 5e857ce6eae7ca21b2055cca4885545e29228fe2
>>> commit: 9c29da3f4e7ef9810bdfaf3d8aa5e6d2e33136f8 brcmfmac: Fix P2P
>>> Group Formation failure via Go-neg method
>>> date: 6 weeks ago
>>> config: riscv-randconfig-s032-20200618 (attached as .config)
>>> compiler: riscv64-linux-gcc (GCC) 9.3.0
>>> reproduce:
>>> # apt-get install sparse
>>> # sparse version: v0.6.2-rc1-10-gc17b1b06-dirty
>>> git checkout 9c29da3f4e7ef9810bdfaf3d8aa5e6d2e33136f8
>>> # save the attached .config to linux build tree
>>> make W=1 C=1 ARCH=riscv CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
>>>
>>> If you fix the issue, kindly add following tag as appropriate
>>> Reported-by: kernel test robot <[email protected]>
>>>
>>>
>>> sparse warnings: (new ones prefixed by >>)
>>>
>>>>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:1710:40:
>>>>> sparse: sparse: incorrect type in initializer (different base
>>>>> types) @@ expected signed int [usertype] requested_dwell @@ got
>>>>> restricted __le32 [usertype] dwell_time @@
>>>>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:1710:40:
>>>>> sparse: expected signed int [usertype] requested_dwell
>>>>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:1710:40:
>>>>> sparse: got restricted __le32 [usertype] dwell_time
>>
>> Joseph, please send a followup patch to fix these.
> Kalle,
>
> The fix is this one
> https://patchwork.kernel.org/patch/11598109/

Great, thanks.

> Do I need to submit a V2 with "Reported-by: kernel test robot
> <[email protected]>" tag?

No need to send v2. But you can reply to that patch (so that patchwork
sees it) and ask me to add the tag during commit.

--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches