2018-12-28 10:01:16

by Lorenzo Bianconi

Subject: [PATCH] mt76: mac: minor optimizations in mt76x02_mac_tx_rate_val

Do not set bw variable to zero for legacy rates since it is already
initialized to zero. Moreover set nss to 1 just for legacy rates
since nss will be properly set for VHT/HT rates

Signed-off-by: Lorenzo Bianconi <[email protected]>
---
drivers/net/wireless/mediatek/mt76/mt76x02_mac.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c b/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c
index c08bf371e527..475eb3d40b4f 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c
@@ -130,10 +130,8 @@ static __le16
mt76x02_mac_tx_rate_val(struct mt76x02_dev *dev,
const struct ieee80211_tx_rate *rate, u8 *nss_val)
{
+ u8 phy, rate_idx, nss, bw = 0;
u16 rateval;
- u8 phy, rate_idx;
- u8 nss = 1;
- u8 bw = 0;

if (rate->flags & IEEE80211_TX_RC_VHT_MCS) {
rate_idx = rate->idx;
@@ -164,7 +162,7 @@ mt76x02_mac_tx_rate_val(struct mt76x02_dev *dev,

phy = val >> 8;
rate_idx = val & 0xff;
- bw = 0;
+ nss = 1;
}

rateval = FIELD_PREP(MT_RXWI_RATE_INDEX, rate_idx);
--
2.20.1

2018-12-28 12:30:36

by Felix Fietkau

Subject: Re: [PATCH] mt76: mac: minor optimizations in mt76x02_mac_tx_rate_val

On 2018-12-28 11:00, Lorenzo Bianconi wrote:
> Do not set bw variable to zero for legacy rates since it is already
> initialized to zero. Moreover set nss to 1 just for legacy rates
> since nss will be properly set for VHT/HT rates
>
> Signed-off-by: Lorenzo Bianconi <[email protected]>

Applied, thanks.

- Felix