2020-04-20 14:45:33

by Bouganim, Raz

[permalink] [raw]
Subject: [PATCH] wlcore: Adding suppoprt for IGTK key in wlcore driver

[PATCH] wlcore: Adding suppoprt for IGTK key in wlcore driver
This patch adding support for new cipher suite - AES-CMAC in wlcore driver.
This patch is required for support PMF/WPA3 connection to install IGTK key.

Signed-off-by: RazB <[email protected]>
---
drivers/net/wireless/ti/wlcore/cmd.h | 1 +
drivers/net/wireless/ti/wlcore/main.c | 4 ++++
2 files changed, 5 insertions(+)

diff --git a/drivers/net/wireless/ti/wlcore/cmd.h b/drivers/net/wireless/ti/wlcore/cmd.h
index f2609d5..1d14bd1 100644
--- a/drivers/net/wireless/ti/wlcore/cmd.h
+++ b/drivers/net/wireless/ti/wlcore/cmd.h
@@ -458,6 +458,7 @@ enum wl1271_cmd_key_type {
KEY_TKIP = 2,
KEY_AES = 3,
KEY_GEM = 4,
+ KEY_IGTK = 5,
};

struct wl1271_cmd_set_keys {
diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c
index f140f7d..1a75959 100644
--- a/drivers/net/wireless/ti/wlcore/main.c
+++ b/drivers/net/wireless/ti/wlcore/main.c
@@ -3547,6 +3547,9 @@ int wlcore_set_key(struct wl1271 *wl, enum set_key_cmd cmd,
case WL1271_CIPHER_SUITE_GEM:
key_type = KEY_GEM;
break;
+ case WLAN_CIPHER_SUITE_AES_CMAC:
+ key_type = KEY_IGTK;
+ break;
default:
wl1271_error("Unknown key algo 0x%x", key_conf->cipher);

@@ -6214,6 +6217,7 @@ static int wl1271_init_ieee80211(struct wl1271 *wl)
WLAN_CIPHER_SUITE_TKIP,
WLAN_CIPHER_SUITE_CCMP,
WL1271_CIPHER_SUITE_GEM,
+ WLAN_CIPHER_SUITE_AES_CMAC,
};

/* The tx descriptor buffer */
--
1.9.1


2020-04-21 08:30:11

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] wlcore: Adding suppoprt for IGTK key in wlcore driver

RazB <[email protected]> writes:

> [PATCH] wlcore: Adding suppoprt for IGTK key in wlcore driver
> This patch adding support for new cipher suite - AES-CMAC in wlcore driver.
> This patch is required for support PMF/WPA3 connection to install IGTK key.
>
> Signed-off-by: RazB <[email protected]>

Is your legal full name really "RazB"?

Also this patch looks have formatting issues. Please use checkpatch and
other tools verify that the patch is correct. More info in the link
below.

--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches