We have always met the unused log be printed as following.
...
[23193.523182] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp:
cannot find cfp by band 2 & channel=13 freq=0
[23378.633684] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp:
cannot find cfp by band 2 & channel=13 freq=0
Maybe that's related to wifi regdom, since wifi default area
was US and didn't support 12~14 channels.
As Frequencies:
* 2412 MHz [1] (30.0 dBm)
* 2417 MHz [2] (30.0 dBm)
* 2422 MHz [3] (30.0 dBm)
* 2427 MHz [4] (30.0 dBm)
* 2432 MHz [5] (30.0 dBm)
* 2437 MHz [6] (30.0 dBm)
* 2442 MHz [7] (30.0 dBm)
* 2447 MHz [8] (30.0 dBm)
* 2452 MHz [9] (30.0 dBm)
* 2457 MHz [10] (30.0 dBm)
* 2462 MHz [11] (30.0 dBm)
* 2467 MHz [12] (disabled)
* 2472 MHz [13] (disabled)
* 2484 MHz [14] (disabled)
Signed-off-by: Caesar Wang <[email protected]>
---
drivers/net/wireless/marvell/mwifiex/cfp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/cfp.c b/drivers/net/wireless/marvell/mwifiex/cfp.c
index 1ff2205..6e29943 100644
--- a/drivers/net/wireless/marvell/mwifiex/cfp.c
+++ b/drivers/net/wireless/marvell/mwifiex/cfp.c
@@ -350,7 +350,7 @@ mwifiex_get_cfp(struct mwifiex_private *priv, u8 band, u16 channel, u32 freq)
}
}
if (i == sband->n_channels) {
- mwifiex_dbg(priv->adapter, ERROR,
+ mwifiex_dbg(priv->adapter, WARN,
"%s: cannot find cfp by band %d\t"
"& channel=%d freq=%d\n",
__func__, band, channel, freq);
--
2.7.4
SGkgQ2Flc2FyLA0KDQpUaGUgb3JpZ2luYWwgbG9nIGluIGdvb2dsZSBpc3N1ZSB0cmFja2VyIHNo
b3cgdGhlcmUgZXhpc3QgQVAgaW4gY2hhbm5lbCAxMyBhZnRlciBwZXJpb2RpY2FsbHkgc2Nhbi4g
DQpQZXIgbXkgdW5kZXJzdGFuZCwgaWYgcmVnIGRvbWFpbiBpcyBzZXQgdG8gVVMsICBjaGFubmVs
IDEyLzEzLzE0IHdpbGwgbm90IGdldCBjaGFuY2UgdG8gc2Nhbi4gKHRlc3QgdXNpbmcgaXcvd3Bh
X3N1cHBsaWNhbnQpLg0KSSBhbSBjdXJpb3VzIGFib3V0IHdoZXRoZXIgdGhlcmUgYXJlIGFueSBk
aWZmIGZyb20gdXBwZXIgbGF5ZXIuDQoNCkFzIGEgdGVzdCwgeW91IGNhbiBwcmludCB0aGUgc2Nh
biBjaGFubmVsIGxpc3QsIGFzIGJlbG93Og0KDQpkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvd2ly
ZWxlc3MvbWFydmVsbC9td2lmaWV4L2NmZzgwMjExLmMgYi9kcml2ZXJzL25ldC93aXJlbGVzcy9t
YXJ2ZWxsL213aWZpZXgvY2ZnODAyMTEuYw0KaW5kZXggYTc1OTNhYS4uYTI4OTgxOCAxMDA2NDQN
Ci0tLSBhL2RyaXZlcnMvbmV0L3dpcmVsZXNzL21hcnZlbGwvbXdpZmlleC9jZmc4MDIxMS5jDQor
KysgYi9kcml2ZXJzL25ldC93aXJlbGVzcy9tYXJ2ZWxsL213aWZpZXgvY2ZnODAyMTEuYw0KQEAg
LTI1NzIsNiArMjU3Miw3IEBAIHN0YXRpYyBpbnQgbXdpZmlleF9zZXRfaWJzc19wYXJhbXMoc3Ry
dWN0IG13aWZpZXhfcHJpdmF0ZSAqcHJpdiwNCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IE1XSUZJRVhfVVNFUl9TQ0FOX0NIQU5fTUFYKTsgaSsrKSB7DQogICAgICAgICAgICAgICAgY2hh
biA9IHJlcXVlc3QtPmNoYW5uZWxzW2ldOw0KICAgICAgICAgICAgICAgIHVzZXJfc2Nhbl9jZmct
PmNoYW5fbGlzdFtpXS5jaGFuX251bWJlciA9IGNoYW4tPmh3X3ZhbHVlOw0KKyAgICAgICAgICAg
ICAgIHByX2VycigiY2hhbi0+aHdfdmFsdWUgPSAlZCIsIGNoYW4tPmh3X3ZhbHVlKTsNCiAgICAg
ICAgICAgICAgICB1c2VyX3NjYW5fY2ZnLT5jaGFuX2xpc3RbaV0ucmFkaW9fdHlwZSA9IGNoYW4t
PmJhbmQ7DQogDQogICAgICAgICAgICAgICAgaWYgKChjaGFuLT5mbGFncyAmIElFRUU4MDIxMV9D
SEFOX05PX0lSKSB8fCAhcmVxdWVzdC0+bl9zc2lkcykNCg0KUmVnYXJkcywNClNpbW9uDQoNCj4g
LS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogS2FsbGUgVmFsbyBbbWFpbHRvOmt2
YWxvQGNvZGVhdXJvcmEub3JnXQ0KPiBTZW50OiAyMDE35bm0NuaciDEz5pelIDE1OjUzDQo+IFRv
OiBDYWVzYXIgV2FuZw0KPiBDYzogYW1pdGthcndhckBnbWFpbC5jb207IFhpbm1pbmcgSHU7IE5p
c2hhbnQgU2FybXVrYWRhbTsgR2FuYXBhdGhpDQo+IEJoYXQ7IGxpbnV4LXdpcmVsZXNzQHZnZXIu
a2VybmVsLm9yZzsgbmV0ZGV2QHZnZXIua2VybmVsLm9yZzsNCj4gbGludXgta2VybmVsQHZnZXIu
a2VybmVsLm9yZzsgYnJpYW5ub3JyaXNAY2hyb21pdW0ub3JnOw0KPiBqZWZmeS5jaGVuQHJvY2st
Y2hpcHMuY29tDQo+IFN1YmplY3Q6IFtFWFRdIFJlOiBbUEFUQ0hdIG13aWZpZXg6IGZpeGVzIHRo
ZSB0cml2aWFsIHByaW50DQo+IA0KPiBFeHRlcm5hbCBFbWFpbA0KPiANCj4gLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LQ0KPiBDYWVzYXIgV2FuZyA8d3h0QHJvY2stY2hpcHMuY29tPiB3cml0ZXM6DQo+IA0KPiA+IOWc
qCAyMDE35bm0MDbmnIgxM+aXpSAxNTowNCwgS2FsbGUgVmFsbyDlhpnpgZM6DQo+ID4+IENhZXNh
ciBXYW5nIDx3eHRAcm9jay1jaGlwcy5jb20+IHdyaXRlczoNCj4gPj4NCj4gPj4+IEthbGxlLA0K
PiA+Pj4NCj4gPj4+IOWcqCAyMDE35bm0MDbmnIgxM+aXpSAxNDoyOCwgS2FsbGUgVmFsbyDlhpnp
gZM6DQo+ID4+Pj4gQ2Flc2FyIFdhbmcgPHd4dEByb2NrLWNoaXBzLmNvbT4gd3JpdGVzOg0KPiA+
Pj4+DQo+ID4+Pj4+IFdlIGhhdmUgYWx3YXlzIG1ldCB0aGUgdW51c2VkIGxvZyBiZSBwcmludGVk
IGFzIGZvbGxvd2luZy4NCj4gPj4+Pj4NCj4gPj4+Pj4gLi4uDQo+ID4+Pj4+IFsyMzE5My41MjMx
ODJdIG13aWZpZXhfcGNpZSAwMDAwOjAxOjAwLjA6IG13aWZpZXhfZ2V0X2NmcDoNCj4gPj4+Pj4g
Y2Fubm90IGZpbmQgY2ZwIGJ5IGJhbmQgMiAgICAmIGNoYW5uZWw9MTMgZnJlcT0wDQo+ID4+Pj4+
IFsyMzM3OC42MzM2ODRdIG13aWZpZXhfcGNpZSAwMDAwOjAxOjAwLjA6IG13aWZpZXhfZ2V0X2Nm
cDoNCj4gPj4+Pj4gY2Fubm90IGZpbmQgY2ZwIGJ5IGJhbmQgMiAgICAmIGNoYW5uZWw9MTMgZnJl
cT0wDQo+ID4+Pj4+DQo+ID4+Pj4+IE1heWJlIHRoYXQncyByZWxhdGVkIHRvIHdpZmkgcmVnZG9t
LCBzaW5jZSB3aWZpIGRlZmF1bHQgYXJlYSB3YXMNCj4gPj4+Pj4gVVMgYW5kIGRpZG4ndCBzdXBw
b3J0IDEyfjE0IGNoYW5uZWxzLg0KPiA+Pj4+Pg0KPiA+Pj4+PiBBcyBGcmVxdWVuY2llczoNCj4g
Pj4+Pj4gKiAyNDEyIE1IeiBbMV0gKDMwLjAgZEJtKQ0KPiA+Pj4+PiAqIDI0MTcgTUh6IFsyXSAo
MzAuMCBkQm0pDQo+ID4+Pj4+ICogMjQyMiBNSHogWzNdICgzMC4wIGRCbSkNCj4gPj4+Pj4gKiAy
NDI3IE1IeiBbNF0gKDMwLjAgZEJtKQ0KPiA+Pj4+PiAqIDI0MzIgTUh6IFs1XSAoMzAuMCBkQm0p
DQo+ID4+Pj4+ICogMjQzNyBNSHogWzZdICgzMC4wIGRCbSkNCj4gPj4+Pj4gKiAyNDQyIE1IeiBb
N10gKDMwLjAgZEJtKQ0KPiA+Pj4+PiAqIDI0NDcgTUh6IFs4XSAoMzAuMCBkQm0pDQo+ID4+Pj4+
ICogMjQ1MiBNSHogWzldICgzMC4wIGRCbSkNCj4gPj4+Pj4gKiAyNDU3IE1IeiBbMTBdICgzMC4w
IGRCbSkNCj4gPj4+Pj4gKiAyNDYyIE1IeiBbMTFdICgzMC4wIGRCbSkNCj4gPj4+Pj4gKiAyNDY3
IE1IeiBbMTJdIChkaXNhYmxlZCkNCj4gPj4+Pj4gKiAyNDcyIE1IeiBbMTNdIChkaXNhYmxlZCkN
Cj4gPj4+Pj4gKiAyNDg0IE1IeiBbMTRdIChkaXNhYmxlZCkNCj4gPj4+Pj4NCj4gPj4+Pj4gU2ln
bmVkLW9mZi1ieTogQ2Flc2FyIFdhbmcgPHd4dEByb2NrLWNoaXBzLmNvbT4NCj4gPj4+Pj4gLS0t
DQo+ID4+Pj4+DQo+ID4+Pj4+ICAgIGRyaXZlcnMvbmV0L3dpcmVsZXNzL21hcnZlbGwvbXdpZmll
eC9jZnAuYyB8IDIgKy0NCj4gPj4+Pj4gICAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCsp
LCAxIGRlbGV0aW9uKC0pDQo+ID4+Pj4+DQo+ID4+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL25l
dC93aXJlbGVzcy9tYXJ2ZWxsL213aWZpZXgvY2ZwLmMNCj4gPj4+Pj4gYi9kcml2ZXJzL25ldC93
aXJlbGVzcy9tYXJ2ZWxsL213aWZpZXgvY2ZwLmMNCj4gPj4+Pj4gaW5kZXggMWZmMjIwNS4uNmUy
OTk0MyAxMDA2NDQNCj4gPj4+Pj4gLS0tIGEvZHJpdmVycy9uZXQvd2lyZWxlc3MvbWFydmVsbC9t
d2lmaWV4L2NmcC5jDQo+ID4+Pj4+ICsrKyBiL2RyaXZlcnMvbmV0L3dpcmVsZXNzL21hcnZlbGwv
bXdpZmlleC9jZnAuYw0KPiA+Pj4+PiBAQCAtMzUwLDcgKzM1MCw3IEBAIG13aWZpZXhfZ2V0X2Nm
cChzdHJ1Y3QgbXdpZmlleF9wcml2YXRlICpwcml2LCB1OA0KPiBiYW5kLCB1MTYgY2hhbm5lbCwg
dTMyIGZyZXEpDQo+ID4+Pj4+ICAgIAkJfQ0KPiA+Pj4+PiAgICAJfQ0KPiA+Pj4+PiAgICAJaWYg
KGkgPT0gc2JhbmQtPm5fY2hhbm5lbHMpIHsNCj4gPj4+Pj4gLQkJbXdpZmlleF9kYmcocHJpdi0+
YWRhcHRlciwgRVJST1IsDQo+ID4+Pj4+ICsJCW13aWZpZXhfZGJnKHByaXYtPmFkYXB0ZXIsIFdB
Uk4sDQo+ID4+Pj4+ICAgIAkJCSAgICAiJXM6IGNhbm5vdCBmaW5kIGNmcCBieSBiYW5kICVkXHQi
DQo+ID4+Pj4+ICAgIAkJCSAgICAiJiBjaGFubmVsPSVkIGZyZXE9JWRcbiIsDQo+ID4+Pj4+ICAg
IAkJCSAgICBfX2Z1bmNfXywgYmFuZCwgY2hhbm5lbCwgZnJlcSk7DQo+ID4+Pj4gSSBkb24ndCBz
ZWUgaG93IHRoaXMgZml4ZXMgYW55dGhpbmcsIGNhcmUgdG8gZXhwbGFpbj8gQW5kIHRoZSB0aXRs
ZQ0KPiA+Pj4+IGlzIHF1aXRlIHZhZ3VlLg0KPiA+Pj4gU29ycnkgZm9yIHRoZSBkZXNjcmlwdGlv
biBtYXliZSB1bmNsZWFyLg0KPiA+Pj4gSSdtIGFzc3VtaW5nIHRoZSBwcmludCBsb2cgaXMgZXhw
ZWN0ZWQgZm9yIG1hcnZlbCB3aWZpIGRyaXZlci4gRG8gd2UNCj4gPj4+IHNob3VsZCB1c2UgJ1dB
Uk4nIHRvIGluc3RlYWQgb2YgdGhlICdFUlJPUicgaGVyZS4NCj4gPj4gQnV0IGRvZXMgdGhhdCBt
YWtlIGFueSBmdW5jdGlvbmFsIGRpZmZlcmVuY2UsIGlzbid0IHRoZSB3YXJuaW5nIHN0aWxsDQo+
ID4+IHByaW50ZWQ/DQo+ID4+DQo+ID4NCj4gPiBBdCBsZWFzdCwgdGhhdCBzaG91bGRuJ3QgYmUg
cHJpbnRlZCBsb2cgYnkgZGVmYXVsdC4gIDopDQo+ID4NCj4gPiBpZiBJIHJlYWQgdGhlIGNvZGUg
aXMgY29ycmVjdC4gVGhhdCBvbmx5IHRoZSBNU0cvRkFUQUwvRVJST1Igd2lsbA0KPiA+IG91dHB1
dCBieSBkZWZhdWx0Lg0KPiA+DQo+ID4gLyoqDQo+ID4gICplbnVtIG13aWZpZXhfZGVidWdfbGV2
ZWwgIC0gIG1hcnZlbGwgd2lmaSBkZWJ1ZyBsZXZlbCAgKi8gZW51bQ0KPiA+IE1XSUZJRVhfREVC
VUdfTEVWRUwgew0KPiA+ICAgICBNV0lGSUVYX0RCR19NU0cgICAgICAgID0gMHgwMDAwMDAwMSwN
Cj4gPiAgICAgTVdJRklFWF9EQkdfRkFUQUwgICAgPSAweDAwMDAwMDAyLA0KPiA+ICAgICBNV0lG
SUVYX0RCR19FUlJPUiAgICA9IDB4MDAwMDAwMDQsDQo+ID4gICAgIE1XSUZJRVhfREJHX0RBVEEg
ICAgPSAweDAwMDAwMDA4LA0KPiA+ICAgICBNV0lGSUVYX0RCR19DTUQgICAgICAgID0gMHgwMDAw
MDAxMCwNCj4gPiAgICAgTVdJRklFWF9EQkdfRVZFTlQgICAgPSAweDAwMDAwMDIwLA0KPiA+ICAg
ICBNV0lGSUVYX0RCR19JTlRSICAgID0gMHgwMDAwMDA0MCwNCj4gPiAgICAgTVdJRklFWF9EQkdf
SU9DVEwgICAgPSAweDAwMDAwMDgwLA0KPiA+DQo+ID4gICAgIE1XSUZJRVhfREJHX01QQV9EICAg
ID0gMHgwMDAwODAwMCwNCj4gPiAgICAgTVdJRklFWF9EQkdfREFUX0QgICAgPSAweDAwMDEwMDAw
LA0KPiA+ICAgICBNV0lGSUVYX0RCR19DTURfRCAgICA9IDB4MDAwMjAwMDAsDQo+ID4gICAgIE1X
SUZJRVhfREJHX0VWVF9EICAgID0gMHgwMDA0MDAwMCwNCj4gPiAgICAgTVdJRklFWF9EQkdfRldf
RCAgICA9IDB4MDAwODAwMDAsDQo+ID4gICAgIE1XSUZJRVhfREJHX0lGX0QgICAgPSAweDAwMTAw
MDAwLA0KPiA+DQo+ID4gICAgIE1XSUZJRVhfREJHX0VOVFJZICAgID0gMHgxMDAwMDAwMCwNCj4g
PiAgICAgTVdJRklFWF9EQkdfV0FSTiAgICA9IDB4MjAwMDAwMDAsDQo+ID4gICAgIE1XSUZJRVhf
REJHX0lORk8gICAgPSAweDQwMDAwMDAwLA0KPiA+ICAgICBNV0lGSUVYX0RCR19EVU1QICAgID0g
MHg4MDAwMDAwMCwNCj4gPg0KPiA+ICAgICBNV0lGSUVYX0RCR19BTlkgICAgICAgID0gMHhmZmZm
ZmZmZg0KPiA+IH07DQo+ID4NCj4gPiAjZGVmaW5lIE1XSUZJRVhfREVGQVVMVF9ERUJVR19NQVNL
ICAgIChNV0lGSUVYX0RCR19NU0cgfCBcDQo+ID4gICAgICAgICAgICAgICAgICAgICBNV0lGSUVY
X0RCR19GQVRBTCB8IFwNCj4gPiAgICAgICAgICAgICAgICAgICAgIE1XSUZJRVhfREJHX0VSUk9S
KQ0KPiANCj4gSGVoLCBtYWtlcyBtb3JlIHNlbnNlIG5vdyA6KSBCdXQgeW91IHN0aWxsIHNob3Vs
ZCBpbXByb3ZlIHRoZSB0aXRsZSBhbmQNCj4gZXhwbGFpbiBpbiB0aGUgY29tbWl0IGxvZyB0aGF0
IFdBUk4gbGV2ZWwgaXMgbm90IHByaW50ZWQgYnkgZGVmYXVsdC4NCj4gDQo+IEJ1dCBiZWZvcmUg
eW91IHN1Ym1pdCB2MiBsZXQncyB3YWl0IHdoYXQgTWFydmVsbCBzYXlzIGFib3V0IHRoaXMuDQo+
IA0KPiAtLQ0KPiBLYWxsZSBWYWxvDQo=
Caesar Wang <[email protected]> writes:
> =E5=9C=A8 2017=E5=B9=B406=E6=9C=8813=E6=97=A5 15:04, Kalle Valo =E5=86=99=
=E9=81=93:
>> Caesar Wang <[email protected]> writes:
>>
>>> Kalle,
>>>
>>> =E5=9C=A8 2017=E5=B9=B406=E6=9C=8813=E6=97=A5 14:28, Kalle Valo =E5=86=
=99=E9=81=93:
>>>> Caesar Wang <[email protected]> writes:
>>>>
>>>>> We have always met the unused log be printed as following.
>>>>>
>>>>> ...
>>>>> [23193.523182] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp:
>>>>> cannot find cfp by band 2 & channel=3D13 freq=3D0
>>>>> [23378.633684] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp:
>>>>> cannot find cfp by band 2 & channel=3D13 freq=3D0
>>>>>
>>>>> Maybe that's related to wifi regdom, since wifi default area
>>>>> was US and didn't support 12~14 channels.
>>>>>
>>>>> As Frequencies:
>>>>> * 2412 MHz [1] (30.0 dBm)
>>>>> * 2417 MHz [2] (30.0 dBm)
>>>>> * 2422 MHz [3] (30.0 dBm)
>>>>> * 2427 MHz [4] (30.0 dBm)
>>>>> * 2432 MHz [5] (30.0 dBm)
>>>>> * 2437 MHz [6] (30.0 dBm)
>>>>> * 2442 MHz [7] (30.0 dBm)
>>>>> * 2447 MHz [8] (30.0 dBm)
>>>>> * 2452 MHz [9] (30.0 dBm)
>>>>> * 2457 MHz [10] (30.0 dBm)
>>>>> * 2462 MHz [11] (30.0 dBm)
>>>>> * 2467 MHz [12] (disabled)
>>>>> * 2472 MHz [13] (disabled)
>>>>> * 2484 MHz [14] (disabled)
>>>>>
>>>>> Signed-off-by: Caesar Wang <[email protected]>
>>>>> ---
>>>>>
>>>>> drivers/net/wireless/marvell/mwifiex/cfp.c | 2 +-
>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/drivers/net/wireless/marvell/mwifiex/cfp.c b/drivers/net=
/wireless/marvell/mwifiex/cfp.c
>>>>> index 1ff2205..6e29943 100644
>>>>> --- a/drivers/net/wireless/marvell/mwifiex/cfp.c
>>>>> +++ b/drivers/net/wireless/marvell/mwifiex/cfp.c
>>>>> @@ -350,7 +350,7 @@ mwifiex_get_cfp(struct mwifiex_private *priv, u8 =
band, u16 channel, u32 freq)
>>>>> }
>>>>> }
>>>>> if (i =3D=3D sband->n_channels) {
>>>>> - mwifiex_dbg(priv->adapter, ERROR,
>>>>> + mwifiex_dbg(priv->adapter, WARN,
>>>>> "%s: cannot find cfp by band %d\t"
>>>>> "& channel=3D%d freq=3D%d\n",
>>>>> __func__, band, channel, freq);
>>>> I don't see how this fixes anything, care to explain? And the title is
>>>> quite vague.
>>> Sorry for the description maybe unclear.
>>> I'm assuming the print log is expected for marvel wifi driver. Do we
>>> should use 'WARN' to instead of the 'ERROR' here.
>> But does that make any functional difference, isn't the warning still
>> printed?
>>
>
> At least, that shouldn't be printed log by default. :)
>
> if I read the code is correct. That only the MSG/FATAL/ERROR will
> output by default.
>
> /**
> *enum mwifiex_debug_level - marvell wifi debug level
> */
> enum MWIFIEX_DEBUG_LEVEL {
> MWIFIEX_DBG_MSG =3D 0x00000001,
> MWIFIEX_DBG_FATAL =3D 0x00000002,
> MWIFIEX_DBG_ERROR =3D 0x00000004,
> MWIFIEX_DBG_DATA =3D 0x00000008,
> MWIFIEX_DBG_CMD =3D 0x00000010,
> MWIFIEX_DBG_EVENT =3D 0x00000020,
> MWIFIEX_DBG_INTR =3D 0x00000040,
> MWIFIEX_DBG_IOCTL =3D 0x00000080,
>
> MWIFIEX_DBG_MPA_D =3D 0x00008000,
> MWIFIEX_DBG_DAT_D =3D 0x00010000,
> MWIFIEX_DBG_CMD_D =3D 0x00020000,
> MWIFIEX_DBG_EVT_D =3D 0x00040000,
> MWIFIEX_DBG_FW_D =3D 0x00080000,
> MWIFIEX_DBG_IF_D =3D 0x00100000,
>
> MWIFIEX_DBG_ENTRY =3D 0x10000000,
> MWIFIEX_DBG_WARN =3D 0x20000000,
> MWIFIEX_DBG_INFO =3D 0x40000000,
> MWIFIEX_DBG_DUMP =3D 0x80000000,
>
> MWIFIEX_DBG_ANY =3D 0xffffffff
> };
>
> #define MWIFIEX_DEFAULT_DEBUG_MASK (MWIFIEX_DBG_MSG | \
> MWIFIEX_DBG_FATAL | \
> MWIFIEX_DBG_ERROR)
Heh, makes more sense now :) But you still should improve the title and
explain in the commit log that WARN level is not printed by default.
But before you submit v2 let's wait what Marvell says about this.
--=20
Kalle Valo
在 2017年06月13日 15:04, Kalle Valo 写道:
> Caesar Wang <[email protected]> writes:
>
>> Kalle,
>>
>> 在 2017年06月13日 14:28, Kalle Valo 写道:
>>> Caesar Wang <[email protected]> writes:
>>>
>>>> We have always met the unused log be printed as following.
>>>>
>>>> ...
>>>> [23193.523182] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp:
>>>> cannot find cfp by band 2 & channel=13 freq=0
>>>> [23378.633684] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp:
>>>> cannot find cfp by band 2 & channel=13 freq=0
>>>>
>>>> Maybe that's related to wifi regdom, since wifi default area
>>>> was US and didn't support 12~14 channels.
>>>>
>>>> As Frequencies:
>>>> * 2412 MHz [1] (30.0 dBm)
>>>> * 2417 MHz [2] (30.0 dBm)
>>>> * 2422 MHz [3] (30.0 dBm)
>>>> * 2427 MHz [4] (30.0 dBm)
>>>> * 2432 MHz [5] (30.0 dBm)
>>>> * 2437 MHz [6] (30.0 dBm)
>>>> * 2442 MHz [7] (30.0 dBm)
>>>> * 2447 MHz [8] (30.0 dBm)
>>>> * 2452 MHz [9] (30.0 dBm)
>>>> * 2457 MHz [10] (30.0 dBm)
>>>> * 2462 MHz [11] (30.0 dBm)
>>>> * 2467 MHz [12] (disabled)
>>>> * 2472 MHz [13] (disabled)
>>>> * 2484 MHz [14] (disabled)
>>>>
>>>> Signed-off-by: Caesar Wang <[email protected]>
>>>> ---
>>>>
>>>> drivers/net/wireless/marvell/mwifiex/cfp.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/net/wireless/marvell/mwifiex/cfp.c b/drivers/net/wireless/marvell/mwifiex/cfp.c
>>>> index 1ff2205..6e29943 100644
>>>> --- a/drivers/net/wireless/marvell/mwifiex/cfp.c
>>>> +++ b/drivers/net/wireless/marvell/mwifiex/cfp.c
>>>> @@ -350,7 +350,7 @@ mwifiex_get_cfp(struct mwifiex_private *priv, u8 band, u16 channel, u32 freq)
>>>> }
>>>> }
>>>> if (i == sband->n_channels) {
>>>> - mwifiex_dbg(priv->adapter, ERROR,
>>>> + mwifiex_dbg(priv->adapter, WARN,
>>>> "%s: cannot find cfp by band %d\t"
>>>> "& channel=%d freq=%d\n",
>>>> __func__, band, channel, freq);
>>> I don't see how this fixes anything, care to explain? And the title is
>>> quite vague.
>> Sorry for the description maybe unclear.
>> I'm assuming the print log is expected for marvel wifi driver. Do we
>> should use 'WARN' to instead of the 'ERROR' here.
> But does that make any functional difference, isn't the warning still
> printed?
>
At least, that shouldn't be printed log by default. :)
if I read the code is correct. That only the MSG/FATAL/ERROR will output
by default.
/**
*enum mwifiex_debug_level - marvell wifi debug level
*/
enum MWIFIEX_DEBUG_LEVEL {
MWIFIEX_DBG_MSG = 0x00000001,
MWIFIEX_DBG_FATAL = 0x00000002,
MWIFIEX_DBG_ERROR = 0x00000004,
MWIFIEX_DBG_DATA = 0x00000008,
MWIFIEX_DBG_CMD = 0x00000010,
MWIFIEX_DBG_EVENT = 0x00000020,
MWIFIEX_DBG_INTR = 0x00000040,
MWIFIEX_DBG_IOCTL = 0x00000080,
MWIFIEX_DBG_MPA_D = 0x00008000,
MWIFIEX_DBG_DAT_D = 0x00010000,
MWIFIEX_DBG_CMD_D = 0x00020000,
MWIFIEX_DBG_EVT_D = 0x00040000,
MWIFIEX_DBG_FW_D = 0x00080000,
MWIFIEX_DBG_IF_D = 0x00100000,
MWIFIEX_DBG_ENTRY = 0x10000000,
MWIFIEX_DBG_WARN = 0x20000000,
MWIFIEX_DBG_INFO = 0x40000000,
MWIFIEX_DBG_DUMP = 0x80000000,
MWIFIEX_DBG_ANY = 0xffffffff
};
#define MWIFIEX_DEFAULT_DEBUG_MASK (MWIFIEX_DBG_MSG | \
MWIFIEX_DBG_FATAL | \
MWIFIEX_DBG_ERROR)
Kalle,
?? 2017??06??13?? 14:28, Kalle Valo д??:
> Caesar Wang <[email protected]> writes:
>
>> We have always met the unused log be printed as following.
>>
>> ...
>> [23193.523182] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp:
>> cannot find cfp by band 2 & channel=13 freq=0
>> [23378.633684] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp:
>> cannot find cfp by band 2 & channel=13 freq=0
>>
>> Maybe that's related to wifi regdom, since wifi default area
>> was US and didn't support 12~14 channels.
>>
>> As Frequencies:
>> * 2412 MHz [1] (30.0 dBm)
>> * 2417 MHz [2] (30.0 dBm)
>> * 2422 MHz [3] (30.0 dBm)
>> * 2427 MHz [4] (30.0 dBm)
>> * 2432 MHz [5] (30.0 dBm)
>> * 2437 MHz [6] (30.0 dBm)
>> * 2442 MHz [7] (30.0 dBm)
>> * 2447 MHz [8] (30.0 dBm)
>> * 2452 MHz [9] (30.0 dBm)
>> * 2457 MHz [10] (30.0 dBm)
>> * 2462 MHz [11] (30.0 dBm)
>> * 2467 MHz [12] (disabled)
>> * 2472 MHz [13] (disabled)
>> * 2484 MHz [14] (disabled)
>>
>> Signed-off-by: Caesar Wang <[email protected]>
>> ---
>>
>> drivers/net/wireless/marvell/mwifiex/cfp.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/marvell/mwifiex/cfp.c b/drivers/net/wireless/marvell/mwifiex/cfp.c
>> index 1ff2205..6e29943 100644
>> --- a/drivers/net/wireless/marvell/mwifiex/cfp.c
>> +++ b/drivers/net/wireless/marvell/mwifiex/cfp.c
>> @@ -350,7 +350,7 @@ mwifiex_get_cfp(struct mwifiex_private *priv, u8 band, u16 channel, u32 freq)
>> }
>> }
>> if (i == sband->n_channels) {
>> - mwifiex_dbg(priv->adapter, ERROR,
>> + mwifiex_dbg(priv->adapter, WARN,
>> "%s: cannot find cfp by band %d\t"
>> "& channel=%d freq=%d\n",
>> __func__, band, channel, freq);
> I don't see how this fixes anything, care to explain? And the title is
> quite vague.
Sorry for the description maybe unclear.
I'm assuming the print log is expected for marvel wifi driver. Do we
should use 'WARN' to instead of the 'ERROR' here.
>
> And I would rather fix the root cause, mwifiex folks please comment.
Indeed, that's my expected.
-Caesar
>
Caesar Wang <[email protected]> writes:
> Kalle,
>
> =E5=9C=A8 2017=E5=B9=B406=E6=9C=8813=E6=97=A5 14:28, Kalle Valo =E5=86=99=
=E9=81=93:
>> Caesar Wang <[email protected]> writes:
>>
>>> We have always met the unused log be printed as following.
>>>
>>> ...
>>> [23193.523182] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp:
>>> cannot find cfp by band 2 & channel=3D13 freq=3D0
>>> [23378.633684] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp:
>>> cannot find cfp by band 2 & channel=3D13 freq=3D0
>>>
>>> Maybe that's related to wifi regdom, since wifi default area
>>> was US and didn't support 12~14 channels.
>>>
>>> As Frequencies:
>>> * 2412 MHz [1] (30.0 dBm)
>>> * 2417 MHz [2] (30.0 dBm)
>>> * 2422 MHz [3] (30.0 dBm)
>>> * 2427 MHz [4] (30.0 dBm)
>>> * 2432 MHz [5] (30.0 dBm)
>>> * 2437 MHz [6] (30.0 dBm)
>>> * 2442 MHz [7] (30.0 dBm)
>>> * 2447 MHz [8] (30.0 dBm)
>>> * 2452 MHz [9] (30.0 dBm)
>>> * 2457 MHz [10] (30.0 dBm)
>>> * 2462 MHz [11] (30.0 dBm)
>>> * 2467 MHz [12] (disabled)
>>> * 2472 MHz [13] (disabled)
>>> * 2484 MHz [14] (disabled)
>>>
>>> Signed-off-by: Caesar Wang <[email protected]>
>>> ---
>>>
>>> drivers/net/wireless/marvell/mwifiex/cfp.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/wireless/marvell/mwifiex/cfp.c b/drivers/net/w=
ireless/marvell/mwifiex/cfp.c
>>> index 1ff2205..6e29943 100644
>>> --- a/drivers/net/wireless/marvell/mwifiex/cfp.c
>>> +++ b/drivers/net/wireless/marvell/mwifiex/cfp.c
>>> @@ -350,7 +350,7 @@ mwifiex_get_cfp(struct mwifiex_private *priv, u8 ba=
nd, u16 channel, u32 freq)
>>> }
>>> }
>>> if (i =3D=3D sband->n_channels) {
>>> - mwifiex_dbg(priv->adapter, ERROR,
>>> + mwifiex_dbg(priv->adapter, WARN,
>>> "%s: cannot find cfp by band %d\t"
>>> "& channel=3D%d freq=3D%d\n",
>>> __func__, band, channel, freq);
>> I don't see how this fixes anything, care to explain? And the title is
>> quite vague.
>
> Sorry for the description maybe unclear.
> I'm assuming the print log is expected for marvel wifi driver. Do we
> should use 'WARN' to instead of the 'ERROR' here.
But does that make any functional difference, isn't the warning still
printed?
--=20
Kalle Valo
Caesar Wang <[email protected]> writes:
> We have always met the unused log be printed as following.
>
> ...
> [23193.523182] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp:
> cannot find cfp by band 2 & channel=13 freq=0
> [23378.633684] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp:
> cannot find cfp by band 2 & channel=13 freq=0
>
> Maybe that's related to wifi regdom, since wifi default area
> was US and didn't support 12~14 channels.
>
> As Frequencies:
> * 2412 MHz [1] (30.0 dBm)
> * 2417 MHz [2] (30.0 dBm)
> * 2422 MHz [3] (30.0 dBm)
> * 2427 MHz [4] (30.0 dBm)
> * 2432 MHz [5] (30.0 dBm)
> * 2437 MHz [6] (30.0 dBm)
> * 2442 MHz [7] (30.0 dBm)
> * 2447 MHz [8] (30.0 dBm)
> * 2452 MHz [9] (30.0 dBm)
> * 2457 MHz [10] (30.0 dBm)
> * 2462 MHz [11] (30.0 dBm)
> * 2467 MHz [12] (disabled)
> * 2472 MHz [13] (disabled)
> * 2484 MHz [14] (disabled)
>
> Signed-off-by: Caesar Wang <[email protected]>
> ---
>
> drivers/net/wireless/marvell/mwifiex/cfp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/cfp.c b/drivers/net/wireless/marvell/mwifiex/cfp.c
> index 1ff2205..6e29943 100644
> --- a/drivers/net/wireless/marvell/mwifiex/cfp.c
> +++ b/drivers/net/wireless/marvell/mwifiex/cfp.c
> @@ -350,7 +350,7 @@ mwifiex_get_cfp(struct mwifiex_private *priv, u8 band, u16 channel, u32 freq)
> }
> }
> if (i == sband->n_channels) {
> - mwifiex_dbg(priv->adapter, ERROR,
> + mwifiex_dbg(priv->adapter, WARN,
> "%s: cannot find cfp by band %d\t"
> "& channel=%d freq=%d\n",
> __func__, band, channel, freq);
I don't see how this fixes anything, care to explain? And the title is
quite vague.
And I would rather fix the root cause, mwifiex folks please comment.
--
Kalle Valo