2021-02-06 19:50:52

by Matteo Croce

Subject: [PATCH RESEND net-next] cfg80211: remove unused callback

From: Matteo Croce <[email protected]>

The ieee80211 class registers a callback which actually does nothing.
Given that the callback is optional, and all its accesses are protected
by a NULL check, remove it entirely.

Signed-off-by: Matteo Croce <[email protected]>
---
net/wireless/sysfs.c | 7 -------
1 file changed, 7 deletions(-)

diff --git a/net/wireless/sysfs.c b/net/wireless/sysfs.c
index 3ac1f48195d2..41cb4d565149 100644
--- a/net/wireless/sysfs.c
+++ b/net/wireless/sysfs.c
@@ -81,12 +81,6 @@ static void wiphy_dev_release(struct device *dev)
cfg80211_dev_free(rdev);
}

-static int wiphy_uevent(struct device *dev, struct kobj_uevent_env *env)
-{
- /* TODO, we probably need stuff here */
- return 0;
-}
-
#ifdef CONFIG_PM_SLEEP
static void cfg80211_leave_all(struct cfg80211_registered_device *rdev)
{
@@ -157,7 +151,6 @@ struct class ieee80211_class = {
.owner = THIS_MODULE,
.dev_release = wiphy_dev_release,
.dev_groups = ieee80211_groups,
- .dev_uevent = wiphy_uevent,
.pm = WIPHY_PM_OPS,
.ns_type = &net_ns_type_operations,
.namespace = wiphy_namespace,
--
2.29.2

2021-02-08 10:15:04

by Kalle Valo

Subject: Re: [PATCH RESEND net-next] cfg80211: remove unused callback

Matteo Croce <[email protected]> writes:

> From: Matteo Croce <[email protected]>
>
> The ieee80211 class registers a callback which actually does nothing.
> Given that the callback is optional, and all its accesses are protected
> by a NULL check, remove it entirely.
>
> Signed-off-by: Matteo Croce <[email protected]>
> ---
> net/wireless/sysfs.c | 7 -------
> 1 file changed, 7 deletions(-)

Normally cfg80211 patches go to mac80211-next, not net-next.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches