On Fri, Mar 25, 2011 at 6:00 AM, Wilson Loi <[email protected]> wrote:
> Another patch file
> ----------------------------
>
> diff -ruN a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
Please follow Documentation/SubmittingPatches when submitting patches,
or at least just add -p to diff, otherwise it's a bit difficult to
follow. thanks.
> ???? mmc_bus_put(host);
>
> -??? mmc_power_off(host);
> +??? if (!ret && !(host->pm_flags & MMC_PM_KEEP_POWER))
> +??? ??? mmc_power_off(host);
...
>
> -??? mmc_power_up(host);
> +??? if (!(host->pm_flags & MMC_PM_KEEP_POWER))
> +??? ??? mmc_power_up(host);
> ???? ret = host->bus_ops->power_restore(host);
I have the same question here: if you driver doesn't want its card to
be powered down, why does it invoke (or let runtime PM invoke on its
behalf) mmc_power_save_host() in the first place ?