2011-02-04 22:34:51

by Michael Büsch

Subject: [PATCH] ssb-pcmcia: Fix parsing of invariants tuples

This fixes parsing of the device invariants (MAC address)
for PCMCIA SSB devices.

ssb_pcmcia_do_get_invariants expects an iv pointer as data
argument.

Tested-by: dylan cristiani <[email protected]>
Signed-off-by: Michael Buesch <[email protected]>
Cc: [email protected]

---


Index: wireless-testing/drivers/ssb/pcmcia.c
===================================================================
--- wireless-testing.orig/drivers/ssb/pcmcia.c 2010-12-30 15:49:39.000000000 +0100
+++ wireless-testing/drivers/ssb/pcmcia.c 2011-02-04 23:29:37.000000000 +0100
@@ -733,7 +733,7 @@ int ssb_pcmcia_get_invariants(struct ssb

/* Fetch the vendor specific tuples. */
res = pcmcia_loop_tuple(bus->host_pcmcia, SSB_PCMCIA_CIS,
- ssb_pcmcia_do_get_invariants, sprom);
+ ssb_pcmcia_do_get_invariants, iv);
if ((res == 0) || (res == -ENOSPC))
return 0;


--
Greetings Michael.

2011-02-04 22:55:19

by Rafał Miłecki

Subject: Re: [PATCH] ssb-pcmcia: Fix parsing of invariants tuples

2011/2/4 Michael Büsch <[email protected]>:
> This fixes parsing of the device invariants (MAC address)
> for PCMCIA SSB devices.
>
> ssb_pcmcia_do_get_invariants expects an iv pointer as data
> argument.
>
> Tested-by: dylan cristiani <[email protected]>
> Signed-off-by: Michael Buesch <[email protected]>
> Cc: [email protected]

For stable: it's regression in 2.6.33. AFAIU there is no need to apply
that for 2.6.32.

--
Rafał