2013-01-12 10:47:06

by Nathan Hintz

Subject: [PATCH 1/5] bcma: delete duplicate readl

The 'val' has already been read by the prior call to 'mips_busprobe32';
this 'readl' is unnecessary.

Signed-off-by: Nathan Hintz <[email protected]>
---
drivers/bcma/driver_pci_host.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/bcma/driver_pci_host.c b/drivers/bcma/driver_pci_host.c
index 536d353..56073a5 100644
--- a/drivers/bcma/driver_pci_host.c
+++ b/drivers/bcma/driver_pci_host.c
@@ -122,8 +122,6 @@ static int bcma_extpci_read_config(struct bcma_drv_pci *pc, unsigned int dev,
val = 0xffffffff;
goto unmap;
}
-
- val = readl(mmio);
}
val >>= (8 * (off & 3));

--
1.7.7.6

2013-01-12 14:16:44

by Hauke Mehrtens

Subject: Re: [PATCH 1/5] bcma: delete duplicate readl

On 01/12/2013 11:46 AM, Nathan Hintz wrote:
> The 'val' has already been read by the prior call to 'mips_busprobe32';
> this 'readl' is unnecessary.
>
> Signed-off-by: Nathan Hintz <[email protected]>

Acked-by: Hauke Mehrtens <[email protected]>

> ---
> drivers/bcma/driver_pci_host.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bcma/driver_pci_host.c b/drivers/bcma/driver_pci_host.c
> index 536d353..56073a5 100644
> --- a/drivers/bcma/driver_pci_host.c
> +++ b/drivers/bcma/driver_pci_host.c
> @@ -122,8 +122,6 @@ static int bcma_extpci_read_config(struct bcma_drv_pci *pc, unsigned int dev,
> val = 0xffffffff;
> goto unmap;
> }
> -
> - val = readl(mmio);
> }
> val >>= (8 * (off & 3));
>
>