2021-01-25 19:58:26

by Johannes Berg

Subject: Re: [PATCHv2] cfg80211: Skip key deletion for open associations

On Tue, 2021-01-26 at 00:50 +0530, [email protected] wrote:
> From: Chaitanya Tata <[email protected]>
>
> From: Chaitanya Tata <[email protected]>

That's broken, please check your git mail setup.

> * Delete all the keys ... pairwise keys can't really
> * exist any more anyway, but default keys might.
> */
> - if (rdev->ops->del_key) {
> + if (wdev->connect_keys && rdev->ops->del_key) {
>

This is wrong, wdev->connect_keys is not needed to make a secure
connection.

johannes

2021-01-25 20:10:17

by Krishna Chaitanya

Subject: Re: [PATCHv2] cfg80211: Skip key deletion for open associations

On Tue, Jan 26, 2021 at 1:21 AM Johannes Berg <[email protected]> wrote:
>
> On Tue, 2021-01-26 at 00:50 +0530, [email protected] wrote:
> > From: Chaitanya Tata <[email protected]>
> >
> > From: Chaitanya Tata <[email protected]>
>
> That's broken, please check your git mail setup.
Fixed.
>
>
> > * Delete all the keys ... pairwise keys can't really
> > * exist any more anyway, but default keys might.
> > */
> > - if (rdev->ops->del_key) {
> > + if (wdev->connect_keys && rdev->ops->del_key) {
> >
>
> This is wrong, wdev->connect_keys is not needed to make a secure
> connection.
Ah, I guess it's only for the WEP, right? From a quick look, we are not saving
connect params (connect.crypto), will take a deeper look, thanks.