2020-12-09 20:32:05

by Souptick Joarder

Subject: [PATCH] mt76: Fixed kernel test robot warning

Kernel test robot throws below warning ->

drivers/net/wireless/mediatek/mt76/tx.c: In function
'mt76_txq_schedule':
>> drivers/net/wireless/mediatek/mt76/tx.c:499:21: warning: variable 'q'
>> set but not used [-Wunused-but-set-variable]
499 | struct mt76_queue *q;
| ^

This patch will silence this warning.

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Souptick Joarder <[email protected]>
---
drivers/net/wireless/mediatek/mt76/tx.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/net/wireless/mediatek/mt76/tx.c b/drivers/net/wireless/mediatek/mt76/tx.c
index 1e20afb..25627e7 100644
--- a/drivers/net/wireless/mediatek/mt76/tx.c
+++ b/drivers/net/wireless/mediatek/mt76/tx.c
@@ -504,14 +504,11 @@ void mt76_tx_complete_skb(struct mt76_dev *dev, u16 wcid_idx, struct sk_buff *sk

void mt76_txq_schedule(struct mt76_phy *phy, enum mt76_txq_id qid)
{
- struct mt76_queue *q;
int len;

if (qid >= 4)
return;

- q = phy->q_tx[qid];
-
rcu_read_lock();

do {
--
1.9.1

2020-12-10 07:40:33

by Kalle Valo

Subject: Re: [PATCH] mt76: Fixed kernel test robot warning

Souptick Joarder <[email protected]> writes:

> Kernel test robot throws below warning ->
>
> drivers/net/wireless/mediatek/mt76/tx.c: In function
> 'mt76_txq_schedule':
>>> drivers/net/wireless/mediatek/mt76/tx.c:499:21: warning: variable 'q'
>>> set but not used [-Wunused-but-set-variable]
> 499 | struct mt76_queue *q;
> | ^
>
> This patch will silence this warning.
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Souptick Joarder <[email protected]>

I would like to take this directly to wireless-drivers-next, ok?

I'll also change the title to:

mt76: remove unused variable q

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2020-12-11 12:04:31

by Souptick Joarder

Subject: Re: [PATCH] mt76: Fixed kernel test robot warning

On Thu, Dec 10, 2020 at 12:46 PM Kalle Valo <[email protected]> wrote:
>
> Souptick Joarder <[email protected]> writes:
>
> > Kernel test robot throws below warning ->
> >
> > drivers/net/wireless/mediatek/mt76/tx.c: In function
> > 'mt76_txq_schedule':
> >>> drivers/net/wireless/mediatek/mt76/tx.c:499:21: warning: variable 'q'
> >>> set but not used [-Wunused-but-set-variable]
> > 499 | struct mt76_queue *q;
> > | ^
> >
> > This patch will silence this warning.
> >
> > Reported-by: kernel test robot <[email protected]>
> > Signed-off-by: Souptick Joarder <[email protected]>
>
> I would like to take this directly to wireless-drivers-next, ok?

Ok.
>
> I'll also change the title to:
>
> mt76: remove unused variable q
>
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2020-12-11 19:10:38

by Kalle Valo

Subject: Re: mt76: remove unused variable q

Souptick Joarder <[email protected]> wrote:

> Kernel test robot reported warning:
>
> drivers/net/wireless/mediatek/mt76/tx.c: In function
> 'mt76_txq_schedule':
> >> drivers/net/wireless/mediatek/mt76/tx.c:499:21: warning: variable 'q'
> >> set but not used [-Wunused-but-set-variable]
> 499 | struct mt76_queue *q;
> | ^
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Souptick Joarder <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

7f469b6dc484 mt76: remove unused variable q

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches