2016-01-24 12:35:17

by Hubert Tarasiuk

Subject: [PATCH] iwlwifi: dvm: handle zero brightness for wifi LED

This fixes bug 110551 with regard to sysfs.

Misleading behaviour when 'led_mode=3' is passed to iwlwifi is still
to be fixed (either by changing the option description or by making
the LED permanently dark in such case).

Signed-off-by: Hubert Tarasiuk <[email protected]>
---
drivers/net/wireless/iwlwifi/dvm/led.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/iwlwifi/dvm/led.c b/drivers/net/wireless/iwlwifi/dvm/led.c
index ca4d669..218617a 100644
--- a/drivers/net/wireless/iwlwifi/dvm/led.c
+++ b/drivers/net/wireless/iwlwifi/dvm/led.c
@@ -154,11 +154,14 @@ static void iwl_led_brightness_set(struct led_classdev *led_cdev,
{
struct iwl_priv *priv = container_of(led_cdev, struct iwl_priv, led);
unsigned long on = 0;
+ unsigned long off = 0;

if (brightness > 0)
on = IWL_LED_SOLID;
+ else
+ off = IWL_LED_SOLID;

- iwl_led_cmd(priv, on, 0);
+ iwl_led_cmd(priv, on, off);
}

static int iwl_led_blink_set(struct led_classdev *led_cdev,
--
2.7.0

2016-01-24 20:21:58

by Emmanuel Grumbach

Subject: Re: [PATCH] iwlwifi: dvm: handle zero brightness for wifi LED

On Sun, Jan 24, 2016 at 2:35 PM, Hubert Tarasiuk
<[email protected]> wrote:
> This fixes bug 110551 with regard to sysfs.
>
> Misleading behaviour when 'led_mode=3' is passed to iwlwifi is still
> to be fixed (either by changing the option description or by making
> the LED permanently dark in such case).
>
> Signed-off-by: Hubert Tarasiuk <[email protected]>
> ---
> drivers/net/wireless/iwlwifi/dvm/led.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)

I picked it up and will push it out soon.