2013-01-26 21:36:44

by Christian Lamparter

Subject: [PATCH 1/2] iwlegacy: fix antenna bitmask

This patch is based on "iwlwifi: fix antenna bitmask".
(362b0563b28506d53)

Like the new iwlagn devices, the old 4965N device only
supports a maximum of three antennas. Hence only three
bits are used, the fourth bit is likely the A-MPDU
indicator.

Cc: Stanislaw Gruszka <[email protected]>
Signed-off-by: Christian Lamparter <[email protected]>
---
drivers/net/wireless/iwlegacy/commands.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/iwlegacy/commands.h b/drivers/net/wireless/iwlegacy/commands.h
index 25dd7d2..829d3b9 100644
--- a/drivers/net/wireless/iwlegacy/commands.h
+++ b/drivers/net/wireless/iwlegacy/commands.h
@@ -1134,7 +1134,7 @@ struct il_wep_cmd {
#define RX_RES_PHY_FLAGS_MOD_CCK_MSK cpu_to_le16(1 << 1)
#define RX_RES_PHY_FLAGS_SHORT_PREAMBLE_MSK cpu_to_le16(1 << 2)
#define RX_RES_PHY_FLAGS_NARROW_BAND_MSK cpu_to_le16(1 << 3)
-#define RX_RES_PHY_FLAGS_ANTENNA_MSK 0xf0
+#define RX_RES_PHY_FLAGS_ANTENNA_MSK 0x70
#define RX_RES_PHY_FLAGS_ANTENNA_POS 4

#define RX_RES_STATUS_SEC_TYPE_MSK (0x7 << 8)
--
1.7.10.4

2013-01-28 10:02:40

by Stanislaw Gruszka

Subject: Re: [PATCH 1/2] iwlegacy: fix antenna bitmask

On Sat, Jan 26, 2013 at 10:19:35PM +0100, Christian Lamparter wrote:
> This patch is based on "iwlwifi: fix antenna bitmask".
> (362b0563b28506d53)
>
> Like the new iwlagn devices, the old 4965N device only
> supports a maximum of three antennas. Hence only three
> bits are used, the fourth bit is likely the A-MPDU
> indicator.
>
> Cc: Stanislaw Gruszka <[email protected]>
> Signed-off-by: Christian Lamparter <[email protected]>

ACK