2020-05-21 12:37:56

by Pali Rohár

Subject: [PATCH] mwifiex: Parse all API_VER_ID properties

During initialization of SD8997 wifi chip kernel prints warnings:

mwifiex_sdio mmc0:0001:1: Unknown api_id: 3
mwifiex_sdio mmc0:0001:1: Unknown api_id: 4

This patch adds support for parsing all api ids provided by SD8997
firmware.

Signed-off-by: Pali Rohár <[email protected]>
---
drivers/net/wireless/marvell/mwifiex/cmdevt.c | 17 +++++++++++++++--
drivers/net/wireless/marvell/mwifiex/fw.h | 2 ++
2 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/marvell/mwifiex/cmdevt.c b/drivers/net/wireless/marvell/mwifiex/cmdevt.c
index 7e4b8cd52..589cc5eb1 100644
--- a/drivers/net/wireless/marvell/mwifiex/cmdevt.c
+++ b/drivers/net/wireless/marvell/mwifiex/cmdevt.c
@@ -1581,8 +1581,21 @@ int mwifiex_ret_get_hw_spec(struct mwifiex_private *priv,
adapter->fw_api_ver =
api_rev->major_ver;
mwifiex_dbg(adapter, INFO,
- "Firmware api version %d\n",
- adapter->fw_api_ver);
+ "Firmware api version %d.%d\n",
+ adapter->fw_api_ver,
+ api_rev->minor_ver);
+ break;
+ case UAP_FW_API_VER_ID:
+ mwifiex_dbg(adapter, INFO,
+ "uAP api version %d.%d\n",
+ api_rev->major_ver,
+ api_rev->minor_ver);
+ break;
+ case CHANRPT_API_VER_ID:
+ mwifiex_dbg(adapter, INFO,
+ "channel report api version %d.%d\n",
+ api_rev->major_ver,
+ api_rev->minor_ver);
break;
default:
mwifiex_dbg(adapter, FATAL,
diff --git a/drivers/net/wireless/marvell/mwifiex/fw.h b/drivers/net/wireless/marvell/mwifiex/fw.h
index a415d73a7..6f86f5b96 100644
--- a/drivers/net/wireless/marvell/mwifiex/fw.h
+++ b/drivers/net/wireless/marvell/mwifiex/fw.h
@@ -1052,6 +1052,8 @@ struct host_cmd_ds_802_11_ps_mode_enh {
enum API_VER_ID {
KEY_API_VER_ID = 1,
FW_API_VER_ID = 2,
+ UAP_FW_API_VER_ID = 3,
+ CHANRPT_API_VER_ID = 4,
};

struct hw_spec_api_rev {
--
2.20.1

2020-05-28 10:31:04

by Pali Rohár

Subject: Re: [PATCH] mwifiex: Parse all API_VER_ID properties

On Thursday 21 May 2020 14:34:44 Pali Rohár wrote:
> During initialization of SD8997 wifi chip kernel prints warnings:
>
> mwifiex_sdio mmc0:0001:1: Unknown api_id: 3
> mwifiex_sdio mmc0:0001:1: Unknown api_id: 4
>
> This patch adds support for parsing all api ids provided by SD8997
> firmware.
>
> Signed-off-by: Pali Rohár <[email protected]>
> ---
> drivers/net/wireless/marvell/mwifiex/cmdevt.c | 17 +++++++++++++++--
> drivers/net/wireless/marvell/mwifiex/fw.h | 2 ++
> 2 files changed, 17 insertions(+), 2 deletions(-)
>

Hello! Could you please look at this trivial patch?

> diff --git a/drivers/net/wireless/marvell/mwifiex/cmdevt.c b/drivers/net/wireless/marvell/mwifiex/cmdevt.c
> index 7e4b8cd52..589cc5eb1 100644
> --- a/drivers/net/wireless/marvell/mwifiex/cmdevt.c
> +++ b/drivers/net/wireless/marvell/mwifiex/cmdevt.c
> @@ -1581,8 +1581,21 @@ int mwifiex_ret_get_hw_spec(struct mwifiex_private *priv,
> adapter->fw_api_ver =
> api_rev->major_ver;
> mwifiex_dbg(adapter, INFO,
> - "Firmware api version %d\n",
> - adapter->fw_api_ver);
> + "Firmware api version %d.%d\n",
> + adapter->fw_api_ver,
> + api_rev->minor_ver);
> + break;
> + case UAP_FW_API_VER_ID:
> + mwifiex_dbg(adapter, INFO,
> + "uAP api version %d.%d\n",
> + api_rev->major_ver,
> + api_rev->minor_ver);
> + break;
> + case CHANRPT_API_VER_ID:
> + mwifiex_dbg(adapter, INFO,
> + "channel report api version %d.%d\n",
> + api_rev->major_ver,
> + api_rev->minor_ver);
> break;
> default:
> mwifiex_dbg(adapter, FATAL,
> diff --git a/drivers/net/wireless/marvell/mwifiex/fw.h b/drivers/net/wireless/marvell/mwifiex/fw.h
> index a415d73a7..6f86f5b96 100644
> --- a/drivers/net/wireless/marvell/mwifiex/fw.h
> +++ b/drivers/net/wireless/marvell/mwifiex/fw.h
> @@ -1052,6 +1052,8 @@ struct host_cmd_ds_802_11_ps_mode_enh {
> enum API_VER_ID {
> KEY_API_VER_ID = 1,
> FW_API_VER_ID = 2,
> + UAP_FW_API_VER_ID = 3,
> + CHANRPT_API_VER_ID = 4,
> };
>
> struct hw_spec_api_rev {
> --
> 2.20.1
>

2020-05-29 03:48:46

by Ganapathi Bhat

Subject: RE: [EXT] Re: [PATCH] mwifiex: Parse all API_VER_ID properties

Hi Pali,

> Hello! Could you please look at this trivial patch?

The change look good.

Acked-by: Ganapathi Bhat <[email protected]>

2020-05-29 17:42:09

by Kalle Valo

Subject: Re: [PATCH] mwifiex: Parse all API_VER_ID properties

Pali Rohár <[email protected]> wrote:

> During initialization of SD8997 wifi chip kernel prints warnings:
>
> mwifiex_sdio mmc0:0001:1: Unknown api_id: 3
> mwifiex_sdio mmc0:0001:1: Unknown api_id: 4
>
> This patch adds support for parsing all api ids provided by SD8997
> firmware.
>
> Signed-off-by: Pali Rohár <[email protected]>
> Acked-by: Ganapathi Bhat <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

86cffb2c0a59 mwifiex: Parse all API_VER_ID properties

--
https://patchwork.kernel.org/patch/11562833/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches