2022-07-18 20:57:22

by Sean Wang

[permalink] [raw]
Subject: [PATCH 4/4] mt76: mt7921u: remove unnecessary MT76_STATE_SUSPEND

From: Sean Wang <[email protected]>

remove unnecessary MT76_STATE_SUSPEND manipulation to be consistent
with the mt7921[e, s] driver.

Signed-off-by: Sean Wang <[email protected]>
---
drivers/net/wireless/mediatek/mt76/mt7921/usb.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/usb.c b/drivers/net/wireless/mediatek/mt76/mt7921/usb.c
index 124d62c0dfa4..a8ea03d4f990 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/usb.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/usb.c
@@ -313,8 +313,6 @@ static int mt7921u_suspend(struct usb_interface *intf, pm_message_t state)
mt76u_stop_rx(&dev->mt76);
mt76u_stop_tx(&dev->mt76);

- set_bit(MT76_STATE_SUSPEND, &dev->mphy.state);
-
return 0;

failed:
@@ -354,8 +352,6 @@ static int mt7921u_resume(struct usb_interface *intf)
goto failed;
}

- clear_bit(MT76_STATE_SUSPEND, &dev->mphy.state);
-
err = mt76u_resume_rx(&dev->mt76);
if (err < 0)
goto failed;
--
2.25.1


2022-07-18 22:18:05

by Lorenzo Bianconi

[permalink] [raw]
Subject: Re: [PATCH 4/4] mt76: mt7921u: remove unnecessary MT76_STATE_SUSPEND

> From: Sean Wang <[email protected]>
>
> remove unnecessary MT76_STATE_SUSPEND manipulation to be consistent
> with the mt7921[e, s] driver.

Acked-by: Lorenzo Bianconi <[email protected]>

>
> Signed-off-by: Sean Wang <[email protected]>
> ---
> drivers/net/wireless/mediatek/mt76/mt7921/usb.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/usb.c b/drivers/net/wireless/mediatek/mt76/mt7921/usb.c
> index 124d62c0dfa4..a8ea03d4f990 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/usb.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/usb.c
> @@ -313,8 +313,6 @@ static int mt7921u_suspend(struct usb_interface *intf, pm_message_t state)
> mt76u_stop_rx(&dev->mt76);
> mt76u_stop_tx(&dev->mt76);
>
> - set_bit(MT76_STATE_SUSPEND, &dev->mphy.state);
> -
> return 0;
>
> failed:
> @@ -354,8 +352,6 @@ static int mt7921u_resume(struct usb_interface *intf)
> goto failed;
> }
>
> - clear_bit(MT76_STATE_SUSPEND, &dev->mphy.state);
> -
> err = mt76u_resume_rx(&dev->mt76);
> if (err < 0)
> goto failed;
> --
> 2.25.1
>

Attachments:
(No filename) (1.13 kB)
 signature.asc (235.00 B)
 Download all attachments