2024-04-16 22:19:06

by Paul Geurts

Subject: [PATCH 1/2] dt-bindings: net/nfc: ti,trf7970a: Add rx-gain-reduction option

Add option to reduce the RX antenna gain to be able to reduce the
sensitivity.

Signed-off-by: Paul Geurts <[email protected]>
---
Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml b/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml
index d0332eb76ad2..bbd045f6cf04 100644
--- a/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml
+++ b/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml
@@ -55,6 +55,11 @@ properties:
description: |
Regulator for supply voltage to VIN pin

+ rx-gain-reduction:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: |
+ Specify a RX gain reduction to reduce antenna sensitivity.
+
required:
- compatible
- interrupts
@@ -95,5 +100,6 @@ examples:
irq-status-read-quirk;
en2-rf-quirk;
clock-frequency = <27120000>;
+ rx-gain-reduction = <3>;
};
};
--
2.20.1

2024-04-19 07:31:04

by Paul Geurts

Subject: Re: [PATCH 1/2] dt-bindings: net/nfc: ti,trf7970a: Add rx-gain-reduction option

On 17-04-2024 15:12, Krzysztof Kozlowski wrote:
> On 17/04/2024 00:18, Paul Geurts wrote:
>> Add option to reduce the RX antenna gain to be able to reduce the
>> sensitivity.
>>
>> Signed-off-by: Paul Geurts <[email protected]>
>> ---
>> Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml b/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml
>> index d0332eb76ad2..bbd045f6cf04 100644
>> --- a/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml
>> +++ b/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml
>> @@ -55,6 +55,11 @@ properties:
>> description: |
>> Regulator for supply voltage to VIN pin
>>
>> + rx-gain-reduction:
> Missing vendor prefix.
>
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + description: |
> Do not need '|' unless you need to preserve formatting.
>
>> + Specify a RX gain reduction to reduce antenna sensitivity.
> Reduction by what? What are the units?

Yes, this is a bit unclear indeed. Will clarify this.

>
>
> Best regards,
> Krzysztof

Thanks!

br,

Paul