Hermes Zhang <[email protected]> writes:
> From: Hermes Zhang <[email protected]>
>
> The PNO feature need to be disable for some scenario in different
> product. This commit introduce a new property to allow the
> product-specific toggling of this feature.
"some scenario"? That's not really helpful.
> Signed-off-by: Hermes Zhang <[email protected]>
> ---
>
> Notes:
> Change property name to brcm,pno-disable
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
> index 8623bde5eb70..121a195e4054 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
> @@ -11,6 +11,7 @@
> #include "core.h"
> #include "common.h"
> #include "of.h"
> +#include "feature.h"
>
> static int brcmf_of_get_country_codes(struct device *dev,
> struct brcmf_mp_device *settings)
> @@ -102,6 +103,9 @@ void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type,
> if (bus_type != BRCMF_BUSTYPE_SDIO)
> return;
>
> + if (of_find_property(np, "brcm,pno-disable", NULL))
> + settings->feature_disable |= BIT(BRCMF_FEAT_PNO);
Is this DT property documented and acked by the Device Tree maintainers?
AFAIK DT is not supposed to be used as a software configuration
database.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
On 4/22/2022 7:59 AM, Kalle Valo wrote:
> Hermes Zhang <[email protected]> writes:
>
>> From: Hermes Zhang <[email protected]>
>>
>> The PNO feature need to be disable for some scenario in different
>> product. This commit introduce a new property to allow the
>> product-specific toggling of this feature.
>
> "some scenario"? That's not really helpful.
The firmware feature PNO is used to provide the scheduled scan
functionality. User-space can choose whether or not to use scheduled
scan. If the scheduled scan is not working I would rather see a bug
report so it can be properly investigated.
Regards,
Arend