On 05/06/2024 14:38, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <[email protected]>
>
> This adds the power sequencing driver for the PMU modules present on the
> Qualcomm WCN Bluetooth and Wifi chipsets. It uses the pwrseq subsystem
> and knows how to match the sequencer to the consumer device by verifying
> the relevant properties and DT layout. Using this driver will allow the
> BT and WLAN drivers to respect the required delays between enabling the
> two modules.
...
> +
> +static const struct of_device_id pwrseq_qcom_wcn_of_match[] = {
> + {
> + .compatible = "qcom,qca6390-pmu",
> + .data = &pwrseq_qca6390_of_data,
Bindings *must* be part of this patchset. I missed the moment this was
split into such chunks.
Best regards,
Krzysztof
On Mon, Jun 10, 2024 at 4:54 PM Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 05/06/2024 14:38, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <[email protected]>
> >
> > This adds the power sequencing driver for the PMU modules present on the
> > Qualcomm WCN Bluetooth and Wifi chipsets. It uses the pwrseq subsystem
> > and knows how to match the sequencer to the consumer device by verifying
> > the relevant properties and DT layout. Using this driver will allow the
> > BT and WLAN drivers to respect the required delays between enabling the
> > two modules.
>
> ...
>
> > +
> > +static const struct of_device_id pwrseq_qcom_wcn_of_match[] = {
> > + {
> > + .compatible = "qcom,qca6390-pmu",
> > + .data = &pwrseq_qca6390_of_data,
>
> Bindings *must* be part of this patchset. I missed the moment this was
> split into such chunks.
>
> Best regards,
> Krzysztof
>
The bindings are already in next via Mark Brown's tree.
Bart
On 10/06/2024 16:55, Bartosz Golaszewski wrote:
> On Mon, Jun 10, 2024 at 4:54 PM Krzysztof Kozlowski
> <[email protected]> wrote:
>>
>> On 05/06/2024 14:38, Bartosz Golaszewski wrote:
>>> From: Bartosz Golaszewski <[email protected]>
>>>
>>> This adds the power sequencing driver for the PMU modules present on the
>>> Qualcomm WCN Bluetooth and Wifi chipsets. It uses the pwrseq subsystem
>>> and knows how to match the sequencer to the consumer device by verifying
>>> the relevant properties and DT layout. Using this driver will allow the
>>> BT and WLAN drivers to respect the required delays between enabling the
>>> two modules.
>>
>> ...
>>
>>> +
>>> +static const struct of_device_id pwrseq_qcom_wcn_of_match[] = {
>>> + {
>>> + .compatible = "qcom,qca6390-pmu",
>>> + .data = &pwrseq_qca6390_of_data,
>>
>> Bindings *must* be part of this patchset. I missed the moment this was
>> split into such chunks.
>>
>> Best regards,
>> Krzysztof
>>
>
> The bindings are already in next via Mark Brown's tree.
OK, I checked linux-next from a day before Mark merged it. Cover letter
should mention it, because it is a bit unusual (and would save you
reviewer's question).
Best regards,
Krzysztof