2021-04-02 17:10:01

by Christophe JAILLET

Subject: [PATCH] rtlwifi: remove rtl_get_tid_h

'rtl_get_tid_h()' is the same as 'ieee80211_get_tid()'.
So this function can be removed to save a line of code.

Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/net/wireless/realtek/rtlwifi/wifi.h | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/wifi.h b/drivers/net/wireless/realtek/rtlwifi/wifi.h
index fdccfd29fd61..9119144bb5a3 100644
--- a/drivers/net/wireless/realtek/rtlwifi/wifi.h
+++ b/drivers/net/wireless/realtek/rtlwifi/wifi.h
@@ -3086,14 +3086,9 @@ static inline __le16 rtl_get_fc(struct sk_buff *skb)
return rtl_get_hdr(skb)->frame_control;
}

-static inline u16 rtl_get_tid_h(struct ieee80211_hdr *hdr)
-{
- return (ieee80211_get_qos_ctl(hdr))[0] & IEEE80211_QOS_CTL_TID_MASK;
-}
-
static inline u16 rtl_get_tid(struct sk_buff *skb)
{
- return rtl_get_tid_h(rtl_get_hdr(skb));
+ return ieee80211_get_tid(rtl_get_hdr(skb));
}

static inline struct ieee80211_sta *get_sta(struct ieee80211_hw *hw,
--
2.27.0

2021-04-17 17:32:37

by Kalle Valo

Subject: Re: [PATCH] rtlwifi: remove rtl_get_tid_h

Christophe JAILLET <[email protected]> wrote:

> 'rtl_get_tid_h()' is the same as 'ieee80211_get_tid()'.
> So this function can be removed to save a line of code.
>
> Signed-off-by: Christophe JAILLET <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

987e9bcdd0b7 rtlwifi: remove rtl_get_tid_h

--
https://patchwork.kernel.org/project/linux-wireless/patch/db340a67a95c119e4f9ba8fa99aea1c73d0dcfc9.1617383263.git.christophe.jaillet@wanadoo.fr/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches