2020-09-18 18:32:17

by Christian Marangi

[permalink] [raw]
Subject: R: [PATCH 2/2] dt: bindings: ath10k: Document qcom, ath10k-pre-calibration-data-mtd



> -----Messaggio originale-----
> Da: Christian Lamparter <[email protected]>
> Inviato: venerdì 18 settembre 2020 18:54
> A: Ansuel Smith <[email protected]>; Kalle Valo
> <[email protected]>
> Cc: [email protected]; [email protected]; linux-
> [email protected]; [email protected];
> [email protected]; David S. Miller <[email protected]>; Rob
> Herring <[email protected]>; Jakub Kicinski <[email protected]>; linux-
> [email protected]; Srinivas Kandagatla
> <[email protected]>; Bartosz Golaszewski
> <[email protected]>
> Oggetto: Re: [PATCH 2/2] dt: bindings: ath10k: Document qcom, ath10k-
> pre-calibration-data-mtd
>
> On 2020-09-18 18:29, Ansuel Smith wrote:
> > Document use of qcom,ath10k-pre-calibration-data-mtd bindings used to
> > define from where the driver will load the pre-cal data in the defined
> > mtd partition.
> >
> > Signed-off-by: Ansuel Smith <[email protected]>
>
> Q: Doesn't mtd now come with nvmem support from the get go? So
> the MAC-Addresses and pre-caldata could be specified as a
> nvmem-node in the devicetree? I remember seeing that this was
> worked on or was this mtd->nvmem dropped?
>
> Cheers,
> Christian

Sorry a lot for the double email... I think I found what you are talking about.
It looks like the code was merged but not the documentation.
Will do some test and check if this works.

This should be the related patch.
https://patchwork.ozlabs.org/project/linux-mtd/patch/[email protected]/



2020-09-18 18:56:26

by Christian Lamparter

[permalink] [raw]
Subject: Re: R: [PATCH 2/2] dt: bindings: ath10k: Document qcom, ath10k-pre-calibration-data-mtd

On 2020-09-18 20:31, [email protected] wrote:
>
>
>> -----Messaggio originale-----
>> Da: Christian Lamparter <[email protected]>
>> Inviato: venerdì 18 settembre 2020 18:54
>> A: Ansuel Smith <[email protected]>; Kalle Valo
>> <[email protected]>
>> Cc: [email protected]; [email protected]; linux-
>> [email protected]; [email protected];
>> [email protected]; David S. Miller <[email protected]>; Rob
>> Herring <[email protected]>; Jakub Kicinski <[email protected]>; linux-
>> [email protected]; Srinivas Kandagatla
>> <[email protected]>; Bartosz Golaszewski
>> <[email protected]>
>> Oggetto: Re: [PATCH 2/2] dt: bindings: ath10k: Document qcom, ath10k-
>> pre-calibration-data-mtd
>>
>> On 2020-09-18 18:29, Ansuel Smith wrote:
>>> Document use of qcom,ath10k-pre-calibration-data-mtd bindings used to
>>> define from where the driver will load the pre-cal data in the defined
>>> mtd partition.
>>>
>>> Signed-off-by: Ansuel Smith <[email protected]>
>>
>> Q: Doesn't mtd now come with nvmem support from the get go? So
>> the MAC-Addresses and pre-caldata could be specified as a
>> nvmem-node in the devicetree? I remember seeing that this was
>> worked on or was this mtd->nvmem dropped?
>>
>> Cheers,
>> Christian
>
> Sorry a lot for the double email... I think I found what you are talking about.
> It looks like the code was merged but not the documentation.
> Will do some test and check if this works.
>
> This should be the related patch.
> https://patchwork.ozlabs.org/project/linux-mtd/patch/[email protected]/
>

Well, I guess the version that was merged:

|commit c4dfa25ab307a277eafa7067cd927fbe4d9be4ba
|Author: Alban Bedel <[email protected]>
|Date: Tue Nov 13 15:01:10 2018 +0100
|
| mtd: add support for reading MTD devices via the nvmem API
|
| Allow drivers that use the nvmem API to read data stored on MTD devices.
| For this the mtd devices are registered as read-only NVMEM providers.
|
| >>>We don't support device tree systems for now.<<<

answers this. Sorry for the noise. Yee, this likely isn't going to work
as it is still disabled on purpose.

Regards,
Christian