2021-10-19 07:55:36

by Yang Li

[permalink] [raw]
Subject: [PATCH -next] rtw89: remove unneeded semicolon

Eliminate the following coccicheck warning:
./drivers/net/wireless/realtek/rtw89/pci.c:1348:2-3: Unneeded semicolon

Reported-by: Abaci Robot <[email protected]>
Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
Signed-off-by: Yang Li <[email protected]>
---
drivers/net/wireless/realtek/rtw89/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtw89/pci.c b/drivers/net/wireless/realtek/rtw89/pci.c
index e973101..2c94762 100644
--- a/drivers/net/wireless/realtek/rtw89/pci.c
+++ b/drivers/net/wireless/realtek/rtw89/pci.c
@@ -1345,7 +1345,7 @@ static int rtw89_pci_check_mdio(struct rtw89_dev *rtwdev, u8 addr, u8 speed, u16
default:
rtw89_err(rtwdev, "[ERR]Error Speed %d!\n", speed);
return -EINVAL;
- };
+ }
rtw89_write16(rtwdev, R_AX_MDIO_CFG, val);
rtw89_write16_set(rtwdev, R_AX_MDIO_CFG, rw_bit);

--
1.8.3.1


2021-10-20 08:51:36

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH -next] rtw89: remove unneeded semicolon

Yang Li <[email protected]> wrote:

> Eliminate the following coccicheck warning:
> ./drivers/net/wireless/realtek/rtw89/pci.c:1348:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <[email protected]>
> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> Signed-off-by: Yang Li <[email protected]>
> Acked-by: Ping-Ke Shih <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

e0e037b9fe5f rtw89: remove unneeded semicolon

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2022-04-27 08:35:56

by Ping-Ke Shih

[permalink] [raw]
Subject: RE: [PATCH -next] rtw89: remove unneeded semicolon



> -----Original Message-----
> From: Yang Li <[email protected]>
> Sent: Wednesday, April 27, 2022 8:32 AM
> To: [email protected]
> Cc: [email protected]; [email protected]; [email protected]; Pkshih <[email protected]>;
> [email protected]; [email protected]; [email protected]; Yang Li
> <[email protected]>; Abaci Robot <[email protected]>
> Subject: [PATCH -next] rtw89: remove unneeded semicolon
>
> Eliminate the following coccicheck warning:
> ./drivers/net/wireless/realtek/rtw89/rtw8852c.c:2556:2-3: Unneeded
> semicolon
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>

Acked-by: Ping-Ke Shih <[email protected]>

> ---
> drivers/net/wireless/realtek/rtw89/rtw8852c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852c.c
> b/drivers/net/wireless/realtek/rtw89/rtw8852c.c
> index 858611c64e6b..275568468212 100644
> --- a/drivers/net/wireless/realtek/rtw89/rtw8852c.c
> +++ b/drivers/net/wireless/realtek/rtw89/rtw8852c.c
> @@ -2553,7 +2553,7 @@ do { \
> default:
> val = arg.gnt_bt.data;
> break;
> - };
> + }
>
> __write_ctrl(R_AX_PWR_COEXT_CTRL, B_AX_TXAGC_BT_MASK, val,
> B_AX_TXAGC_BT_EN, arg.ctrl_gnt_bt != 0xffff);
> --
> 2.20.1.7.g153144c