From: Luca Coelho <[email protected]>
Hi,
Here's the seventh set of patches intended for v5.12. It's the usual
development, new features, cleanups and bugfixes.
The changes are:
* Bump the FW API support version;
* Implement support for PNVM from BIOS;
* Fix PM status when a FW crash happens;
* Some other small fixes, clean-ups and improvements.
As usual, I'm pushing this to a pending branch, for kbuild bot, and
will send a pull-request later.
Please review.
Cheers,
Luca.
Golan Ben Ami (1):
iwlwifi: mvm: reduce the print severity of failing getting NIC temp
Luca Coelho (5):
iwlwifi: pnvm: set the PNVM again if it was already loaded
iwlwifi: pnvm: increment the pointer before checking the TLV
iwlwifi: pnvm: move file loading code to a separate function
iwlwifi: pnvm: implement reading PNVM from UEFI
iwlwifi: bump FW API to 62 for AX devices
Matti Gottlieb (1):
iwlwifi: pcie: define FW_RESET_TIMEOUT for clarity
Ravi Darsi (1):
iwlwifi: mvm: global PM mode does not reset after FW crash
.../net/wireless/intel/iwlwifi/cfg/22000.c | 2 +-
drivers/net/wireless/intel/iwlwifi/fw/pnvm.c | 190 ++++++++++++++----
drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 1 +
drivers/net/wireless/intel/iwlwifi/mvm/tt.c | 2 +-
.../intel/iwlwifi/pcie/ctxt-info-gen3.c | 21 +-
.../wireless/intel/iwlwifi/pcie/trans-gen2.c | 4 +-
6 files changed, 172 insertions(+), 48 deletions(-)
--
2.30.0
From: Golan Ben Ami <[email protected]>
Currently, for all devices and families, failing getting the temp
from the fw is indicated in the log as ERR.
This is too severe for two reasons:
1. The driver has a fall back - and schedules the next temp
read immediately after failing to read temp from the fw.
2. The temp read implementation in the fw is different between
HWs, and on older devices the flow is a-sync and may timeout.
Reducing the print severity from ERR to WARN will allow to
track the issue if it will appear many times, but not frighten users
if it appears once.
Signed-off-by: Golan Ben Ami <[email protected]>
Signed-off-by: Luca Coelho <[email protected]>
---
drivers/net/wireless/intel/iwlwifi/mvm/tt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
index 790bc68a515a..2a7339b12b13 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
@@ -261,7 +261,7 @@ int iwl_mvm_get_temp(struct iwl_mvm *mvm, s32 *temp)
ret = iwl_wait_notification(&mvm->notif_wait, &wait_temp_notif,
IWL_MVM_TEMP_NOTIF_WAIT_TIMEOUT);
if (ret)
- IWL_ERR(mvm, "Getting the temperature timed out\n");
+ IWL_WARN(mvm, "Getting the temperature timed out\n");
return ret;
}
--
2.30.0
Luca Coelho <[email protected]> wrote:
> From: Golan Ben Ami <[email protected]>
>
> Currently, for all devices and families, failing getting the temp
> from the fw is indicated in the log as ERR.
> This is too severe for two reasons:
> 1. The driver has a fall back - and schedules the next temp
> read immediately after failing to read temp from the fw.
> 2. The temp read implementation in the fw is different between
> HWs, and on older devices the flow is a-sync and may timeout.
>
> Reducing the print severity from ERR to WARN will allow to
> track the issue if it will appear many times, but not frighten users
> if it appears once.
>
> Signed-off-by: Golan Ben Ami <[email protected]>
> Signed-off-by: Luca Coelho <[email protected]>
6 patches applied to iwlwifi-next.git, thanks.
c61734a69caf iwlwifi: mvm: reduce the print severity of failing getting NIC temp
11dd729afa48 iwlwifi: mvm: global PM mode does not reset after FW crash
4a81598f0f39 iwlwifi: pnvm: set the PNVM again if it was already loaded
25df65ae8a92 iwlwifi: pcie: define FW_RESET_TIMEOUT for clarity
ff11a8ee2d2d iwlwifi: pnvm: increment the pointer before checking the TLV
cdda18fbbefa iwlwifi: pnvm: move file loading code to a separate function