Return-path: Received: from deine-taler.de ([217.160.107.63]:53308 "EHLO p15091797.pureserver.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751821AbXBJT4x (ORCPT ); Sat, 10 Feb 2007 14:56:53 -0500 Date: Sat, 10 Feb 2007 20:56:52 +0100 From: Ulrich Kunitz To: Joe Perches Cc: Michael Buesch , Daniel Drake , linville@tuxdriver.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, rpjday@mindspring.com Subject: Re: [PATCH] zd1211rw: Readd zd_addr_t cast Message-ID: <20070210195652.GA16406@p15091797.pureserver.info> References: <20070210012718.3B6E87B409F@zog.reactivated.net> <200702100702.15264.mb@bu3sch.de> <1171133498.20342.59.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1171133498.20342.59.camel@localhost> Sender: linux-wireless-owner@vger.kernel.org List-ID: On 07-02-10 10:51 Joe Perches wrote: > On Sat, 2007-02-10 at 07:02 +0100, Michael Buesch wrote: > > On Saturday 10 February 2007 02:27, Daniel Drake wrote: > > > Robert P.J. Day's recent commit ("getting rid of all casts of k[cmz]alloc() > > > calls") introduced a sparse warning for zd1211rw, related to our type-checking > > > of addresses. > > > > zd_chip.c:116:15: warning: implicit cast to nocast type > > > This patch readds the type cast, it is correct. > > > Signed-off-by: Daniel Drake > > > Index: linux/drivers/net/wireless/zd1211rw/zd_chip.c > > > =================================================================== > > > --- linux.orig/drivers/net/wireless/zd1211rw/zd_chip.c > > > +++ linux/drivers/net/wireless/zd1211rw/zd_chip.c > > > @@ -113,7 +113,7 @@ int zd_ioread32v_locked(struct zd_chip * > > > > > > /* Allocate a single memory block for values and addresses. */ > > > count16 = 2*count; > > > - a16 = kmalloc(count16 * (sizeof(zd_addr_t) + sizeof(u16)), > > > + a16 = (zd_addr_t *) kmalloc(count16 * (sizeof(zd_addr_t) + sizeof(u16)), > > > GFP_NOFS); > > I think it better to remove this __nocast instead. > This is the only use of __nocast outside of kmem in the kernel tree. > > Why not just remove __nocast and use u16 instead of zd_addr_t? Using the __nocast type sparse catches errors, when address and value arguments are used in the wrong order for calls of the zd_ioread* and zd_iowrite* functions. I'm a lazy guy, I like tools do the hard work for me. > If not the removal of the __nocast, would it be better to have a > void pointer there? I don't think that an explicit cast requires the introduction of a temporary variable. -- Uli Kunitz